mbox series

[0/3] i586/i686: Fix multiple definitions in libc.a

Message ID 20240430200506.2717717-1-gabifalk@gmx.com
Headers
Series i586/i686: Fix multiple definitions in libc.a |

Message

Gabi Falk April 30, 2024, 8:05 p.m. UTC 
  This patch fixes two issues related to multiple definitions of functions
in the static library built as PIC and adds a test to prevent such
issues from occurring in the future.

Gabi Falk (3):
  i586: Fix multiple definitions of __memcpy_chk and __mempcpy_chk
  i686: Fix multiple definitions of __memmove_chk and __memset_chk
  Add a test to check for duplicate definitions in the static library

 Makefile                    | 7 +++++++
 sysdeps/i386/i586/memcpy.S  | 2 +-
 sysdeps/i386/i686/memmove.S | 2 +-
 sysdeps/i386/i686/memset.S  | 2 +-
 4 files changed, 10 insertions(+), 3 deletions(-)

--
gabi

Comments

Dmitry V. Levin May 1, 2024, 12:01 a.m. UTC | #1 
On Tue, Apr 30, 2024 at 08:05:01PM +0000, Gabi Falk wrote:
> This patch fixes two issues related to multiple definitions of functions
> in the static library built as PIC and adds a test to prevent such
> issues from occurring in the future.
> 
> Gabi Falk (3):
>   i586: Fix multiple definitions of __memcpy_chk and __mempcpy_chk
>   i686: Fix multiple definitions of __memmove_chk and __memset_chk
>   Add a test to check for duplicate definitions in the static library
> 
>  Makefile                    | 7 +++++++
>  sysdeps/i386/i586/memcpy.S  | 2 +-
>  sysdeps/i386/i686/memmove.S | 2 +-
>  sysdeps/i386/i686/memset.S  | 2 +-
>  4 files changed, 10 insertions(+), 3 deletions(-)

For all the series:
Reviewed-by: Dmitry V. Levin <ldv@altlinux.org>
Sam James May 2, 2024, 10:52 a.m. UTC | #2 
Gabi Falk <gabifalk@gmx.com> writes:

> This patch fixes two issues related to multiple definitions of functions
> in the static library built as PIC and adds a test to prevent such
> issues from occurring in the future.
>
> Gabi Falk (3):
>   i586: Fix multiple definitions of __memcpy_chk and __mempcpy_chk
>   i686: Fix multiple definitions of __memmove_chk and __memset_chk
>   Add a test to check for duplicate definitions in the static library

Thanks! Pushed with Tested-by for the i686 commit specifically too.

>
>  Makefile                    | 7 +++++++
>  sysdeps/i386/i586/memcpy.S  | 2 +-
>  sysdeps/i386/i686/memmove.S | 2 +-
>  sysdeps/i386/i686/memset.S  | 2 +-
>  4 files changed, 10 insertions(+), 3 deletions(-)