From patchwork Sat May 13 04:02:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: develop--- via Libc-alpha X-Patchwork-Id: 55760 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EA9B33854146 for ; Sat, 13 May 2023 04:03:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EA9B33854146 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1683950581; bh=ifEyaLGcRqr8NprRz7kooTCj/YzM4nb10FUiuilJ5ns=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=G0kmZsDj1LVRoxcX0Q0sTY2iwWiIi02VIWbmeHuD5GQrKRNYR5M2+rw8gAEUsK7PC pWsSRJ2qFsBjTk2I8+ovUwUe3Bo+1vyqPgWsw+m2UrEnAJT+kYasidIzYCAeMR9Pie 02EftkJXdWF8Gy6Dw4Q+fpGf6zbQTv4ThY8uIx9I= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by sourceware.org (Postfix) with ESMTPS id E930D3858412 for ; Sat, 13 May 2023 04:02:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E930D3858412 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id F21445C028E; Sat, 13 May 2023 00:02:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 13 May 2023 00:02:33 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeehuddgkedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomhepmhgrlhhtvghs khgrrhhuphhkvgesfhgrshhtmhgrihhlrdhfmhenucggtffrrghtthgvrhhnpedvuddvff dtvefgkefgjeeuvdefffefleehheduveffjeeffedvffegheehkedtgeenucffohhmrghi nhepshhouhhrtggvfigrrhgvrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepmhgrlhhtvghskhgrrhhuphhkvgesfhgrshhtmhgrihhl rdhfmh X-ME-Proxy: Feedback-ID: ifa6c408f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 13 May 2023 00:02:32 -0400 (EDT) To: libc-alpha@sourceware.org Cc: Malte Skarupke Subject: [PATCH v5 0/9] Patch to fix glibc condition variable bug (BZ 25847) Date: Sat, 13 May 2023 00:02:15 -0400 Message-Id: <20230513040224.8057-1-malteskarupke@fastmail.fm> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: malteskarupke--- via Libc-alpha From: develop--- via Libc-alpha Reply-To: malteskarupke@fastmail.fm Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" From: Malte Skarupke This is v5 of the patches, v1 here: https://sourceware.org/pipermail/libc-alpha/2023-January/145023.html I added Frank Barrus' signed-off message and removed the unnecessary "unused" struct member of pthread_cond_t. Diff of diffs: v2 - use release MO when modifying g_signals in pthread_cond_common in the first patch v3 - add sign-off statement to commit messages v4 - I had missed the sign-off statement in one of my patches v5 - add Frank Barrus' sign-off statement and remove unneeded "unused" member in pthread_cond_t Frank Barrus (1): pthreads NPTL: lost wakeup fix 2 Malte Skarupke (8): nptl: Update comments and indentation for new condvar implementation nptl: Remove unnecessary catch-all-wake in condvar group switch nptl: Remove unnecessary quadruple check in pthread_cond_wait nptl: Remove g_refs from condition variables nptl: Use a single loop in pthread_cond_wait instaed of a nested loop nptl: Fix indentation nptl: rename __condvar_quiesce_and_switch_g1 nptl: Use all of g1_start and g_signals nptl/pthread_cond_broadcast.c | 8 +- nptl/pthread_cond_common.c | 109 ++-------- nptl/pthread_cond_signal.c | 19 +- nptl/pthread_cond_wait.c | 278 +++++------------------- nptl/tst-cond22.c | 12 +- sysdeps/nptl/bits/thread-shared-types.h | 3 +- sysdeps/nptl/pthread.h | 2 +- 7 files changed, 99 insertions(+), 332 deletions(-)