From patchwork Mon Mar 20 16:01:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 55599 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E2648385B529 for ; Mon, 20 Mar 2023 16:01:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E2648385B529 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1679328107; bh=AtVgU+JHOMBVFHwtCtq6v8YCKKOLrAaIJTReceaX3qo=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=GEHyZWdFX3Z2GXw8dp+WJv7wu0psAkTe0VpzmDoz7t8D17viXHET8a0yX6jWMFmTO npJTCmGc/HCLSnoOdpUx5TYqpdHtyDQ3FMPJTH8crhoHJpmNPZRzUup6AgdRyymSFX GaTOBtZaAw9rf3jB2wSbYMDnThoYJ4K0ujfaw1OI= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-oa1-x32.google.com (mail-oa1-x32.google.com [IPv6:2001:4860:4864:20::32]) by sourceware.org (Postfix) with ESMTPS id 9FB8E3858418 for ; Mon, 20 Mar 2023 16:01:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9FB8E3858418 Received: by mail-oa1-x32.google.com with SMTP id 586e51a60fabf-17786581fe1so13468334fac.10 for ; Mon, 20 Mar 2023 09:01:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679328083; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AtVgU+JHOMBVFHwtCtq6v8YCKKOLrAaIJTReceaX3qo=; b=pI3F50ZiFAThzBV+cBzlzaZyvAfxQov5fSXtgUpKAltywGjyJXT6hLQWA02lRXjPvs EYXhG7Y9SUooqHIVNPJUb88NPslwKj9v3wKNfgUjzT6UaEPL+vQq0qd/tlk8jKSXlLs5 S1D9kIqmb3e7LMYeGxOXr1x4hAvXMZ6bUfAecVsGntyoFAV+sSFBQJjpgy2t3ld1BEfO UgB1YClrQqkHm6qpD9/RSX0Suki6z90x0H7RHoyI5gftHP6ex64jjc11C9fCpH4ecOzF +htZdzJ0lhkdvSud77OvoNWGanWPsfDP+bHqBs3l9eZ2NptI4WWfq76frSm0gnTUrcdj jiiQ== X-Gm-Message-State: AO0yUKUhByUkEHIsWraKxGPdm6dXhAUtEsCnscF1xWfazTpIPzDeRYJn A2vRY3NU+gCnJ04YxbM5JOsuaWD1UpAZLr6av6YFsw== X-Google-Smtp-Source: AK7set8E7B1IvgtpaVERGCtyxvDM91FdmkZEzxbZCnZKCkBGRMxH3pI4YNChdzAWyX0vPUnpJbT/Jw== X-Received: by 2002:a05:6870:14d5:b0:177:b0ee:b034 with SMTP id l21-20020a05687014d500b00177b0eeb034mr5697068oab.43.1679328083398; Mon, 20 Mar 2023 09:01:23 -0700 (PDT) Received: from mandiga.. ([2804:1b3:a7c0:c260:e868:74cf:5638:4f8]) by smtp.gmail.com with ESMTPSA id ax35-20020a05687c022300b0017243edbe5bsm3355725oac.58.2023.03.20.09.01.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 09:01:22 -0700 (PDT) To: libc-alpha@sourceware.org, Wilco Dijkstra , "H . J . Lu" Subject: [PATCH v4 0/5] Improve fmod and fmodf Date: Mon, 20 Mar 2023 13:01:13 -0300 Message-Id: <20230320160118.352206-1-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Netto Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" This is an updated version of a previous submission aimed to improve fmod implementation [1] by Kirill Okhotnikov. I extended it with: 1. Proper benchmarks for both single and double. The inputs are divided in 3 subsets: subnormals, normal nubmers, and close exponents. It uses a list with random generated values. 2. Use math_config.h definitions instead math_private (so it might eventually get back on optimize-routines). 3. Implement the same strategy for float version. 4. Also tuned the final division to use multiplication with inverse instead of direct modulo. It showed better performance on both x86_64 and aarch64 chips I have tested. 5. Remove SVID error handling wrapper. The performance shows a good improvement compared to current algorithm for fmod (using gcc 11): Architecture | Input | master | patch -----------------|-----------------|----------|-------- x86_64 (Ryzen 9) | subnormals | 19.1584 | 9.40992 x86_64 (Ryzen 9) | normal | 1016.51 | 296.738 x86_64 (Ryzen 9) | close-exponents | 18.4428 | 13.119 aarch64 (N1) | subnormal | 11.153 | 4.33313 aarch64 (N1) | normal | 528.649 | 158.339 aarch64 (N1) | close-exponents | 11.4517 | 5.76138 I also see similar improvements on arm-linux-gnueabihf when running on the N1 aarch64 chips, where it uses a lot of soft-fp implementation (for modulo, clz, ctz, and multiplication): Architecture | Input | master | patch -----------------|-----------------|----------|-------- armhf (N1) | subnormal | 15.7284 | 14.5746 armhf (N1) | normal | 837.525 | 241.738 armhf (N1) | close-exponents | 16.2111 | 22.457 The fmodf shows a more moderate improvement: Architecture | Input | master | patch -----------------|-----------------|----------|-------- x86_64 (Ryzen 9) | subnormals | 17.2549 | 9.35776 x86_64 (Ryzen 9) | normal | 85.4096 | 46.2761 x86_64 (Ryzen 9) | close-exponents | 19.1072 | 12.6199 aarch64 (N1) | subnormal | 10.2182 | 4.39188 aarch64 (N1) | normal | 60.0616 | 18.3888 aarch64 (N1) | close-exponents | 11.5256 | 5.93518 armhf (N1) | subnormal | 11.6662 | 7.75977 armhf (N1) | normal | 69.2759 | 31.623 armhf (N1) | close-exponents | 13.6472 | 15.6689 I also checked against H.J proposal to use fprem on x86_64 [2] and against recent suggestion on libc-alpha [3], and on both cases this newer implementation shows better performance. Changes from v3: * New tests cover more floating points types. Changes from v2: * Bug fixes and improve testsuite. Changes from v1: * Remove SVID error handling wrapper. * Extend testing for subnormal with different signs. * Code cleanup. Adhemerval Zanella (5): benchtests: Add fmod benchmark benchtests: Add fmodf benchmark math: Improve fmod math: Improve fmodf math: Remove the error handling wrapper from fmod and fmodf benchtests/Makefile | 2 + benchtests/fmod-inputs | 2182 +++++++++++++++++ benchtests/fmodf-inputs | 2182 +++++++++++++++++ math/Versions | 4 + math/libm-test-fmod.inc | 18 + math/w_fmod_compat.c | 13 +- math/w_fmodf_compat.c | 6 +- sysdeps/i386/fpu/w_fmod_compat.c | 14 + sysdeps/i386/fpu/w_fmodf_compat.c | 14 + sysdeps/ieee754/dbl-64/e_fmod.c | 248 +- sysdeps/ieee754/dbl-64/math_config.h | 70 + sysdeps/ieee754/dbl-64/math_err.c | 6 + sysdeps/ieee754/dbl-64/w_fmod.c | 1 + sysdeps/ieee754/flt-32/e_fmodf.c | 244 +- sysdeps/ieee754/flt-32/math_config.h | 48 + sysdeps/ieee754/flt-32/math_errf.c | 6 + sysdeps/ieee754/flt-32/w_fmodf.c | 1 + sysdeps/m68k/m680x0/fpu/w_fmod_compat.c | 14 + sysdeps/m68k/m680x0/fpu/w_fmodf_compat.c | 14 + sysdeps/unix/sysv/linux/aarch64/libm.abilist | 2 + sysdeps/unix/sysv/linux/alpha/libm.abilist | 2 + sysdeps/unix/sysv/linux/arm/be/libm.abilist | 2 + sysdeps/unix/sysv/linux/arm/le/libm.abilist | 2 + sysdeps/unix/sysv/linux/hppa/libm.abilist | 2 + .../sysv/linux/m68k/coldfire/libm.abilist | 2 + .../sysv/linux/microblaze/be/libm.abilist | 2 + .../sysv/linux/microblaze/le/libm.abilist | 2 + .../unix/sysv/linux/mips/mips32/libm.abilist | 2 + .../unix/sysv/linux/mips/mips64/libm.abilist | 2 + sysdeps/unix/sysv/linux/nios2/libm.abilist | 2 + .../linux/powerpc/powerpc32/fpu/libm.abilist | 2 + .../powerpc/powerpc32/nofpu/libm.abilist | 2 + .../linux/powerpc/powerpc64/be/libm.abilist | 2 + .../linux/powerpc/powerpc64/le/libm.abilist | 2 + .../unix/sysv/linux/s390/s390-32/libm.abilist | 2 + .../unix/sysv/linux/s390/s390-64/libm.abilist | 2 + sysdeps/unix/sysv/linux/sh/be/libm.abilist | 2 + sysdeps/unix/sysv/linux/sh/le/libm.abilist | 2 + .../sysv/linux/sparc/sparc32/libm.abilist | 2 + .../sysv/linux/sparc/sparc64/libm.abilist | 2 + .../unix/sysv/linux/x86_64/64/libm.abilist | 2 + .../unix/sysv/linux/x86_64/x32/libm.abilist | 2 + 42 files changed, 4936 insertions(+), 197 deletions(-) create mode 100644 benchtests/fmod-inputs create mode 100644 benchtests/fmodf-inputs create mode 100644 sysdeps/i386/fpu/w_fmod_compat.c create mode 100644 sysdeps/i386/fpu/w_fmodf_compat.c create mode 100644 sysdeps/ieee754/dbl-64/w_fmod.c create mode 100644 sysdeps/ieee754/flt-32/w_fmodf.c create mode 100644 sysdeps/m68k/m680x0/fpu/w_fmod_compat.c create mode 100644 sysdeps/m68k/m680x0/fpu/w_fmodf_compat.c