From patchwork Tue Feb 28 17:23:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella X-Patchwork-Id: 55536 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EC0523858024 for ; Tue, 28 Feb 2023 17:24:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EC0523858024 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1677605071; bh=7egJnoulQ+GAwv6B6LWwKZOF40E1tffrl9JlSd7W8SI=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=AReLi+7G0ewG6l7EiZPVNSq+udIWwJYeWdtou6ZQPG6bHzF2R4mcUFd8SQ5VHca84 7NlVBZBm81IKgXYOw4P1IgbXz1C+j1ba8Ekw0cSLstymgneXqRl99S8E0c7y0DXPAi WR+IwRLEkqQgsb5VuX3tS2B/wlh8ZxzeD4P73yfE= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-ot1-x332.google.com (mail-ot1-x332.google.com [IPv6:2607:f8b0:4864:20::332]) by sourceware.org (Postfix) with ESMTPS id B44543858D33 for ; Tue, 28 Feb 2023 17:24:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B44543858D33 Received: by mail-ot1-x332.google.com with SMTP id 32-20020a9d0323000000b0069426a71d79so402187otv.10 for ; Tue, 28 Feb 2023 09:24:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677605044; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7egJnoulQ+GAwv6B6LWwKZOF40E1tffrl9JlSd7W8SI=; b=JD/+iEPriQPwm8feCC9bqRp5mpIyX9OtSqOoEOuF99BdOYxm3xsJvh2r7e8+FlgfQk WAx0xJzgBSIwmsCY90hXcWOTZw8xNsMYOXymFCC/kq9IbPEsBVxoDX8nhWwyl2gGrISt I5IzLCudsCFiT+g97Ab6J5P53GgDnUZk2iAwGozIdwy3HF48pzRapk9I7tbqwJ9Flt7A hUDrQIpFttiCholqF+4RjrKclK1d+FDB7ZvKWRFWlU5A4NGyAIJkIX8+DpYlrQNvmFH3 +vFZYIyJso7rXLkbWwL3FCb8s4j0I93YYpnmD4hmtBDBRdQ8cgc0G2TqFz6dIuGXqDFb ghww== X-Gm-Message-State: AO0yUKV6PQEzKTHWoZL9sAn73lS3VUIcegF2EujvyzSTSbiLFFMppDa1 UL96bsawRAO+ybSp7hsHTlrdD7+/r8B5T2TYjqo= X-Google-Smtp-Source: AK7set+ToN92oFWrlAuSLWNUpjCkoJi3BqVDqULAMKwb0EEx1nRpKIzcb9q7Qj5hE6ryK8WyFd6W2Q== X-Received: by 2002:a05:6830:232a:b0:68b:e109:c40f with SMTP id q10-20020a056830232a00b0068be109c40fmr1629158otg.26.1677605044463; Tue, 28 Feb 2023 09:24:04 -0800 (PST) Received: from mandiga.. ([2804:1b3:a7c3:d849:7299:419:6fb3:7a8]) by smtp.gmail.com with ESMTPSA id e7-20020a05683013c700b00684152e9ff2sm3925220otq.0.2023.02.28.09.24.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 09:24:03 -0800 (PST) To: libc-alpha@sourceware.org, Richard Henderson Subject: [PATCH 0/3] Clean strncmp implementations Date: Tue, 28 Feb 2023 14:23:57 -0300 Message-Id: <20230228172400.2763397-1-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" While working to fix the crypto badsalttest failure (675bdaeeca7) I noted that some implementation implements similar strategies used by the generic implementation. While alpha implements some unaligned input optimization, powerpc just optimizes for aligned inputs. Now that generic implementation allows both to use arch-specific string compare functions (alpha and power7), it allows to just remove this arch-specific code. Adhemerval Zanella (3): powerpc: Remove strncmp variants powerpc: Remove powerpc64 strncmp variants alpha: Remove strncmp optimization sysdeps/alpha/strncmp.S | 276 ------------------ .../powerpc32/power4/multiarch/Makefile | 2 +- .../power4/multiarch/ifunc-impl-list.c | 7 - .../power4/multiarch/strncmp-power7.S | 38 --- .../power4/multiarch/strncmp-ppc32.S | 40 --- .../powerpc32/power4/multiarch/strncmp.c | 39 --- sysdeps/powerpc/powerpc32/power4/strncmp.S | 196 ------------- sysdeps/powerpc/powerpc32/power7/strncmp.S | 199 ------------- sysdeps/powerpc/powerpc32/strncmp.S | 181 ------------ sysdeps/powerpc/powerpc64/multiarch/Makefile | 2 +- .../powerpc64/multiarch/ifunc-impl-list.c | 2 - .../powerpc64/multiarch/strncmp-power7.S | 23 -- .../powerpc64/multiarch/strncmp-ppc64.S | 26 -- .../powerpc64/multiarch/strncmp-ppc64.c | 7 + sysdeps/powerpc/powerpc64/multiarch/strncmp.c | 5 +- sysdeps/powerpc/powerpc64/power7/strncmp.S | 228 --------------- sysdeps/powerpc/powerpc64/strncmp.S | 210 ------------- 17 files changed, 10 insertions(+), 1471 deletions(-) delete mode 100644 sysdeps/alpha/strncmp.S delete mode 100644 sysdeps/powerpc/powerpc32/power4/multiarch/strncmp-power7.S delete mode 100644 sysdeps/powerpc/powerpc32/power4/multiarch/strncmp-ppc32.S delete mode 100644 sysdeps/powerpc/powerpc32/power4/multiarch/strncmp.c delete mode 100644 sysdeps/powerpc/powerpc32/power4/strncmp.S delete mode 100644 sysdeps/powerpc/powerpc32/power7/strncmp.S delete mode 100644 sysdeps/powerpc/powerpc32/strncmp.S delete mode 100644 sysdeps/powerpc/powerpc64/multiarch/strncmp-power7.S delete mode 100644 sysdeps/powerpc/powerpc64/multiarch/strncmp-ppc64.S create mode 100644 sysdeps/powerpc/powerpc64/multiarch/strncmp-ppc64.c delete mode 100644 sysdeps/powerpc/powerpc64/power7/strncmp.S delete mode 100644 sysdeps/powerpc/powerpc64/strncmp.S