From patchwork Wed Jan 11 20:45:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 55404 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 49A6138493EB for ; Wed, 11 Jan 2023 20:46:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 49A6138493EB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1673469993; bh=K/eHviFXr27WQZ2XOXHpSU+1/mX7OZUZ7K6Pf96lZFg=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=lGD1TWWVdXBAtloEepaK/BSXD1y8UgIx8hsz5IgCS0SqD7rJmhhjK6Obf9DMkCIuQ 7Dde/bZlMLIc1g4SwaQzO1pzqTbpomfvbsxJz2AZWHfYyNoqFOxBbm18WqjA43Cgt9 OtckzcZ8qD0X3PopG9B6uqh0h3laV4vOaVEAGMxA= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-oa1-x2f.google.com (mail-oa1-x2f.google.com [IPv6:2001:4860:4864:20::2f]) by sourceware.org (Postfix) with ESMTPS id 2AB5B3858C83 for ; Wed, 11 Jan 2023 20:46:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2AB5B3858C83 Received: by mail-oa1-x2f.google.com with SMTP id 586e51a60fabf-15085b8a2f7so16838787fac.2 for ; Wed, 11 Jan 2023 12:46:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K/eHviFXr27WQZ2XOXHpSU+1/mX7OZUZ7K6Pf96lZFg=; b=ZdqbTNB9vuJailefUVuQ7k1Nel1KST+TLcfojBMlbuUy2XeMgOvhEes3+QTP6Itppe ktZzp8lVf1a0e8EaSX1C+nSe5SLHTx5w5/2qWlLNV1m7Vt120+DNGzgv2mKsnCzIhf/A 1L8xB2vU3i0bwjpBonnHVWSoy7UvLkqKZ9LBg12bG5d/IV2XFBt2U89BTU1o8KUzb/TB hBGLdpNQeX3IyK7fqZIFlkHAgR1FGr90Eqv0lwddoj1Ar6jsAbWmtn3x5IZDRbuTeY89 uR6Z0ZwZxx0ckH414A74j3wubebC8CMT68B0NsEz/QiO/zjTvo1q4eXPdsQrcrq9X4uU +pxw== X-Gm-Message-State: AFqh2krHjeuq1t+wLJnhUngalJHtSJr+/6V8/blXF6UIkzzNLFrWyUMf jJKJvzH2U9nmrd8/Rxwvepqf7w2gyuGAQDVAghg= X-Google-Smtp-Source: AMrXdXtb1WyNEjzZWsLgGrvrTYSOYNG7TJU1AqMShWBm5CovCAhlDRgmyaXRwrg7U3VIayD8EemhJg== X-Received: by 2002:a05:6870:450c:b0:150:b945:3a2e with SMTP id e12-20020a056870450c00b00150b9453a2emr17226917oao.32.1673469962707; Wed, 11 Jan 2023 12:46:02 -0800 (PST) Received: from mandiga.. ([2804:1b3:a7c0:a93a:a504:f3f6:dd7b:801]) by smtp.gmail.com with ESMTPSA id kw18-20020a056870ac1200b0014c8b5d54b2sm7990274oab.20.2023.01.11.12.46.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 12:46:02 -0800 (PST) To: libc-alpha@sourceware.org, Noah Goldstein , Richard Henderson Subject: [PATCH v7 00/17] Improve generic string routines Date: Wed, 11 Jan 2023 17:45:41 -0300 Message-Id: <20230111204558.2402155-1-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Netto Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" It is done by: 1. parametrizing the internal routines (for instance the find zero in a word) so each architecture can reimplement without the need to reimplement the whole routine. 2. vectorizing more string implementations (for instance strcpy and strcmp). 3. Change some implementations to use already possible optimized ones (strnlen and strchr). It makes new ports to focus on only provide optimized implementation of a hardful symbols (for instance memchr) and make its improvement to be used in a larger set of routines. I checked on x86_64-linux-gnu, i686-linux-gnu, powerpc-linux-gnu, and powerpc64-linux-gnu by removing the arch-specific assembly implementation and disabling multiarch (it covers both LE and BE for 64 and 32 bits). I also checked the string routines on alpha, hppa, and sh. Changes since v6: * Add find_t to handle alpha way of comapring bytes (which returns a bit-mask instead of byte-mask). * Fixed alpha string-fzi.h and added string-fza.h. * Renamed check_mask to shift_find. Changes since v5: * Replace 'inline' with '__always_inline' macros. * Replace strchr implementation with a simpler one that call strchrnul. * Add strchrnul suggested changes. * Add memchr suggested changes. * Added check_mask on string-maskoff.h. * Rebase and update Copyright years. Changes since v4: * Removed __clz and __ctz in favor of count_leading_zero and count_trailing_zeros from longlong.h. * Use repeat_bytes more often. * Added a comment on strcmp final_cmp on why index_first_zero_ne can not be used. Changes since v3: * Rebased against master. * Dropped strcpy optimization. * Refactor strcmp implementation. * Some minor changes in comments. Changes since v2: * Move string-fz{a,b,i} to its own patch. * Add a inline implementation for __builtin_c{l,t}z to avoid using compiler provided symbols. * Add a new header, string-maskoff.h, to handle unaligned accesses on some implementation. * Fixed strcmp on LE machines. * Added a unaligned strcpy variant for architecture that define _STRING_ARCH_unaligned. * Add SH string-fzb.h (which uses cmp/str instruction to find a zero in word). Changes since v1: * Marked ChangeLog entries with [BZ #5806], as appropriate. * Reorganized the headers, so that armv6t2 and power6 need override as little as possible to use their (integer) zero detection insns. * Hopefully fixed all of the coding style issues. * Adjusted the memrchr algorithm as discussed. * Replaced the #ifdef STRRCHR etc that are used by the multiarch * files. * Tested on i386, i686, x86_64 (verified this is unused), ppc64, ppc64le --with-cpu=power8 (to use power6 in multiarch), armv7, aarch64, alpha (qemu) and hppa (qemu). Adhemerval Zanella Netto (11): Parameterize op_t from memcopy.h Add string-maskoff.h generic header Add string vectorized find and detection functions string: Improve generic strlen string: Improve generic strnlen string: Improve generic strchr string: Improve generic strchrnul string: Improve generic strcmp string: Improve generic memchr string: Improve generic memrchr sh: Add string-fzb.h Richard Henderson (6): Parameterize OP_T_THRES from memcopy.h hppa: Add memcopy.h hppa: Add string-fzb.h and string-fzi.h alpha: Add string-fzb.h and string-fzi.h arm: Add string-fza.h powerpc: Add string-fza.h string/memchr.c | 178 +++++----------- string/memcmp.c | 4 - string/memrchr.c | 190 +++--------------- string/strchr.c | 159 +-------------- string/strchrnul.c | 153 ++------------ string/strcmp.c | 119 +++++++++-- string/strlen.c | 90 ++------- string/strnlen.c | 137 +------------ sysdeps/alpha/string-fza.h | 55 +++++ sysdeps/alpha/string-fzb.h | 52 +++++ sysdeps/alpha/string-fzi.h | 113 +++++++++++ sysdeps/arm/armv6t2/string-fza.h | 70 +++++++ sysdeps/generic/memcopy.h | 10 +- sysdeps/generic/string-extbyte.h | 37 ++++ sysdeps/generic/string-fza.h | 116 +++++++++++ sysdeps/generic/string-fzb.h | 49 +++++ sysdeps/generic/string-fzi.h | 135 +++++++++++++ sysdeps/generic/string-maskoff.h | 73 +++++++ sysdeps/generic/string-opthr.h | 25 +++ sysdeps/generic/string-optype.h | 24 +++ sysdeps/hppa/memcopy.h | 42 ++++ sysdeps/hppa/string-fzb.h | 70 +++++++ sysdeps/hppa/string-fzi.h | 140 +++++++++++++ sysdeps/i386/i686/multiarch/strnlen-c.c | 14 +- sysdeps/i386/memcopy.h | 3 - sysdeps/i386/string-opthr.h | 25 +++ sysdeps/m68k/memcopy.h | 3 - sysdeps/powerpc/powerpc32/power4/memcopy.h | 5 - .../powerpc32/power4/multiarch/memchr-ppc32.c | 14 +- .../power4/multiarch/strchrnul-ppc32.c | 4 - .../power4/multiarch/strnlen-ppc32.c | 14 +- .../powerpc64/multiarch/memchr-ppc64.c | 9 +- sysdeps/powerpc/string-fza.h | 70 +++++++ sysdeps/s390/strchr-c.c | 11 +- sysdeps/s390/strchrnul-c.c | 2 - sysdeps/s390/strlen-c.c | 10 +- sysdeps/s390/strnlen-c.c | 14 +- sysdeps/sh/string-fzb.h | 54 +++++ sysdeps/x86_64/x32/string-optype.h | 24 +++ 39 files changed, 1460 insertions(+), 857 deletions(-) create mode 100644 sysdeps/alpha/string-fza.h create mode 100644 sysdeps/alpha/string-fzb.h create mode 100644 sysdeps/alpha/string-fzi.h create mode 100644 sysdeps/arm/armv6t2/string-fza.h create mode 100644 sysdeps/generic/string-extbyte.h create mode 100644 sysdeps/generic/string-fza.h create mode 100644 sysdeps/generic/string-fzb.h create mode 100644 sysdeps/generic/string-fzi.h create mode 100644 sysdeps/generic/string-maskoff.h create mode 100644 sysdeps/generic/string-opthr.h create mode 100644 sysdeps/generic/string-optype.h create mode 100644 sysdeps/hppa/memcopy.h create mode 100644 sysdeps/hppa/string-fzb.h create mode 100644 sysdeps/hppa/string-fzi.h create mode 100644 sysdeps/i386/string-opthr.h create mode 100644 sysdeps/powerpc/string-fza.h create mode 100644 sysdeps/sh/string-fzb.h create mode 100644 sysdeps/x86_64/x32/string-optype.h