[0/3] htl: move __pthtread_total, ___pthread_self, pthread_self

  With this patch i boot up a hurd system with flavio scripts.

Guy-Fleury Iteriteka (3):
  htl: move __pthtread_total into libc
  htl: move __pthread_self into libc.
  htl: move pthread_self into libc

 htl/Makefile                              |  3 +--
 htl/Versions                              | 15 ++++++++++++---
 htl/forward.c                             |  4 ----
 htl/pt-create.c                           |  6 ------
 htl/pt-initialize.c                       |  1 -
 htl/pt-internal.h                         |  2 ++
 htl/pt-nthreads.c                         | 23 +++++++++++++++++++++++
 htl/pt-self.c                             |  8 ++++++--
 sysdeps/htl/pthread-functions.h           |  2 --
 sysdeps/mach/hurd/htl/pt-pthread_self.c   | 22 ++++++++++++++++++++++
 sysdeps/mach/hurd/htl/pt-sysdep.c         |  2 --
 sysdeps/mach/hurd/htl/pt-sysdep.h         |  3 +++
 sysdeps/mach/hurd/i386/libc.abilist       |  2 ++
 sysdeps/mach/hurd/i386/libpthread.abilist |  2 --
 14 files changed, 71 insertions(+), 24 deletions(-)
 create mode 100644 htl/pt-nthreads.c
 create mode 100644 sysdeps/mach/hurd/htl/pt-pthread_self.c
  

> With this patch i boot up a hurd system with flavio scripts.

Can we get a link to these scripts, please?  So we know why they care
about these symbols being in libc.

zw
  

Hello,

Zack Weinberg via Libc-alpha, le mar. 03 janv. 2023 12:22:20 -0500, a ecrit:
> > With this patch i boot up a hurd system with flavio scripts.
> 
> Can we get a link to these scripts, please?  So we know why they care
> about these symbols being in libc.

He just means that he was able to check the change with a Hurd system
built by flavio scripts. Those scripts work fine without the change, the
change is meant to move pthread symbols from libpthread.so to libc.so,
like was done for NPTL.

Samuel
  

On January 3, 2023 7:22:20 PM GMT+02:00, Zack Weinberg <zack@owlfolio.org> wrote:
>
>> With this patch i boot up a hurd system with flavio scripts.
>
>Can we get a link to these scripts, please?  So we know why they care
>about these symbols being in libc.

https://github.com/flavioc/cross-hurd

We are trying to move htl(hurd pthread library) like it was done for linux nptl.

>
>zw
  

Hello,

Apart from the symbols visibility, that looks good to me, thanks!

We're however in glibc slushy ABI freeze period, I guess we should
refrain from including this patch for 2.37?

The release is expected on february 1st, in the meanwhile you can work
on moving the other symbols. Ideally we'll have moved all the symbols by
2.38 :)

Samuel

Guy-Fleury Iteriteka via Libc-alpha, le mar. 03 janv. 2023 12:45:12 +0200, a ecrit:
> With this patch i boot up a hurd system with flavio scripts.
> 
> Guy-Fleury Iteriteka (3):
>   htl: move __pthtread_total into libc
>   htl: move __pthread_self into libc.
>   htl: move pthread_self into libc
> 
>  htl/Makefile                              |  3 +--
>  htl/Versions                              | 15 ++++++++++++---
>  htl/forward.c                             |  4 ----
>  htl/pt-create.c                           |  6 ------
>  htl/pt-initialize.c                       |  1 -
>  htl/pt-internal.h                         |  2 ++
>  htl/pt-nthreads.c                         | 23 +++++++++++++++++++++++
>  htl/pt-self.c                             |  8 ++++++--
>  sysdeps/htl/pthread-functions.h           |  2 --
>  sysdeps/mach/hurd/htl/pt-pthread_self.c   | 22 ++++++++++++++++++++++
>  sysdeps/mach/hurd/htl/pt-sysdep.c         |  2 --
>  sysdeps/mach/hurd/htl/pt-sysdep.h         |  3 +++
>  sysdeps/mach/hurd/i386/libc.abilist       |  2 ++
>  sysdeps/mach/hurd/i386/libpthread.abilist |  2 --
>  14 files changed, 71 insertions(+), 24 deletions(-)
>  create mode 100644 htl/pt-nthreads.c
>  create mode 100644 sysdeps/mach/hurd/htl/pt-pthread_self.c
> 
> -- 
> 2.38.1
  

3 janvier 2023 à 23:50 "Samuel Thibault" <samuel.thibault@gnu.org> a écrit:

hello,

> 
> Hello,
> 
> Apart from the symbols visibility, that looks good to me, thanks!
> 
> We're however in glibc slushy ABI freeze period, I guess we should
> refrain from including this patch for 2.37?
>
No problem, i send a second version for review. 

> The release is expected on february 1st, in the meanwhile you can work
> on moving the other symbols. Ideally we'll have moved all the symbols by
> 2.38 :)
>
I will try to move what i can  
> Samuel
> 
> Guy-Fleury Iteriteka via Libc-alpha, le mar. 03 janv. 2023 12:45:12 +0200, a ecrit:
> 
> > 
> > With this patch i boot up a hurd system with flavio scripts.
> >  
> >  Guy-Fleury Iteriteka (3):
> >  htl: move __pthtread_total into libc
> >  htl: move __pthread_self into libc.
> >  htl: move pthread_self into libc
> >  
> >  htl/Makefile | 3 +--
> >  htl/Versions | 15 ++++++++++++---
> >  htl/forward.c | 4 ----
> >  htl/pt-create.c | 6 ------
> >  htl/pt-initialize.c | 1 -
> >  htl/pt-internal.h | 2 ++
> >  htl/pt-nthreads.c | 23 +++++++++++++++++++++++
> >  htl/pt-self.c | 8 ++++++--
> >  sysdeps/htl/pthread-functions.h | 2 --
> >  sysdeps/mach/hurd/htl/pt-pthread_self.c | 22 ++++++++++++++++++++++
> >  sysdeps/mach/hurd/htl/pt-sysdep.c | 2 --
> >  sysdeps/mach/hurd/htl/pt-sysdep.h | 3 +++
> >  sysdeps/mach/hurd/i386/libc.abilist | 2 ++
> >  sysdeps/mach/hurd/i386/libpthread.abilist | 2 --
> >  14 files changed, 71 insertions(+), 24 deletions(-)
> >  create mode 100644 htl/pt-nthreads.c
> >  create mode 100644 sysdeps/mach/hurd/htl/pt-pthread_self.c
> >  
> >  -- 
> >  2.38.1
> >
>
  

On Tue, Jan 3, 2023, at 1:28 PM, Samuel Thibault wrote:
> Zack Weinberg via Libc-alpha, le mar. 03 janv. 2023 12:22:20 -0500, a ecrit:
>> > With this patch i boot up a hurd system with flavio scripts.
>> 
>> Can we get a link to these scripts, please?  So we know why they care
>> about these symbols being in libc.
>
> He just means that he was able to check the change with a Hurd system
> built by flavio scripts. Those scripts work fine without the change, the
> change is meant to move pthread symbols from libpthread.so to libc.so,
> like was done for NPTL.

Oh, I see.  Thanks for clarifying.

zw