From patchwork Sat Feb 5 02:56:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carlos O'Donell X-Patchwork-Id: 50821 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 40CCE385840D for ; Sat, 5 Feb 2022 02:57:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 40CCE385840D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1644029848; bh=dHW7ORZ/m+NKLi6vSUue3mNoC0RJJHpqcCjxtARywrw=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=he6GVEf+Gh0rd7St+ezkGBflEG3iGnDD2uY4CO6B4B8q6QDG+V5PRXt+J0tz06d2+ 56EOBE799rdxfLzz3fxwFfnm6Ug9L/6eF100bAaftgqMSEehissci6nfxyrGhoocoC tD3FS5wtF9g0lCMu/3ALR///2XWKK7arQfV7V1Z4= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2F79C3858D20 for ; Sat, 5 Feb 2022 02:57:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2F79C3858D20 Received: from mail-il1-f200.google.com (mail-il1-f200.google.com [209.85.166.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-488-eeI23tYuMlyvyadfvLukoA-1; Fri, 04 Feb 2022 21:57:04 -0500 X-MC-Unique: eeI23tYuMlyvyadfvLukoA-1 Received: by mail-il1-f200.google.com with SMTP id t15-20020a92c90f000000b002ba55086cc6so5312195ilp.23 for ; Fri, 04 Feb 2022 18:57:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dHW7ORZ/m+NKLi6vSUue3mNoC0RJJHpqcCjxtARywrw=; b=yD4fualGOA119XI/oBSb1PyHs9ryjhDhs96dfuVjZQAIQDBT8Xzlda1q+kilw67z/6 1u4fphU4DxajneLTXJieYW3emmglgRw2dg5oXJpUYsRiDfVhbODNXgbJmh0fhZFGi82z WVYXiPFsOjq/PAgHlCX1hvbSv2YJ7GbiPdKLtCSgRBeHrDg2V/MPKdkFXg/syWYL/ZGD kjJE3FqhaKtNFXH98bOQV/uagAdivU38OVp9HTAk80X9j6aXIxZRoV4Sxn+iSHH5PzFJ QL3D67U5k/bXmiAk+q636Kf047ADosa3H/gMK6867Hvhvmf7ASxmiPXT48Q/Ge1zPUtG bpvA== X-Gm-Message-State: AOAM530zzZUQrrAgCOy8WHfJs2UJS6Gtq2NqmSGjphoXx9XpfmFgX/p1 9tFdVF65bA1BfcmQ/XLF5aadAMXf0RwS20psQtj4z2yUWDhhD6P5mUYeI18AkIF2Q2FdN+SrU5B KUbrKSEMymCpS0DlpbENncte+n1tLmzQhy6B1ZDezD6DT7HrWE9/tklnuv6ZWPWhBvTLjBg== X-Received: by 2002:a02:6023:: with SMTP id i35mr993071jac.173.1644029823813; Fri, 04 Feb 2022 18:57:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJxrvH1ty5RgcImibI2NOxsX5dzvBRKie5mQYF2kRh6S5RU6mw3aiF/9sxA/ZL/z5FjDCjsHfA== X-Received: by 2002:a02:6023:: with SMTP id i35mr993063jac.173.1644029823563; Fri, 04 Feb 2022 18:57:03 -0800 (PST) Received: from athas.redhat.com (135-23-175-80.cpe.pppoe.ca. [135.23.175.80]) by smtp.gmail.com with ESMTPSA id g1sm1997577iob.34.2022.02.04.18.57.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Feb 2022 18:57:02 -0800 (PST) To: libc-alpha@sourceware.org, fweimer@redhat.com Subject: [PATCH 0/2] Improve LC_MONETARY handling. Date: Fri, 4 Feb 2022 21:56:58 -0500 Message-Id: <20220205025700.3728228-1-carlos@redhat.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Carlos O'Donell via Libc-alpha From: Carlos O'Donell Reply-To: Carlos O'Donell Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" In glibc 2.35 we released C.UTF-8, but if you try to compile the locale without '-c' you get the following error: localedef -i C -f UTF-8 C.UTF-8 [error] LC_MONETARY: value for field `mon_decimal_point' must not be an empty string [error] no output file produced because errors were issued The first patch in the series fixes bug 28845 and cleans up LC_MONETARY handling in ld-monetary.c (monetary_finish) for default values and generated errors. In general we downgrade the errors and make them warnings. Lastly, to prevent this from happening again we remove the '-c' from glibc localedef uses since we do not want to force output generation and we should always have locales that compile cleanly. Where locales are not clean we should implement specific warning disabling e.g. --no-warnings=ascii for SHIFT_JIS and SHIFT_JISX0213 (non-ascii locales). Any future locale warnings should fail during locale compilation (install or testing). Carlos O'Donell (2): localedef: Update LC_MONETARY handling (Bug 28845) localedata: Do not generate output if warnings were present. locale/programs/ld-monetary.c | 172 +++++++++++++++++++++++++++------- localedata/Makefile | 3 +- 2 files changed, 137 insertions(+), 38 deletions(-)