From patchwork Tue Feb 1 14:46:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella X-Patchwork-Id: 50623 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 661A93851401 for ; Tue, 1 Feb 2022 14:47:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 661A93851401 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1643726825; bh=vnFmztnDzQFtImDCcMAFhuPxIoW9VcudM5jUw17d47A=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=O6GqcAY7VJ2dTAimzXO4kmsy+m7iMnNTI6QeQzPmFpqdBf6C+TYv4E7BWRN+5Rvbp NezyXYZ6DdodhDaVjNbJgJ4vqAkF9q96gS4Go2fXAGo4E8LsdY1yCDnw3MfrunnHkL Etuy4yLe7pj8aQpJq2BqLOnJmD9IgJWVXnYaSkFk= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-ot1-x32b.google.com (mail-ot1-x32b.google.com [IPv6:2607:f8b0:4864:20::32b]) by sourceware.org (Postfix) with ESMTPS id 593B33858033 for ; Tue, 1 Feb 2022 14:46:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 593B33858033 Received: by mail-ot1-x32b.google.com with SMTP id j38-20020a9d1926000000b0059fa6de6c71so16419210ota.10 for ; Tue, 01 Feb 2022 06:46:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vnFmztnDzQFtImDCcMAFhuPxIoW9VcudM5jUw17d47A=; b=G1zVEt1Kv2CN1w74IQ3NXfopoU2/5nhaVO1QZkXEgUSBl/gam6+5dvKvq0YOr7gcIY vdHskNwVDUAYu0gyw3Gtl1lk1vuml5StLfoMBMeuBvJ/ohB2NnQua5AThv8hA+yEZHP9 QaZi2c02CL5TZ7vf5wDiNIKZ4UJI7KX6mpXSsKbWXyfbQgvbd9tIpKAdreGJ0UpGLYLZ qjzMnf7QaUUYYwRd+pWJEpIDCEwLcWeoh5Oovb/tDLxtaVkr+srZ6SXKQ7MSXiV8tR1H oGULvzS+IRUfrfBbIf9MoUOmpn7d3Rvk5U+wAE4bYNrQVaLVK1gHT1AwPaAU2N42c/Vq dARw== X-Gm-Message-State: AOAM531q/kUsoHj7VT66z1Xt1dqVR7Hx6HX2cdslOyenqnetOrcDpEOT e88f9lQyatJqZG9C9P4boafMPFHuxPtqcQ== X-Google-Smtp-Source: ABdhPJx3W2rM+6H1rdxzUbe8TvxjeA0V8OpVCew4h8ZVUMnoKa3/s7/EYoEePFE46B+AfkWN4+WqiQ== X-Received: by 2002:a9d:341:: with SMTP id 59mr14307824otv.286.1643726801451; Tue, 01 Feb 2022 06:46:41 -0800 (PST) Received: from birita.. ([2804:431:c7ca:709a:f3cb:a92a:e1ce:d27d]) by smtp.gmail.com with ESMTPSA id q14sm17480102otg.77.2022.02.01.06.46.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Feb 2022 06:46:41 -0800 (PST) To: libc-alpha@sourceware.org, jma14 , Carlos O'Donell Subject: [PATCH v13 0/4] Multiple rtld-audit fixes Date: Tue, 1 Feb 2022 11:46:32 -0300 Message-Id: <20220201144636.2129852-1-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Reply-To: Adhemerval Zanella Cc: John Mellor-Crummey Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" This patches fixes some of remaining issues brought by John Mellor-Crummey [1] while trying to use it along with the HPCToolkit. This should cover all the issues listed as 'Tier 1' [2] (the aarch64 SVE requires additional work, so it is postpone to 2.36) and also most of the 'Tier2' issue (BZ#28096 inclusive) which prevents the use of some glibc function that uses TLS internally on the audit module. I have checked the patches on x86_64, i686, aarch64, armv7, powerpc64, powerpc64le, and powerpc. [1] https://sourceware.org/pipermail/libc-alpha/2021-June/127636.html [2] https://docs.google.com/document/d/1dVaDBdzySecxQqD6hLLzDrEF18M1UtjDna9gL5BWWI0/edit# [3] https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/azanella/ld-audit-fixes Changes from v12: - Fixed typos and added comments. Changes from v11: - Fixed tst-audit23. Changes from v10: - Removed l_auditing usage on initial-exec TLS access fix. - Fixed aarch64 comments about the _dl_runtime_profile stack layout. - Added some more argumet checking on some tests. - Fixed copyright years. Changes from v9: - Fixed aarch64 comments about the _dl_runtime_profile stack layout. - Rebased against master. Changes from v8: - Improved la_activity test coverage. - Fixed BZ#28096 regression. Changes from v7: - Added la_activity tests during application exit. - Refactor _dl_allocate_tls_init to not initialize static TLS. - Changed sotruss to warn instead of error for bind-now. - Added NEWS and changed commit message for aarch64. Changes from v6: - Dropped SVE, main application on main_map l_name, and Run constructors if executable has a soname of a dependency patches. - Bumped LAV_VERSION to 2 on la_symbind bind-now support. - Added extension pointer on aarch64 fix. - Moved the refactor patch at the start of the set. - Changed _dl_audit_objsearch interface. Changes from v5: - Fixed build with --enable-profiling=yes. - Moved la_activity (LA_ACT_ADD) *after* _dl_add_to_namespace_list() for BZ#28062 fix. - Fixed powerpc64 ELFv1 OPD toc setup for bind-now. - Fixed testsuite issues for ia64. - Removed LA_SYMB_BINDNOW now that LA_SYMB_NOPLTENTER and LA_SYMB_NOPLTEXIT is passed for bind-now. Changes from v4: - Added a fix for constructors if executable has a soname of a dependency - Rebased against master. Changes from v3 - Added a aarch64 SVE RFC patch. - Fixed an issue with bind-now fix on powerpc64 ELFv1. - Rebased against master. Changes from v2 - Refactored rtld-audit code to move common come to dl-audit.c. - Issue audit la_objopen() for vDSO. - Isseu la_activity during application exit. - Issue la_symbind() for bind-now (BZ #23734). - Fix runtime linker auditing on aarch64 (BZ #26643) Changes from v1 - Fixed -fstack-protector-all tst-auditmod17. - Simplify the _dl_call_libc_early_init call the 'Fix audit regression' patch. - Remove symbind check fr BZ#15333. - Added the BZ#28096 fix. Adhemerval Zanella (3): elf: Add la_activity during application exit elf: Fix initial-exec TLS access on audit modules (BZ #28096) elf: Issue la_symbind for bind-now (BZ #23734) Ben Woodard (1): elf: Fix runtime linker auditing on aarch64 (BZ #26643) NEWS | 8 ++ bits/link_lavcurrent.h | 2 +- elf/Makefile | 104 +++++++++++++- elf/dl-audit.c | 58 +++++--- elf/dl-fini.c | 8 ++ elf/dl-tls.c | 17 ++- elf/do-rel.h | 57 ++++++-- elf/rtld.c | 5 +- elf/sotruss-lib.c | 7 + elf/tst-audit21.c | 42 ++++++ elf/tst-audit23.c | 239 +++++++++++++++++++++++++++++++ elf/tst-audit23mod.c | 23 +++ elf/tst-audit24a.c | 36 +++++ elf/tst-audit24amod1.c | 31 ++++ elf/tst-audit24amod2.c | 25 ++++ elf/tst-audit24b.c | 37 +++++ elf/tst-audit24bmod1.c | 31 ++++ elf/tst-audit24bmod2.c | 23 +++ elf/tst-audit24c.c | 2 + elf/tst-audit24d.c | 36 +++++ elf/tst-audit24dmod1.c | 33 +++++ elf/tst-audit24dmod2.c | 28 ++++ elf/tst-audit24dmod3.c | 31 ++++ elf/tst-audit24dmod4.c | 25 ++++ elf/tst-audit25a.c | 129 +++++++++++++++++ elf/tst-audit25b.c | 128 +++++++++++++++++ elf/tst-audit25mod1.c | 30 ++++ elf/tst-audit25mod2.c | 30 ++++ elf/tst-audit25mod3.c | 22 +++ elf/tst-audit25mod4.c | 22 +++ elf/tst-auditmod21a.c | 80 +++++++++++ elf/tst-auditmod21b.c | 22 +++ elf/tst-auditmod23.c | 74 ++++++++++ elf/tst-auditmod24.h | 29 ++++ elf/tst-auditmod24a.c | 114 +++++++++++++++ elf/tst-auditmod24b.c | 104 ++++++++++++++ elf/tst-auditmod24c.c | 3 + elf/tst-auditmod24d.c | 120 ++++++++++++++++ elf/tst-auditmod25.c | 79 ++++++++++ nptl/allocatestack.c | 2 +- sysdeps/aarch64/Makefile | 20 +++ sysdeps/aarch64/bits/link.h | 26 ++-- sysdeps/aarch64/dl-audit-check.h | 28 ++++ sysdeps/aarch64/dl-link.sym | 6 +- sysdeps/aarch64/dl-trampoline.S | 81 +++++++---- sysdeps/aarch64/tst-audit26.c | 37 +++++ sysdeps/aarch64/tst-audit26mod.c | 33 +++++ sysdeps/aarch64/tst-audit26mod.h | 50 +++++++ sysdeps/aarch64/tst-audit27.c | 64 +++++++++ sysdeps/aarch64/tst-audit27mod.c | 95 ++++++++++++ sysdeps/aarch64/tst-audit27mod.h | 67 +++++++++ sysdeps/aarch64/tst-auditmod26.c | 103 +++++++++++++ sysdeps/aarch64/tst-auditmod27.c | 180 +++++++++++++++++++++++ sysdeps/generic/dl-audit-check.h | 23 +++ sysdeps/generic/dl-lookupcfg.h | 3 + sysdeps/generic/ldsodefs.h | 7 +- sysdeps/hppa/dl-lookupcfg.h | 3 + sysdeps/ia64/dl-lookupcfg.h | 3 + sysdeps/powerpc/dl-lookupcfg.h | 39 +++++ 59 files changed, 2678 insertions(+), 86 deletions(-) create mode 100644 elf/tst-audit21.c create mode 100644 elf/tst-audit23.c create mode 100644 elf/tst-audit23mod.c create mode 100644 elf/tst-audit24a.c create mode 100644 elf/tst-audit24amod1.c create mode 100644 elf/tst-audit24amod2.c create mode 100644 elf/tst-audit24b.c create mode 100644 elf/tst-audit24bmod1.c create mode 100644 elf/tst-audit24bmod2.c create mode 100644 elf/tst-audit24c.c create mode 100644 elf/tst-audit24d.c create mode 100644 elf/tst-audit24dmod1.c create mode 100644 elf/tst-audit24dmod2.c create mode 100644 elf/tst-audit24dmod3.c create mode 100644 elf/tst-audit24dmod4.c create mode 100644 elf/tst-audit25a.c create mode 100644 elf/tst-audit25b.c create mode 100644 elf/tst-audit25mod1.c create mode 100644 elf/tst-audit25mod2.c create mode 100644 elf/tst-audit25mod3.c create mode 100644 elf/tst-audit25mod4.c create mode 100644 elf/tst-auditmod21a.c create mode 100644 elf/tst-auditmod21b.c create mode 100644 elf/tst-auditmod23.c create mode 100644 elf/tst-auditmod24.h create mode 100644 elf/tst-auditmod24a.c create mode 100644 elf/tst-auditmod24b.c create mode 100644 elf/tst-auditmod24c.c create mode 100644 elf/tst-auditmod24d.c create mode 100644 elf/tst-auditmod25.c create mode 100644 sysdeps/aarch64/dl-audit-check.h create mode 100644 sysdeps/aarch64/tst-audit26.c create mode 100644 sysdeps/aarch64/tst-audit26mod.c create mode 100644 sysdeps/aarch64/tst-audit26mod.h create mode 100644 sysdeps/aarch64/tst-audit27.c create mode 100644 sysdeps/aarch64/tst-audit27mod.c create mode 100644 sysdeps/aarch64/tst-audit27mod.h create mode 100644 sysdeps/aarch64/tst-auditmod26.c create mode 100644 sysdeps/aarch64/tst-auditmod27.c create mode 100644 sysdeps/generic/dl-audit-check.h create mode 100644 sysdeps/powerpc/dl-lookupcfg.h