From patchwork Wed Dec 22 13:26:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 49177 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4A7183858426 for ; Wed, 22 Dec 2021 13:27:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4A7183858426 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1640179659; bh=w9bG/tV/rpPWERwWsNtN+rXlWw1ltNt1K2W328Gxvvw=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=tBoAek6n531SP1DuF+BoofCnjt1dWt0d3Qxo1ZGGtQeHtaxS8zqWeKGFuMHs9X/l/ vIeTniMoLHz3D/FEb5YMLw4oXZCLnoOXR8aQ+rh92GO3DI85hQY/x+geabjOEjjQ1S q6wjoKAAGRX+xA/95Qpt9L4QmazvsxLPEEeh1tFQ= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) by sourceware.org (Postfix) with ESMTPS id 03C523858D35 for ; Wed, 22 Dec 2021 13:27:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 03C523858D35 Received: by mail-qt1-x831.google.com with SMTP id j17so1895475qtx.2 for ; Wed, 22 Dec 2021 05:27:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=w9bG/tV/rpPWERwWsNtN+rXlWw1ltNt1K2W328Gxvvw=; b=qHykkpucIi5Pl8wdOeQ2ueW+cfs4Z8CFOCiOA3av0e+OBu0KYTTaEK1G96Ff2+PLvN DVNN/duseNRgWy2lTI24k/z7elv6ChpiOxvHMSousV94KtWLnsGuv2WNgeVnH271GZrf 8ui/1PpDMItI+ESBTgvBKmwBrRegV0WUU3KToOzg7JHnAOFm+Wsy2jLi/CRYgprsT0OX JnDdv6RvAAwQ9y2OzJW19ZFcHiEWmWAxkXTyj3kzI2Jew+cdugSc932NgT3K/lubXCy7 WncVKqPp/mopjbVNax9BgTU9guNMRqZqVl4LoM94n0knnZ5PF3D/a5c/CymNNfyg4TG2 u9Cg== X-Gm-Message-State: AOAM533vVxod4GdKEAOBApBUb2bi4OOPLKOuiz6JIvJRcWwAlverqdQf l68kgHyx4IlKtu1ZbtqA+3GOax90JKmvyQ== X-Google-Smtp-Source: ABdhPJzgq1DsIwz2d4jXnT2s5D09WVuflum0uan8NeQlOWEXJGbdJiu/goFlnh9BBcU1KnI2EH6dWg== X-Received: by 2002:a05:622a:308:: with SMTP id q8mr1963776qtw.463.1640179636255; Wed, 22 Dec 2021 05:27:16 -0800 (PST) Received: from birita.. ([2804:431:c7cb:3b1e:1ba8:c11f:6224:efe1]) by smtp.gmail.com with ESMTPSA id x13sm1942849qkp.102.2021.12.22.05.27.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Dec 2021 05:27:16 -0800 (PST) To: libc-alpha@sourceware.org, fweimer@redhat.com Subject: [PATCH v7 00/16] Multiple rtld-audit fixes Date: Wed, 22 Dec 2021 10:26:56 -0300 Message-Id: <20211222132712.523295-1-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_STOCKGEN, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Netto Reply-To: Adhemerval Zanella Cc: John Mellor-Crummey Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" This patchset fixes most of the rtld-audit issues brought by John Mellor-Crummey [1] while trying to use it along with the HPCToolkit. This should cover all the issues listed as 'Tier 1' [2] (the aarch64 SVE requires additional work, so it is postpone to 2.36) and also most of the 'Tier2' issue (BZ#28096 inclusive) which prevents the use of some glibc function that uses TLS internally on the audit module. There is also some point brough by John Melloc-Crummey documents that I don't have a straighforward answer so I haven't added on this patchset: 1 la_activity(LA_ACT_ADD) is never called for auditor namespaces, even though la_objopen and la_activity(LA_ACT_CONSISTENT) are. There is no easy solution for this: we need at least to load the *first* auditor to actually issue the la_activity(LA_ACT_ADD). It means that it would *only* work for subsequent audit modules, and adding this specific semantic is confusing and does not really improve things (it only helps when multiple audit modules are used). 2. la_objopen is called for the main binary and for ld.so before the first la_activity(LA_ACT_ADD) call. This contradicts the pattern found in a successful dlopen (where la_activity(LA_ACT_ADD) precedes la_objopen). The constrain here is we need to handle DT_AUDIT and DT_DEPAUDIT dynamic tags, which means we need to first load the executable in memory to parse the required audit modules. So we need to first parse the dynamic audit tags, load the audit modules, and then load the object itself. 3. For non-PIE executables the base address listed in link_map->l_addr for the main application binary is 0, even though dladdr is able to recover the correct offset. La_objopen is affected by this. This would require to change an internal semantic for link_map->l_addr. This is not straighfoward and I am not sure about the direct gains. I have checked the patches on x86_64, i686, aarch64, armv7, powerpc64, powerpc64le, and powerpc. [1] https://sourceware.org/pipermail/libc-alpha/2021-June/127636.html [2] https://docs.google.com/document/d/1dVaDBdzySecxQqD6hLLzDrEF18M1UtjDna9gL5BWWI0/edit# [3] https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/azanella/ld-audit-fixes Changes from v6: - Dropped SVE, main application on main_map l_name, and Run constructors if executable has a soname of a dependency patches. - Bumped LAV_VERSION to 2 on la_symbind bind-now support. - Added extension pointer on aarch64 fix. - Moved the refactor patch at the start of the set. - Changed _dl_audit_objsearch interface. Changes from v5: - Fixed build with --enable-profiling=yes. - Moved la_activity (LA_ACT_ADD) *after* _dl_add_to_namespace_list() for BZ#28062 fix. - Fixed powerpc64 ELFv1 OPD toc setup for bind-now. - Fixed testsuite issues for ia64. - Removed LA_SYMB_BINDNOW now that LA_SYMB_NOPLTENTER and LA_SYMB_NOPLTEXIT is passed for bind-now. Changes from v4: - Added a fix for constructors if executable has a soname of a dependency - Rebased against master. Changes from v3 - Added a aarch64 SVE RFC patch. - Fixed an issue with bind-now fix on powerpc64 ELFv1. - Rebased against master. Changes from v2 - Refactored rtld-audit code to move common come to dl-audit.c. - Issue audit la_objopen() for vDSO. - Isseu la_activity during application exit. - Issue la_symbind() for bind-now (BZ #23734). - Fix runtime linker auditing on aarch64 (BZ #26643) Changes from v1 - Fixed -fstack-protector-all tst-auditmod17. - Simplify the _dl_call_libc_early_init call the 'Fix audit regression' patch. - Remove symbind check fr BZ#15333. - Added the BZ#28096 fix. Adhemerval Zanella (15): elf: Add _dl_audit_objopen elf: Add _dl_audit_activity_map and _dl_audit_activity_nsid elf: Add _dl_audit_objsearch elf: Add _dl_audit_objclose elf: Add _dl_audit_symbind_alt and _dl_audit_symbind elf: Add _dl_audit_preinit elf: Add _dl_audit_pltenter elf: Add _dl_audit_pltexit elf: Avoid unnecessary slowdown from profiling with audit (BZ#15533) elf: Add audit tests for modules with TLSDESC elf: Do not fail for failed dlmopen on audit modules (BZ #28061) elf: Fix initial-exec TLS access on audit modules (BZ #28096) elf: Issue audit la_objopen for vDSO elf: Add la_activity during application exit elf: Issue la_symbind for bind-now (BZ #23734) Ben Woodard (1): elf: Fix runtime linker auditing on aarch64 (BZ #26643) NEWS | 7 + bits/link_lavcurrent.h | 2 +- csu/libc-start.c | 23 +- elf/Makefile | 147 ++++++++- elf/Versions | 1 + elf/dl-audit.c | 385 ++++++++++++++++++++++ elf/dl-close.c | 67 +--- elf/dl-fini.c | 25 +- elf/dl-load.c | 107 ++---- elf/dl-object.c | 20 +- elf/dl-open.c | 22 +- elf/dl-reloc.c | 20 +- elf/dl-runtime.c | 252 ++------------ elf/dl-support.c | 8 + elf/dl-sym-post.h | 47 +-- elf/dl-tls.c | 16 +- elf/do-rel.h | 57 +++- elf/rtld.c | 73 +--- elf/setup-vdso.h | 2 +- elf/sotruss-lib.c | 6 + elf/tst-audit-tlsdesc-dlopen.c | 67 ++++ elf/tst-audit-tlsdesc-mod1.c | 41 +++ elf/tst-audit-tlsdesc-mod2.c | 33 ++ elf/tst-audit-tlsdesc.c | 60 ++++ elf/tst-audit19a.c | 38 +++ elf/tst-audit19b.c | 94 ++++++ elf/tst-audit19bmod.c | 23 ++ elf/tst-audit20.c | 25 ++ elf/tst-audit21.c | 42 +++ elf/tst-audit22.c | 124 +++++++ elf/tst-audit23.c | 173 ++++++++++ elf/tst-audit23mod.c | 23 ++ elf/tst-audit24a.c | 36 ++ elf/tst-audit24amod1.c | 31 ++ elf/tst-audit24amod2.c | 25 ++ elf/tst-audit24b.c | 37 +++ elf/tst-audit24bmod1.c | 31 ++ elf/tst-audit24bmod2.c | 23 ++ elf/tst-audit24c.c | 2 + elf/tst-audit24d.c | 36 ++ elf/tst-audit24dmod1.c | 33 ++ elf/tst-audit24dmod2.c | 28 ++ elf/tst-audit24dmod3.c | 31 ++ elf/tst-audit24dmod4.c | 25 ++ elf/tst-audit25a.c | 127 +++++++ elf/tst-audit25b.c | 128 +++++++ elf/tst-audit25mod1.c | 30 ++ elf/tst-audit25mod2.c | 30 ++ elf/tst-audit25mod3.c | 22 ++ elf/tst-audit25mod4.c | 22 ++ elf/tst-auditmod-tlsdesc.c | 25 ++ elf/tst-auditmod19a.c | 25 ++ elf/tst-auditmod19b.c | 46 +++ elf/tst-auditmod20.c | 57 ++++ elf/tst-auditmod21a.c | 80 +++++ elf/tst-auditmod21b.c | 22 ++ elf/tst-auditmod22.c | 51 +++ elf/tst-auditmod23.c | 69 ++++ elf/tst-auditmod24.h | 29 ++ elf/tst-auditmod24a.c | 114 +++++++ elf/tst-auditmod24b.c | 104 ++++++ elf/tst-auditmod24c.c | 3 + elf/tst-auditmod24d.c | 120 +++++++ elf/tst-auditmod25.c | 79 +++++ include/dlfcn.h | 2 + include/link.h | 4 + sysdeps/aarch64/Makefile | 20 ++ sysdeps/aarch64/bits/link.h | 26 +- sysdeps/aarch64/dl-audit-check.h | 28 ++ sysdeps/aarch64/dl-link.sym | 6 +- sysdeps/aarch64/dl-trampoline.S | 99 ++++-- sysdeps/aarch64/tst-audit26.c | 37 +++ sysdeps/aarch64/tst-audit26mod.c | 33 ++ sysdeps/aarch64/tst-audit26mod.h | 50 +++ sysdeps/aarch64/tst-audit27.c | 64 ++++ sysdeps/aarch64/tst-audit27mod.c | 95 ++++++ sysdeps/aarch64/tst-audit27mod.h | 67 ++++ sysdeps/aarch64/tst-auditmod26.c | 103 ++++++ sysdeps/aarch64/tst-auditmod27.c | 180 ++++++++++ sysdeps/alpha/dl-trampoline.S | 8 +- sysdeps/arm/dl-machine-rel.h | 2 + sysdeps/arm/dl-trampoline.S | 2 +- sysdeps/generic/dl-audit-check.h | 23 ++ sysdeps/generic/dl-fixup-attribute.h | 24 ++ sysdeps/generic/dl-lookupcfg.h | 3 + sysdeps/generic/dl-machine-rel.h | 2 + sysdeps/generic/ldsodefs.h | 52 +++ sysdeps/hppa/dl-lookupcfg.h | 3 + sysdeps/hppa/dl-runtime.c | 2 +- sysdeps/hppa/dl-trampoline.S | 6 +- sysdeps/i386/dl-fixup-attribute.h | 30 ++ sysdeps/i386/dl-machine-rel.h | 2 + sysdeps/i386/dl-machine.h | 23 -- sysdeps/i386/dl-trampoline.S | 2 +- sysdeps/ia64/dl-lookupcfg.h | 3 + sysdeps/ia64/dl-trampoline.S | 16 +- sysdeps/m68k/dl-trampoline.S | 2 +- sysdeps/mips/dl-machine-rel.h | 1 + sysdeps/powerpc/dl-lookupcfg.h | 39 +++ sysdeps/powerpc/powerpc64/dl-trampoline.S | 4 +- sysdeps/s390/s390-32/dl-trampoline.h | 4 +- sysdeps/s390/s390-64/dl-trampoline.h | 2 +- sysdeps/sh/dl-trampoline.S | 4 +- sysdeps/sparc/sparc32/dl-trampoline.S | 2 +- sysdeps/sparc/sparc64/dl-trampoline.S | 2 +- sysdeps/x86_64/dl-runtime.h | 2 +- sysdeps/x86_64/dl-trampoline.h | 6 +- 107 files changed, 3978 insertions(+), 658 deletions(-) create mode 100644 elf/dl-audit.c create mode 100644 elf/tst-audit-tlsdesc-dlopen.c create mode 100644 elf/tst-audit-tlsdesc-mod1.c create mode 100644 elf/tst-audit-tlsdesc-mod2.c create mode 100644 elf/tst-audit-tlsdesc.c create mode 100644 elf/tst-audit19a.c create mode 100644 elf/tst-audit19b.c create mode 100644 elf/tst-audit19bmod.c create mode 100644 elf/tst-audit20.c create mode 100644 elf/tst-audit21.c create mode 100644 elf/tst-audit22.c create mode 100644 elf/tst-audit23.c create mode 100644 elf/tst-audit23mod.c create mode 100644 elf/tst-audit24a.c create mode 100644 elf/tst-audit24amod1.c create mode 100644 elf/tst-audit24amod2.c create mode 100644 elf/tst-audit24b.c create mode 100644 elf/tst-audit24bmod1.c create mode 100644 elf/tst-audit24bmod2.c create mode 100644 elf/tst-audit24c.c create mode 100644 elf/tst-audit24d.c create mode 100644 elf/tst-audit24dmod1.c create mode 100644 elf/tst-audit24dmod2.c create mode 100644 elf/tst-audit24dmod3.c create mode 100644 elf/tst-audit24dmod4.c create mode 100644 elf/tst-audit25a.c create mode 100644 elf/tst-audit25b.c create mode 100644 elf/tst-audit25mod1.c create mode 100644 elf/tst-audit25mod2.c create mode 100644 elf/tst-audit25mod3.c create mode 100644 elf/tst-audit25mod4.c create mode 100644 elf/tst-auditmod-tlsdesc.c create mode 100644 elf/tst-auditmod19a.c create mode 100644 elf/tst-auditmod19b.c create mode 100644 elf/tst-auditmod20.c create mode 100644 elf/tst-auditmod21a.c create mode 100644 elf/tst-auditmod21b.c create mode 100644 elf/tst-auditmod22.c create mode 100644 elf/tst-auditmod23.c create mode 100644 elf/tst-auditmod24.h create mode 100644 elf/tst-auditmod24a.c create mode 100644 elf/tst-auditmod24b.c create mode 100644 elf/tst-auditmod24c.c create mode 100644 elf/tst-auditmod24d.c create mode 100644 elf/tst-auditmod25.c create mode 100644 sysdeps/aarch64/dl-audit-check.h create mode 100644 sysdeps/aarch64/tst-audit26.c create mode 100644 sysdeps/aarch64/tst-audit26mod.c create mode 100644 sysdeps/aarch64/tst-audit26mod.h create mode 100644 sysdeps/aarch64/tst-audit27.c create mode 100644 sysdeps/aarch64/tst-audit27mod.c create mode 100644 sysdeps/aarch64/tst-audit27mod.h create mode 100644 sysdeps/aarch64/tst-auditmod26.c create mode 100644 sysdeps/aarch64/tst-auditmod27.c create mode 100644 sysdeps/generic/dl-audit-check.h create mode 100644 sysdeps/generic/dl-fixup-attribute.h create mode 100644 sysdeps/i386/dl-fixup-attribute.h create mode 100644 sysdeps/powerpc/dl-lookupcfg.h