From patchwork Tue Nov 9 18:33:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 47298 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 280413858018 for ; Tue, 9 Nov 2021 18:34:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 280413858018 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1636482857; bh=X8YRUN8JxsvQD/zM6Aq0gEO/SjaQhIz7od1QCortdDc=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=x2Yc//d2Ne6Wt/RpEvtYWGI72rZbvjEPhgiQasK0hlrhHSRm2Ov/kIj8ickFjmKBi ycM85R1wme3wV2VG1g9TXr6kJtLlsNoi8BM5toDvN9rFlRbqQpn/SrY8zaytuHG3Br 1Qp8A3nBsvvqBwBS0nYVc2g3YT50hS/UFIgDHp5s= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id C715B3858404 for ; Tue, 9 Nov 2021 18:33:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C715B3858404 Received: by mail-pl1-x62d.google.com with SMTP id p18so41486plf.13 for ; Tue, 09 Nov 2021 10:33:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=X8YRUN8JxsvQD/zM6Aq0gEO/SjaQhIz7od1QCortdDc=; b=VUG9W/c/YKvX+jW9lsSSk5WNkwwllilns5ofJZjN8xq9kebEHYsSwXks0UaM6c4Otg s1hSTY70aevJuMOtcLkKH3Eb+m5W727SisoNVYlFtgrxe34JsiPETagF9Mu79VYPebUu jL0yljV28AUDtL1KT9DJzIMjNG6Oqz4omLG+L70TZ5FjXXcOn3Z5mUr6l6Mgmg0gYYBo sP9ljWChuCsqQbKFLSozgz8O45+Ak8DWaFJY+Iw7jR1Qjzisu7tRd2X7PExCDZliybhg yc0MpCsqmq+Wc9WPBz+IwZ/etnc/FZ+9s+0SYA2JpuPD4OL/d6u1jfHffVw2hLgK6gMK wTxw== X-Gm-Message-State: AOAM531bBT5rYZp7RRk8Xo3dQ8S0fgI55ScvGJL6ErWjsHZeoh7kTC7q fv9pFTMtmEGCsigxbVWYwyJcZIRQSuBj6A== X-Google-Smtp-Source: ABdhPJyGj4fQu2+v5xi0yGT8vVdbZP9eA8a/pTVow9ivcBwrkXGnA/1SFAPYmB7DpUODuOKGrqv6JQ== X-Received: by 2002:a17:90b:390e:: with SMTP id ob14mr9652346pjb.44.1636482832377; Tue, 09 Nov 2021 10:33:52 -0800 (PST) Received: from birita.. ([2804:431:c7cb:55a:94d0:2630:9b29:e621]) by smtp.gmail.com with ESMTPSA id ep15sm3761884pjb.3.2021.11.09.10.33.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Nov 2021 10:33:52 -0800 (PST) To: libc-alpha@sourceware.org, Florian Weimer Subject: [PATCH v5 00/22] Multiple rtld-audit fixes Date: Tue, 9 Nov 2021 15:33:25 -0300 Message-Id: <20211109183347.2943786-1-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_STOCKGEN, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Netto Reply-To: Adhemerval Zanella Cc: John Mellor-Crummey Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" This patchset fixes most of the rtld-audit issues brought by John Mellor-Crummey [1] while trying to use it along with the HPCToolkit. This should cover all the issues listed as 'Tier 1' [2] (although the aarch64 SVE is marked as RFC) and also most of the 'Tier2' issue (BZ#28096 inclusive) which prevents the use of some glibc function that uses TLS internally on the audit module. On this set I also added a possible fix for the aarch64 SVE, although there is some issues regarding STO_AARCH64_VARIANT_PCS. I also pushed this patch on a personal branch [3]. There is also some point brough by John Melloc-Crummey documents that I don't have a straighforward answer so I haven't added on this patchset: 1 la_activity(LA_ACT_ADD) is never called for auditor namespaces, even though la_objopen and la_activity(LA_ACT_CONSISTENT) are. There is no easy solution for this: we need at least to load the *first* auditor to actually issue the la_activity(LA_ACT_ADD). It means that it would *only* work for subsequent audit modules, and adding this specific semantic is confusing and does not really improve things (it only helps when multiple audit modules are used). 2. la_objopen is called for the main binary and for ld.so before the first la_activity(LA_ACT_ADD) call. This contradicts the pattern found in a successful dlopen (where la_activity(LA_ACT_ADD) precedes la_objopen). The constrain here is we need to handle DT_AUDIT and DT_DEPAUDIT dynamic tags, which means we need to first load the executable in memory to parse the required audit modules. So we need to first parse the dynamic audit tags, load the audit modules, and then load the object itself. 3. For non-PIE executables the base address listed in link_map->l_addr for the main application binary is 0, even though dladdr is able to recover the correct offset. La_objopen is affected by this. This would require to change an internal semantic for link_map->l_addr. This is not straighfoward and I am not sure about the direct gains. I have checked the patches on x86_64, i686, aarch64, armv7, powerpc64, powerpc64le, and powerpc. [1] https://sourceware.org/pipermail/libc-alpha/2021-June/127636.html [2] https://docs.google.com/document/d/1dVaDBdzySecxQqD6hLLzDrEF18M1UtjDna9gL5BWWI0/edit# [3] https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/azanella/ld-audit-fixes Changes from v4: - Added a fix for constructors if executable has a soname of a dependency - Rebased against master. Changes from v3 - Added a aarch64 SVE RFC patch. - Fixed an issue with bind-now fix on powerpc64 ELFv1. - Rebased against master. Changes from v2 - Refactored rtld-audit code to move common come to dl-audit.c. - Issue audit la_objopen() for vDSO. - Isseu la_activity during application exit. - Issue la_symbind() for bind-now (BZ #23734). - Fix runtime linker auditing on aarch64 (BZ #26643) Changes from v1 - Fixed -fstack-protector-all tst-auditmod17. - Simplify the _dl_call_libc_early_init call the 'Fix audit regression' patch. - Remove symbind check fr BZ#15333. - Added the BZ#28096 fix. Adhemerval Zanella (20): elf: Avoid unnecessary slowdown from profiling with audit (BZ#15533) elf: Add audit tests for modules with TLSDESC elf: Do not fail for failed dlopem on audit modules (BZ #28061) elf: Fix initial-exec TLS access on audit modules (BZ #28096) elf: Add _dl_audit_objopen elf: Add _dl_audit_activity_map and _dl_audit_activity_nsid elf: Add _dl_audit_objsearch elf: Add _dl_audit_objclose elf: Add _dl_audit_symbind_alt and _dl_audit_symbind elf: Add _dl_audit_preinit elf: Add _dl_audit_pltenter elf: Add _dl_audit_pltexit elf: Issue audit la_objopen() for vDSO elf: Run constructors if executable has a soname of a dependency elf: Add main application on main_map l_name elf: Add la_activity during application exit elf: Issue la_symbind() for bind-now (BZ #23734) elf: Add LA_SYMB_BINDNOW elf: Move LAV_CURRENT to link_lavcurrent.h elf: Add SVE support for aarch64 rtld-audit Ben Woodard (1): elf: Fix runtime linker auditing on aarch64 (BZ #26643) Vivek Das Mohapatra (1): elf: Suppress audit calls when a (new) namespace is empty (BZ #28062) NEWS | 4 + bits/link_lavcurrent.h | 25 ++ csu/libc-start.c | 23 +- dlfcn/Makefile | 4 +- dlfcn/tst-dladdr-self.c | 55 +++ elf/Makefile | 126 ++++++- elf/Versions | 1 + elf/dl-addr.c | 5 - elf/dl-audit.c | 394 ++++++++++++++++++++++ elf/dl-close.c | 74 +--- elf/dl-dst.h | 2 +- elf/dl-fini.c | 25 +- elf/dl-init.c | 3 +- elf/dl-load.c | 112 ++---- elf/dl-misc.c | 1 + elf/dl-object.c | 20 +- elf/dl-open.c | 22 +- elf/dl-reloc.c | 26 +- elf/dl-runtime.c | 244 ++------------ elf/dl-sym-post.h | 47 +-- elf/dl-tls.c | 16 +- elf/do-rel.h | 71 +++- elf/dso-sort-tests-1.def | 5 +- elf/dynamic-link.h | 26 +- elf/link.h | 7 +- elf/rtld.c | 81 +---- elf/setup-vdso.h | 2 +- elf/tst-audit-tlsdesc-audit.c | 23 ++ elf/tst-audit-tlsdesc-dlopen.c | 67 ++++ elf/tst-audit-tlsdesc.c | 60 ++++ elf/tst-audit18a.c | 39 +++ elf/tst-audit18b.c | 94 ++++++ elf/tst-audit18bmod.c | 23 ++ elf/tst-audit18mod.c | 17 + elf/tst-audit19.c | 25 ++ elf/tst-audit20.c | 129 +++++++ elf/tst-audit20mod.c | 26 ++ elf/tst-audit21.c | 42 +++ elf/tst-audit22.c | 123 +++++++ elf/tst-audit23.c | 161 +++++++++ elf/tst-audit23mod.c | 23 ++ elf/tst-audit24a.c | 36 ++ elf/tst-audit24amod1.c | 31 ++ elf/tst-audit24amod2.c | 25 ++ elf/tst-audit24b.c | 37 ++ elf/tst-audit24bmod1.c | 31 ++ elf/tst-audit24bmod2.c | 23 ++ elf/tst-audit24c.c | 2 + elf/tst-audit24d.c | 36 ++ elf/tst-audit24dmod1.c | 33 ++ elf/tst-audit24dmod2.c | 28 ++ elf/tst-audit24dmod3.c | 31 ++ elf/tst-audit24dmod4.c | 25 ++ elf/tst-audit25a.c | 126 +++++++ elf/tst-audit25b.c | 127 +++++++ elf/tst-audit25mod1.c | 30 ++ elf/tst-audit25mod2.c | 30 ++ elf/tst-audit25mod3.c | 22 ++ elf/tst-audit25mod4.c | 22 ++ elf/tst-auditmod-tlsdesc1.c | 41 +++ elf/tst-auditmod-tlsdesc2.c | 33 ++ elf/tst-auditmod18a.c | 23 ++ elf/tst-auditmod18b.c | 46 +++ elf/tst-auditmod19.c | 57 ++++ elf/tst-auditmod20.c | 73 ++++ elf/tst-auditmod21.c | 69 ++++ elf/tst-auditmod22.c | 65 ++++ elf/tst-auditmod23.c | 78 +++++ elf/tst-auditmod24a.c | 104 ++++++ elf/tst-auditmod24b.c | 99 ++++++ elf/tst-auditmod24c.c | 3 + elf/tst-auditmod24d.c | 114 +++++++ elf/tst-auditmod25.c | 77 +++++ gmon/gmon.c | 10 +- include/dlfcn.h | 1 + include/link.h | 4 + sysdeps/aarch64/Makefile | 32 ++ sysdeps/aarch64/bits/link.h | 28 +- sysdeps/aarch64/bits/link_lavcurrent.h | 25 ++ sysdeps/aarch64/dl-link.sym | 7 +- sysdeps/aarch64/dl-machine.h | 14 +- sysdeps/aarch64/dl-trampoline.S | 391 +++++++++++++++++++-- sysdeps/aarch64/tst-audit26.c | 37 ++ sysdeps/aarch64/tst-audit26mod.c | 33 ++ sysdeps/aarch64/tst-audit26mod.h | 50 +++ sysdeps/aarch64/tst-audit27.c | 64 ++++ sysdeps/aarch64/tst-audit27mod.c | 95 ++++++ sysdeps/aarch64/tst-audit27mod.h | 67 ++++ sysdeps/aarch64/tst-audit28.c | 44 +++ sysdeps/aarch64/tst-audit28mod.c | 48 +++ sysdeps/aarch64/tst-audit28mod.h | 74 ++++ sysdeps/aarch64/tst-auditmod26.c | 98 ++++++ sysdeps/aarch64/tst-auditmod27.c | 252 ++++++++++++++ sysdeps/aarch64/tst-auditmod28.c | 193 +++++++++++ sysdeps/alpha/dl-machine.h | 2 +- sysdeps/alpha/dl-trampoline.S | 8 +- sysdeps/arc/dl-machine.h | 2 +- sysdeps/arm/dl-machine.h | 2 +- sysdeps/arm/dl-trampoline.S | 2 +- sysdeps/csky/dl-machine.h | 2 +- sysdeps/generic/dl-fixup-attribute.h | 24 ++ sysdeps/generic/dl-lookupcfg.h | 1 + sysdeps/generic/ldsodefs.h | 30 ++ sysdeps/hppa/dl-machine.h | 2 +- sysdeps/hppa/dl-runtime.c | 2 +- sysdeps/hppa/dl-trampoline.S | 6 +- sysdeps/i386/dl-fixup-attribute.h | 30 ++ sysdeps/i386/dl-machine.h | 25 +- sysdeps/i386/dl-trampoline.S | 2 +- sysdeps/ia64/dl-machine.h | 2 +- sysdeps/ia64/dl-trampoline.S | 16 +- sysdeps/m68k/dl-machine.h | 2 +- sysdeps/m68k/dl-trampoline.S | 2 +- sysdeps/microblaze/dl-machine.h | 2 +- sysdeps/mips/dl-machine.h | 2 +- sysdeps/nios2/dl-machine.h | 2 +- sysdeps/powerpc/dl-lookupcfg.h | 30 ++ sysdeps/powerpc/powerpc32/dl-machine.h | 2 +- sysdeps/powerpc/powerpc64/dl-machine.h | 2 +- sysdeps/powerpc/powerpc64/dl-trampoline.S | 4 +- sysdeps/riscv/dl-machine.h | 2 +- sysdeps/s390/s390-32/dl-machine.h | 2 +- sysdeps/s390/s390-32/dl-trampoline.h | 4 +- sysdeps/s390/s390-64/dl-machine.h | 2 +- sysdeps/s390/s390-64/dl-trampoline.h | 2 +- sysdeps/sh/dl-machine.h | 2 +- sysdeps/sh/dl-trampoline.S | 4 +- sysdeps/sparc/sparc32/dl-machine.h | 2 +- sysdeps/sparc/sparc32/dl-trampoline.S | 2 +- sysdeps/sparc/sparc64/dl-machine.h | 2 +- sysdeps/sparc/sparc64/dl-trampoline.S | 2 +- sysdeps/x86_64/dl-machine.h | 2 +- sysdeps/x86_64/dl-runtime.h | 2 +- sysdeps/x86_64/dl-trampoline.h | 6 +- 134 files changed, 4941 insertions(+), 718 deletions(-) create mode 100644 bits/link_lavcurrent.h create mode 100644 dlfcn/tst-dladdr-self.c create mode 100644 elf/dl-audit.c create mode 100644 elf/tst-audit-tlsdesc-audit.c create mode 100644 elf/tst-audit-tlsdesc-dlopen.c create mode 100644 elf/tst-audit-tlsdesc.c create mode 100644 elf/tst-audit18a.c create mode 100644 elf/tst-audit18b.c create mode 100644 elf/tst-audit18bmod.c create mode 100644 elf/tst-audit18mod.c create mode 100644 elf/tst-audit19.c create mode 100644 elf/tst-audit20.c create mode 100644 elf/tst-audit20mod.c create mode 100644 elf/tst-audit21.c create mode 100644 elf/tst-audit22.c create mode 100644 elf/tst-audit23.c create mode 100644 elf/tst-audit23mod.c create mode 100644 elf/tst-audit24a.c create mode 100644 elf/tst-audit24amod1.c create mode 100644 elf/tst-audit24amod2.c create mode 100644 elf/tst-audit24b.c create mode 100644 elf/tst-audit24bmod1.c create mode 100644 elf/tst-audit24bmod2.c create mode 100644 elf/tst-audit24c.c create mode 100644 elf/tst-audit24d.c create mode 100644 elf/tst-audit24dmod1.c create mode 100644 elf/tst-audit24dmod2.c create mode 100644 elf/tst-audit24dmod3.c create mode 100644 elf/tst-audit24dmod4.c create mode 100644 elf/tst-audit25a.c create mode 100644 elf/tst-audit25b.c create mode 100644 elf/tst-audit25mod1.c create mode 100644 elf/tst-audit25mod2.c create mode 100644 elf/tst-audit25mod3.c create mode 100644 elf/tst-audit25mod4.c create mode 100644 elf/tst-auditmod-tlsdesc1.c create mode 100644 elf/tst-auditmod-tlsdesc2.c create mode 100644 elf/tst-auditmod18a.c create mode 100644 elf/tst-auditmod18b.c create mode 100644 elf/tst-auditmod19.c create mode 100644 elf/tst-auditmod20.c create mode 100644 elf/tst-auditmod21.c create mode 100644 elf/tst-auditmod22.c create mode 100644 elf/tst-auditmod23.c create mode 100644 elf/tst-auditmod24a.c create mode 100644 elf/tst-auditmod24b.c create mode 100644 elf/tst-auditmod24c.c create mode 100644 elf/tst-auditmod24d.c create mode 100644 elf/tst-auditmod25.c create mode 100644 sysdeps/aarch64/bits/link_lavcurrent.h create mode 100644 sysdeps/aarch64/tst-audit26.c create mode 100644 sysdeps/aarch64/tst-audit26mod.c create mode 100644 sysdeps/aarch64/tst-audit26mod.h create mode 100644 sysdeps/aarch64/tst-audit27.c create mode 100644 sysdeps/aarch64/tst-audit27mod.c create mode 100644 sysdeps/aarch64/tst-audit27mod.h create mode 100644 sysdeps/aarch64/tst-audit28.c create mode 100644 sysdeps/aarch64/tst-audit28mod.c create mode 100644 sysdeps/aarch64/tst-audit28mod.h create mode 100644 sysdeps/aarch64/tst-auditmod26.c create mode 100644 sysdeps/aarch64/tst-auditmod27.c create mode 100644 sysdeps/aarch64/tst-auditmod28.c create mode 100644 sysdeps/generic/dl-fixup-attribute.h create mode 100644 sysdeps/i386/dl-fixup-attribute.h create mode 100644 sysdeps/powerpc/dl-lookupcfg.h