From patchwork Wed Oct 6 18:05:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 45931 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 305193857C6C for ; Wed, 6 Oct 2021 18:06:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 305193857C6C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1633543584; bh=CmmzLacI4imkEqkWK1nxZNXESBDucrh16VI9hiJ5Isk=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=id3MJRScfe0w+krGxTUQcCZsaPiPPdv9kLybHPhuJLcYtoiSvJshtdbYufio0yrNY uJkQ34W62GJTInmepJFwM16gzQN1bLx9hXzdfnhWEsGJ8Ua5eikfm/jygiObbclbyt 8QRIfSeJaKi2JLreNWTAIoHBcy+xeWVfSBeGT/5U= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) by sourceware.org (Postfix) with ESMTPS id A43FC3858C39 for ; Wed, 6 Oct 2021 18:06:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A43FC3858C39 Received: by mail-qt1-x82b.google.com with SMTP id i1so2374887qtr.6 for ; Wed, 06 Oct 2021 11:06:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CmmzLacI4imkEqkWK1nxZNXESBDucrh16VI9hiJ5Isk=; b=aSGH4AvXSvtvgRSAI6JwlL22UKNo3pPV0c7+/XxN4Fs+jpynhW5zEmOdCPJ0TgNS// lKAgDXRNgHnpdSFghk1CWi6kz+pkp25+/PMc+2YdLDailUg62GsWPPsxJ3h9No+MlHoy OxoQtY9S3kHJjYPATySXXxc2VbVnxHdOieHtOu1N1gEWxtSVVW4nGQLWO/b4U6zECfPh BNwazYZpYsVju/sSDnOYhdjzJKZ3tFAafQAxeZWy/eC03DLLGnoJ2OGuIS/YxBix9nHy AMOSUBJr8JsabV2v6B2u8D+6Cjm9JkciKGwlkEJTMJSBrZvpzz5IGL9NT15fuGOUtcPf 2jTA== X-Gm-Message-State: AOAM5335wpfa+EkM+7vI97nVIvGKcoOL0BcaHdXdLf/IQKP8KSZLvRdj 3MLh66Z50KstzN1v787dISofBf6QJVOF3w== X-Google-Smtp-Source: ABdhPJxJuX/2iBznzEc7i9UNKczV6/XVdQ7/VX1zrC5I7WtX1K5BhZe+L3CkgkPt3XocQ5bYalva9Q== X-Received: by 2002:ac8:5348:: with SMTP id d8mr156662qto.15.1633543560996; Wed, 06 Oct 2021 11:06:00 -0700 (PDT) Received: from birita.. ([2804:431:c7cb:807a:2ebe:4b13:27bd:f11d]) by smtp.gmail.com with ESMTPSA id 18sm14161168qtz.49.2021.10.06.11.06.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Oct 2021 11:06:00 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH 0/9] Improve hypot() Date: Wed, 6 Oct 2021 15:05:48 -0300 Message-Id: <20211006180557.933826-1-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Netto Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" This patchset uses a different algorithm for hypot() based on the 'An Improved Algorithm for hypot(a,b)' by Carlos F. Borges [1]. This method is also used by Julia language. The motivation for this change are: 1. The new algorithm is more precise without large performance differences. 2. It allows to consolidate the implementations, since it favor floating-point operations over integer ones (as done for powerpc). This might be a boost for some architectures as well. The current hypot() implementation seems already to be bounded to a maximum of 1 ulp of error, however the new proposed algorithm shows an slight precision improvement by showing more correctly rounded results. With a random 1e9 inputs for different float format I see: - An improvement from 3427362 to 18457 results with 1 ulp of error for Binary64. - An improvement from 233442 to 1274 results with 1 ulp of error for Binary96 (x86_64). - An improvement from 453045 to 1294 results with 1 ulp of error for Binary96 (x86_64). Along with the newer implementation, the last patch also optimizes the call with similar work done for other math functions by removing the POSIX error handling (which is a big performance boost in some cases and architectures). I have adapted the dbl-64, ldbl-96, and ldbl-128, the flt-32 is not required since it calls the dbl-64 one. I have not adapated ldbl-128ibm since the format has a lot of caveats and IBM aims to move to ldbl-128. [1] https://arxiv.org/pdf/1904.09481.pdf [2] https://github.com/JuliaLang/julia/commit/4a046009a3362ab5e17d369641dbbc9657eb680c Adhemerval Zanella (9): benchtests: Make hypot input random benchtests: Add hypotf math: Simplify hypotf implementation math: Use an improved algorithm for hypot (dbl-64) math: Use an improved algorithm for hypotl (ldbl-96) math: Use an improved algorithm for hypotl (ldbl-128) math: Remove powerpc e_hypot i386: Move hypot implementation to C math: Remove the error handling wrapper from hypot and hypotf benchtests/Makefile | 2 +- benchtests/hypot-inputs | 1014 ++++++++++++++++- benchtests/hypotf-inputs | 1006 ++++++++++++++++ math/Versions | 2 + math/w_hypot.c | 8 + math/w_hypot_compat.c | 13 +- math/w_hypotf.c | 8 + math/w_hypotf_compat.c | 6 +- sysdeps/i386/fpu/e_hypot.S | 75 -- sysdeps/i386/fpu/e_hypot.c | 54 + sysdeps/i386/fpu/e_hypotf.S | 64 -- sysdeps/ieee754/dbl-64/e_hypot.c | 247 ++-- sysdeps/ieee754/dbl-64/w_hypot.c | 1 + sysdeps/ieee754/flt-32/e_hypotf.c | 72 +- sysdeps/ieee754/flt-32/w_hypotf.c | 1 + sysdeps/ieee754/ldbl-128/e_hypotl.c | 222 ++-- sysdeps/ieee754/ldbl-96/e_hypotl.c | 227 ++-- sysdeps/mach/hurd/i386/libm.abilist | 2 + sysdeps/mach/hurd/libhurduser.abilist | 0 sysdeps/mach/libmachuser.abilist | 0 sysdeps/powerpc/fpu/e_hypot.c | 87 -- sysdeps/powerpc/fpu/e_hypotf.c | 78 -- .../powerpc32/power4/fpu/multiarch/Makefile | 5 +- .../power4/fpu/multiarch/e_hypot-power7.c | 23 - .../power4/fpu/multiarch/e_hypot-ppc32.c | 23 - .../powerpc32/power4/fpu/multiarch/e_hypot.c | 33 - .../power4/fpu/multiarch/e_hypotf-power7.c | 23 - .../power4/fpu/multiarch/e_hypotf-ppc32.c | 23 - .../powerpc32/power4/fpu/multiarch/e_hypotf.c | 33 - sysdeps/unix/sysv/linux/aarch64/libm.abilist | 2 + sysdeps/unix/sysv/linux/alpha/libm.abilist | 2 + sysdeps/unix/sysv/linux/arm/be/libm.abilist | 2 + sysdeps/unix/sysv/linux/arm/le/libm.abilist | 2 + sysdeps/unix/sysv/linux/hppa/libm.abilist | 2 + sysdeps/unix/sysv/linux/i386/libm.abilist | 2 + .../sysv/linux/m68k/coldfire/libm.abilist | 2 + .../unix/sysv/linux/m68k/m680x0/libm.abilist | 2 + .../sysv/linux/microblaze/be/libm.abilist | 2 + .../sysv/linux/microblaze/le/libm.abilist | 2 + .../unix/sysv/linux/mips/mips32/libm.abilist | 2 + .../unix/sysv/linux/mips/mips64/libm.abilist | 2 + sysdeps/unix/sysv/linux/nios2/libm.abilist | 2 + .../linux/powerpc/powerpc32/fpu/libm.abilist | 2 + .../powerpc/powerpc32/nofpu/libm.abilist | 2 + .../linux/powerpc/powerpc64/be/libm.abilist | 2 + .../linux/powerpc/powerpc64/le/libm.abilist | 2 + .../unix/sysv/linux/s390/s390-32/libm.abilist | 2 + .../unix/sysv/linux/s390/s390-64/libm.abilist | 2 + sysdeps/unix/sysv/linux/sh/be/libm.abilist | 2 + sysdeps/unix/sysv/linux/sh/le/libm.abilist | 2 + .../sysv/linux/sparc/sparc32/libm.abilist | 2 + .../sysv/linux/sparc/sparc64/libm.abilist | 2 + .../unix/sysv/linux/x86_64/64/libm.abilist | 2 + .../unix/sysv/linux/x86_64/x32/libm.abilist | 2 + 54 files changed, 2483 insertions(+), 919 deletions(-) create mode 100644 benchtests/hypotf-inputs create mode 100644 math/w_hypot.c create mode 100644 math/w_hypotf.c delete mode 100644 sysdeps/i386/fpu/e_hypot.S create mode 100644 sysdeps/i386/fpu/e_hypot.c delete mode 100644 sysdeps/i386/fpu/e_hypotf.S create mode 100644 sysdeps/ieee754/dbl-64/w_hypot.c create mode 100644 sysdeps/ieee754/flt-32/w_hypotf.c delete mode 100644 sysdeps/mach/hurd/libhurduser.abilist delete mode 100644 sysdeps/mach/libmachuser.abilist delete mode 100644 sysdeps/powerpc/fpu/e_hypot.c delete mode 100644 sysdeps/powerpc/fpu/e_hypotf.c delete mode 100644 sysdeps/powerpc/powerpc32/power4/fpu/multiarch/e_hypot-power7.c delete mode 100644 sysdeps/powerpc/powerpc32/power4/fpu/multiarch/e_hypot-ppc32.c delete mode 100644 sysdeps/powerpc/powerpc32/power4/fpu/multiarch/e_hypot.c delete mode 100644 sysdeps/powerpc/powerpc32/power4/fpu/multiarch/e_hypotf-power7.c delete mode 100644 sysdeps/powerpc/powerpc32/power4/fpu/multiarch/e_hypotf-ppc32.c delete mode 100644 sysdeps/powerpc/powerpc32/power4/fpu/multiarch/e_hypotf.c