From patchwork Tue Sep 7 12:22:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 44881 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3C67C3857C6C for ; Tue, 7 Sep 2021 12:23:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3C67C3857C6C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1631017405; bh=1YCKDo0d1B0ykANr67rgn//NjX7Wi3CS7l12ikHvAQk=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=oI8jE1NcWsHYRilGp205pVSN1NUUzrUUL6yvkwMGMDZlfxgcpuEf5G8AhMElOuj0s +DzNvdDIRrO9Z+nFZrmSb0X2KJnYMRdRizFcvF8RCPAaPwdnMZX14///8avYYliane Kfm0U5G1qeklEMdIvJ0B7+hs69YSZnX7Q73/rpzs= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) by sourceware.org (Postfix) with ESMTPS id 4B2BF385842D for ; Tue, 7 Sep 2021 12:23:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4B2BF385842D Received: by mail-qt1-x82f.google.com with SMTP id 2so7734025qtw.1 for ; Tue, 07 Sep 2021 05:23:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1YCKDo0d1B0ykANr67rgn//NjX7Wi3CS7l12ikHvAQk=; b=mpYQex9fa5sZob7vlQsEOWUqxyLePYZZV8w9y14+u4esdyqqbcFa6F6D1UuFkJ9Bsd /fCAAIhyDa4yTAcGz38HrBGggJlRHGPC1Tr/e1NuUiWZwHExU4sjrabwjKtNtvTvXfry QuYMBhR3EgaDJCoe+/nBjHoAIFSN16qcJdHtIx5Jmi/Sy9wRfzfNA1UgInIMlL0e7jZw YstFflrd4qK3sTRmapbYbt9bndcnJpLKiMn5w5Urv1yCbQHpTcZJ3lB+Q1iolTkGRhB9 97yFOA+HfxKwq8n29rd8aDYl9AAsqWhKNRDJjYKRIz2lBpRpzwXgWfdXG09v7VEX+Q1b 7O9Q== X-Gm-Message-State: AOAM5310wxxlzae84L4JsTQzpMLfXktfNRwHtgUdAGdDnapc2NWkviUb ekpn4k9zRkS5FQVDwZXdCDlVYkt/hKIyOQ== X-Google-Smtp-Source: ABdhPJzkVEZEjE/zgZraFTr837UbXYfagry8pJWtLSbscHZTOFz/anDFLytkjA74jnVBUsg/vz4tqg== X-Received: by 2002:a05:622a:356:: with SMTP id r22mr15214464qtw.161.1631017382766; Tue, 07 Sep 2021 05:23:02 -0700 (PDT) Received: from birita.. ([2804:431:c7cb:733d:f360:5bf3:9813:d8f5]) by smtp.gmail.com with ESMTPSA id r18sm6902148qtm.96.2021.09.07.05.23.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Sep 2021 05:23:02 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH v2 0/3] Revert the use of sched_getaffinity on get_nproc Date: Tue, 7 Sep 2021 09:22:56 -0300 Message-Id: <20210907122259.79800-1-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Netto Reply-To: Adhemerval Zanella Cc: Florian Weimer , Nicolas Saenz Julienne Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" The use of sched_getaffinity on get_nproc and sysconf (_SC_NPROCESSORS_ONLN) done in 903bc7dcc2acafc40 (BZ #27645) breaks the top command in common hypervisor configurations and also other monitoring tools. This patchset revert to previous strategy to obtain the system-wide information first from sysfs, and then on procfs as a fallback. The sched_getaffinity is still used on malloc code since it makes more sense to get the per-process value to tune the maximum arena value. --- Changes in v2: - Added tst-sched_getaffinity.c - Use enum for cpu_bits_size - Comments cleanup Adhemerval Zanella (3): misc: Add __get_nprocs_sched linux: Simplify get_nprocs linux: Revert the use of sched_getaffinity on get_nproc (BZ #28310) include/sys/sysinfo.h | 7 +- malloc/arena.c | 2 +- misc/getsysstats.c | 6 + posix/Makefile | 3 +- posix/tst-sched_getaffinity.c | 47 +++++++ sysdeps/mach/getsysstats.c | 6 + sysdeps/unix/sysv/linux/getsysstats.c | 195 ++++++++++++++++++++------ 7 files changed, 217 insertions(+), 49 deletions(-) create mode 100644 posix/tst-sched_getaffinity.c