From patchwork Mon Sep 6 18:11:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 44868 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 62B7C385AC1D for ; Mon, 6 Sep 2021 18:11:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 62B7C385AC1D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1630951919; bh=JHW/FGWzlC3rMgYMjTLys3R1f+KQY3qzVmiWpfApxKU=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=vNwjB4c4LxcQcMUoK/4yhLI+zS9pfU/zMRCIZ2SxWOn1BjeJcAt7p+c7hKfHZebq6 WInStDyvWrsS8Q/QhGbQx8NkYesAy0ZV/6MuDeaiAhkVMQWWOHTSJpACLe4D4vvuOK kqgPJS4del1LcXbHZTEEYbDd29kWWQgGpGaYJ0Pc= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by sourceware.org (Postfix) with ESMTPS id 50A2F3857022 for ; Mon, 6 Sep 2021 18:11:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 50A2F3857022 Received: by mail-qk1-x730.google.com with SMTP id ay33so7591572qkb.10 for ; Mon, 06 Sep 2021 11:11:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=JHW/FGWzlC3rMgYMjTLys3R1f+KQY3qzVmiWpfApxKU=; b=McRjSILYPiLWC+NqxccTbDMWIdZLoqL98KbchZi8W3SOECgNzsOQbSwx3vx4APEkiq Y3dE1N4z3Q+k6FRdfDN5rr+T9ShpH8eCXDceowE9TlqSsNcZPqoEdniMMmfmj13Q0MEg MJ5Jv1d1z1FeqHo7+kBFfoHHEfM8/fq05nQk4/9+bAXgJbwPEwdh97i/CJlapPJMwwzq rdHdzeCUtC8XsYowXdPaxnTGfYxqbb7XcB+199KAxHPvBScBGofeZ/eP0fyf7QehhMkO Tr6M4tHmoeytMvoJN9zZ2bSirrvx9MNCmJCAN5SFtd14hGxbfV6s9XE02uePm5sw8IYC 5zZw== X-Gm-Message-State: AOAM5316s1Xso/ZeFq7olkjJAYALkIPH3RRCsplXRFo9B07g1IYpfA1G lbg1hHM2WpO8cYqcuEapMPZeq4vr8ajcrA== X-Google-Smtp-Source: ABdhPJyruYTxJg+EqN6FH6eUvBpcMk9s6E5wCKQzLiXKxGv5tkRSNZX8BCBYzEhAfHgrWzDOE9Tl5w== X-Received: by 2002:a05:620a:1aa6:: with SMTP id bl38mr12063800qkb.36.1630951897738; Mon, 06 Sep 2021 11:11:37 -0700 (PDT) Received: from birita.. ([2804:431:c7cb:733d:210:e147:8627:2d6]) by smtp.gmail.com with ESMTPSA id j23sm7175647qkl.65.2021.09.06.11.11.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Sep 2021 11:11:37 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH 0/3] Revert the use of sched_getaffinity on get_nproc Date: Mon, 6 Sep 2021 15:11:30 -0300 Message-Id: <20210906181133.1401140-1-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Netto Reply-To: Adhemerval Zanella Cc: Florian Weimer , Nicolas Saenz Julienne Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" The use of sched_getaffinity on get_nproc and sysconf (_SC_NPROCESSORS_ONLN) done in 903bc7dcc2acafc40 (BZ #27645) breaks the top command in common hypervisor configurations and also other monitoring tools. This patchset revert to previous strategy to obtain the system-wide information first from sysfs, and then on procfs as a fallback. The sched_getaffinity is still used on malloc code since it makes more sense to get the per-process value to tune the maximum arena value. Adhemerval Zanella (3): misc: Add __get_nprocs_sched linux: Simplify get_nprocs linux: Revert the use of sched_getaffinity on get_nproc (BZ #28310) include/sys/sysinfo.h | 7 +- malloc/arena.c | 2 +- misc/getsysstats.c | 6 + posix/Makefile | 3 +- sysdeps/mach/getsysstats.c | 6 + sysdeps/unix/sysv/linux/getsysstats.c | 192 ++++++++++++++++++++------ 6 files changed, 167 insertions(+), 49 deletions(-)