From patchwork Tue Aug 17 01:06:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 44673 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AA64F384001D for ; Tue, 17 Aug 2021 01:07:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AA64F384001D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1629162421; bh=pOSf1xhtPbnQvuML7fkW2Uf98OJCXM/yL8Kpv07FZCo=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=G++fp3lz9Z6ZmA6rrlYpzZ2hM6L+5EaZ+GRPs6Bxp9PIZQspDBWlxS3Ww4gv/KsJf QZt9x28Hnq37DDgm6pqnjDLduqWsloMY7rjcvjzeYalc0W/ptX6dVuerSU9eO0HVDx 52Jqght7ARMIQhZ5HzHg4JBf1i8ca0C7Acqupqhw= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by sourceware.org (Postfix) with ESMTPS id 88289384F030; Tue, 17 Aug 2021 01:06:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 88289384F030 Received: by mail-pj1-x1036.google.com with SMTP id u13-20020a17090abb0db0290177e1d9b3f7so2069861pjr.1; Mon, 16 Aug 2021 18:06:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pOSf1xhtPbnQvuML7fkW2Uf98OJCXM/yL8Kpv07FZCo=; b=FIXmiztJmUVISqlay4nx5/dc//MbMfSKQXUAY5An3lYdT/+80DhC8n8pc/jipOrIXa UneLHd9io7s5mite5DD2ts2/9K7zXkuc2daIVYbqa1FPYjGAcExxwitArI2bCT41RuQ3 OGOilwQ8ezoXnItrAzU3O+OthCScjJjPdW6acmmVI7WB0dsCKmlmQ6fV5Cq8qUg2YxNd pfMm4VJT74Knjjt5JoaFyj6K7XhxyNpV++SOsAC1tBnr6b8n0wFHdteRpss/C3HhsYK9 6pkW9aI02R8bdR7yMGCYFYSuFz6NkQI1glyP45N0fgZY/Cy7xisq00cCOavvd6HBb7qA 7UWg== X-Gm-Message-State: AOAM5330sD5qY81qwHPFnA7nWamviQZriOdCzGYhFPXTTy6/v+DH7Q4Z 99QxfzOQJRMVuhp3STZsYsQ= X-Google-Smtp-Source: ABdhPJzlqswB05gZmGP4Otg1kP2tyjlQ6qrumhuRjSO9bB9Ox6Et/jrRqDw161kpr9wqxtfH6nNEBg== X-Received: by 2002:a17:902:a710:b029:12b:9b9f:c461 with SMTP id w16-20020a170902a710b029012b9b9fc461mr701479plq.59.1629162390671; Mon, 16 Aug 2021 18:06:30 -0700 (PDT) Received: from gnu-cfl-2.localdomain ([172.58.38.240]) by smtp.gmail.com with ESMTPSA id o10sm269674pjg.34.2021.08.16.18.06.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 18:06:30 -0700 (PDT) Received: from gnu-cfl-2.. (localhost [IPv6:::1]) by gnu-cfl-2.localdomain (Postfix) with ESMTP id 297B3C0067; Mon, 16 Aug 2021 18:06:29 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH v2 0/2] Extend struct r_debug to support multiple namespaces Date: Mon, 16 Aug 2021 18:06:27 -0700 Message-Id: <20210817010629.593479-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Spam-Status: No, score=-3027.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "H.J. Lu via Libc-alpha" From: "H.J. Lu" Reply-To: "H.J. Lu" Cc: gdb@sourceware.org Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Changes in the v2 patch. 1. Bump r_version to 2. 2. Don't add DT_DEBUGSZ. 3. Add struct r_debug_extended to extend struct r_debug. 4. Don't update the r_state field in the copy of _r_debug in executable since it is not consumed by the program. --- Glibc does not provide an interface for debugger to access libraries loaded in multiple namespaces via dlmopen. The current rtld-debugger interface is described in the file: elf/rtld-debugger-interface.txt under the "Standard debugger interface" heading. This interface only provides access to the first link-map (LM_ID_BASE). Based on the patch from Conan C Huang : https://sourceware.org/pipermail/libc-alpha/2020-June/115448.html 1. Bump r_version to 2. This triggers the GDB bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28236 2. Add struct r_debug_extended to extend struct r_debug into a linked-list, where each element correlates to an unique namespace. 3. Add a hidden symbol, _r_debug_extended, for struct r_debug_extended. 4. Provide the compatibility symbol, _r_debug, with size of struct r_debug, as an alise of _r_debug_extended, for programs which reference _r_debug. H.J. Lu (2): Add declare_object_symbol_alias for assembly codes [BZ #28128] Extend struct r_debug to support multiple namespaces csu/Makefile | 3 ++ csu/rtld-sizes.sym | 4 ++ elf/Makefile | 22 ++++++++++- elf/dl-close.c | 2 +- elf/dl-debug-symbols-gen.c | 24 +++++++++++ elf/dl-debug-symbols.S | 31 +++++++++++++++ elf/dl-debug.c | 29 +++++++------- elf/dl-load.c | 2 +- elf/dl-open.c | 2 +- elf/dl-reloc-static-pie.c | 2 +- elf/link.h | 70 +++++++++++++++++++++++++-------- elf/rtld-debugger-interface.txt | 14 +++++++ elf/rtld.c | 4 +- elf/tst-dlmopen4.c | 68 ++++++++++++++++++++++++++++++++ include/libc-symbols.h | 12 +++--- include/link.h | 4 ++ sysdeps/generic/ldsodefs.h | 5 ++- 17 files changed, 252 insertions(+), 46 deletions(-) create mode 100644 csu/rtld-sizes.sym create mode 100644 elf/dl-debug-symbols-gen.c create mode 100644 elf/dl-debug-symbols.S create mode 100644 elf/tst-dlmopen4.c