From patchwork Tue Aug 3 21:29:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siddhesh Poyarekar X-Patchwork-Id: 44560 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 440353853C2B for ; Tue, 3 Aug 2021 21:29:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 440353853C2B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1628026197; bh=x8F3EP1ehnv4zBdLKJFFMEDpTG5NBuC/4/Vfe7hfMH0=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=JB8tJ9e3hrRvyYWRrzKJnrVg2M6LNjujZoTycC1VpRFwU7Fv45QOlmAoTibQ4F5LO 6NBkCqC4/Af8i2i33tEI0z+gJGz7S8dL+uOlN56ycWkQWlTDGXgBlknOtuDBEkemM2 eFN2MhFnLP+IU7N0SRJ4/tysfoZ3DvHi2q0W0DeQ= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from bee.birch.relay.mailchannels.net (bee.birch.relay.mailchannels.net [23.83.209.14]) by sourceware.org (Postfix) with ESMTPS id C57913858C27 for ; Tue, 3 Aug 2021 21:29:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C57913858C27 X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 06F451E258D for ; Tue, 3 Aug 2021 21:29:30 +0000 (UTC) Received: from pdx1-sub0-mail-a4.g.dreamhost.com (100-105-161-178.trex.outbound.svc.cluster.local [100.105.161.178]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 87BC71E255D for ; Tue, 3 Aug 2021 21:29:29 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a4.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.105.161.178 (trex/6.3.3); Tue, 03 Aug 2021 21:29:29 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Suffer-Juvenile: 4d5f05e042fd23b3_1628026169772_1005198605 X-MC-Loop-Signature: 1628026169771:4284960304 X-MC-Ingress-Time: 1628026169771 Received: from pdx1-sub0-mail-a4.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a4.g.dreamhost.com (Postfix) with ESMTP id 3B5B08AAAA for ; Tue, 3 Aug 2021 14:29:29 -0700 (PDT) Received: from rhbox.redhat.com (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a4.g.dreamhost.com (Postfix) with ESMTPSA id 43D5C8AAA8 for ; Tue, 3 Aug 2021 14:29:27 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a4 To: libc-alpha@sourceware.org Subject: [PATCH 0/5] getaddrinfo spaghetti cleanups Date: Wed, 4 Aug 2021 02:59:14 +0530 Message-Id: <20210803212919.3059194-1-siddhesh@sourceware.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Spam-Status: No, score=-3486.8 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Siddhesh Poyarekar via Libc-alpha From: Siddhesh Poyarekar Reply-To: Siddhesh Poyarekar Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" This series cleans up a bunch of confusing gotos in various functions in getaddrinfo. The gotos jump from one condition to another and in various directions, making code quite hard to read. Siddhesh Poyarekar (5): gaiconf_init: Refactor some bits for readability gai_init: Avoid jumping from if condition to its else counterpart getaddrinfo: Refactor code for readability gaih_inet: Consolidate got_port code gaih_inet: Make process_list label into a function sysdeps/posix/getaddrinfo.c | 1067 ++++++++++++++++++----------------- 1 file changed, 542 insertions(+), 525 deletions(-)