Message ID | 20210622051202.4155709-1-siddhesh@sourceware.org |
---|---|
Headers |
Return-Path: <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4354C393D012 for <patchwork@sourceware.org>; Tue, 22 Jun 2021 05:12:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4354C393D012 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1624338766; bh=i2GOtgZDHVuTxOmwV2LcZxvXngFR069PsYkvXxrFYAo=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=osIJDPICuVpA7AdKGpTeWElCnf4nPLyBawD2RWPHkeV8PwfjrvigXAxiFuNEJN2mT wuQP9jWsRWc2Tyoy0KQOl83kBFOwsYRKqPSZe4AjOoJqWJGqFfjpkrwQD7m9UlGUot 626/GC7K/bxGmQuvgNdN/XhasL4lTes4pwfaBv9g= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from olivedrab.birch.relay.mailchannels.net (olivedrab.birch.relay.mailchannels.net [23.83.209.135]) by sourceware.org (Postfix) with ESMTPS id 1F8DF385501B for <libc-alpha@sourceware.org>; Tue, 22 Jun 2021 05:12:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1F8DF385501B X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id F1FFA922D87 for <libc-alpha@sourceware.org>; Tue, 22 Jun 2021 05:12:22 +0000 (UTC) Received: from pdx1-sub0-mail-a46.g.dreamhost.com (100-96-133-115.trex.outbound.svc.cluster.local [100.96.133.115]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 6C01C92285E for <libc-alpha@sourceware.org>; Tue, 22 Jun 2021 05:12:22 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a46.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.133.115 (trex/6.3.3); Tue, 22 Jun 2021 05:12:22 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Coil-Towering: 64be44a826de70dc_1624338742655_1457498220 X-MC-Loop-Signature: 1624338742655:3347807728 X-MC-Ingress-Time: 1624338742654 Received: from pdx1-sub0-mail-a46.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a46.g.dreamhost.com (Postfix) with ESMTP id 30BDB880B4 for <libc-alpha@sourceware.org>; Mon, 21 Jun 2021 22:12:22 -0700 (PDT) Received: from rhbox.intra.reserved-bit.com (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a46.g.dreamhost.com (Postfix) with ESMTPSA id DFF2A7F50D for <libc-alpha@sourceware.org>; Mon, 21 Jun 2021 22:12:20 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a46 To: libc-alpha@sourceware.org Subject: [PATCH v2 0/6] gconv configuration parsing cleanups Date: Tue, 22 Jun 2021 10:41:56 +0530 Message-Id: <20210622051202.4155709-1-siddhesh@sourceware.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3487.1 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: Siddhesh Poyarekar via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Siddhesh Poyarekar <siddhesh@sourceware.org> Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org> |
Series |
gconv configuration parsing cleanups
|
|
Message
Siddhesh Poyarekar
June 22, 2021, 5:11 a.m. UTC
This patchset consolidates the file parsing in gconv_conf and iconvconfig into a single file gconv_parseconfdir. Also, add a NEWS item to mention gconv-modules.d since it is a user visible change. Changes from v1: - Updated 4/6 to fix dirlen increment and add unused attribute. Siddhesh Poyarekar (6): iconv: Remove alloca use in gconv-modules configuration parsing gconv_conf: Remove unused variables gconv_conf: Split out configuration file processing iconvconfig: Use common gconv module parsing function Handle DT_UNKNOWN in gconv-modules.d Add NEWS item for gconv-modules.d change NEWS | 8 ++ iconv/gconv_conf.c | 142 ++----------------------------- iconv/gconv_parseconfdir.h | 168 +++++++++++++++++++++++++++++++++++++ iconv/iconvconfig.c | 123 +++------------------------ 4 files changed, 197 insertions(+), 244 deletions(-) create mode 100644 iconv/gconv_parseconfdir.h
Comments
I'm now getting an assertion failure on all big-endian platforms. https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:glibc/glibc:testsuite/p/ppc https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:glibc/glibc:testsuite/p/ppc64 https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:glibc/glibc:testsuite/s/s390x msgfmt: gconv_builtin.c:70: __gconv_get_builtin_trans: Assertion `cnt < sizeof (map) / sizeof (map[0])' failed. Andreas.
On 6/24/21 2:16 PM, Andreas Schwab wrote: > I'm now getting an assertion failure on all big-endian platforms. > > https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:glibc/glibc:testsuite/p/ppc > https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:glibc/glibc:testsuite/p/ppc64 > https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:glibc/glibc:testsuite/s/s390x > > msgfmt: gconv_builtin.c:70: __gconv_get_builtin_trans: Assertion `cnt < sizeof (map) / sizeof (map[0])' failed. I'll take a look. Were you able to figure out which of the tests threw this assertion? Thanks, Siddhesh
On Jun 24 2021, Siddhesh Poyarekar wrote: > I'll take a look. Were you able to figure out which of the tests threw > this assertion? It's msgfmt. Andreas.
On 6/24/21 2:53 PM, Andreas Schwab wrote: > On Jun 24 2021, Siddhesh Poyarekar wrote: > >> I'll take a look. Were you able to figure out which of the tests threw >> this assertion? > > It's msgfmt. Ahh, so it's failing in the installed glibc, i.e. you mean the installed glibc has these patches already? I'll see if I can reproduce this in Fedora. Siddhesh
On Jun 24 2021, Siddhesh Poyarekar wrote: > Ahh, so it's failing in the installed glibc, i.e. you mean the installed > glibc has these patches already? Yes, the testsuite build is run with the just built glibc in the build environment. I couldn't reproduce the error with the testrun.sh script. Andreas.
On 6/24/21 9:16 PM, Andreas Schwab wrote: > On Jun 24 2021, Siddhesh Poyarekar wrote: > >> Ahh, so it's failing in the installed glibc, i.e. you mean the installed >> glibc has these patches already? > > Yes, the testsuite build is run with the just built glibc in the build > environment. I couldn't reproduce the error with the testrun.sh script. Me neither, even with bare elf/ld.so so that it picks the system gconv_path. I've got a build going now, so I'll see what I can find. Siddhesh