Message ID | 20210208214936.1502047-1-adhemerval.zanella@linaro.org |
---|---|
Headers |
Return-Path: <libc-alpha-bounces@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D2797388C022; Mon, 8 Feb 2021 21:49:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D2797388C022 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1612820987; bh=ZwLMMFL6Z6SYlchbayfgmPiS1jbrUjdg+ooivtpkU08=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=bAgQcDDRoW8G2/iqRByX6HiAj1JvZaigyrAInXV1FqzhT6mDhCot4Diound98fo7S n52DjSV+eKaI9UAjcs6nhVW5/evWST4YUd0NuTUsq2x4AwsvnqObgRFkNV7ZbeGGuL m04Ua4kuz1qqzlX8Z9+w0Vqgglzj/X+o5GkVwZ/U= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) by sourceware.org (Postfix) with ESMTPS id 189B9386F033 for <libc-alpha@sourceware.org>; Mon, 8 Feb 2021 21:49:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 189B9386F033 Received: by mail-qt1-x831.google.com with SMTP id e15so11506342qte.9 for <libc-alpha@sourceware.org>; Mon, 08 Feb 2021 13:49:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZwLMMFL6Z6SYlchbayfgmPiS1jbrUjdg+ooivtpkU08=; b=ugLhuBywvcJLVE1wBmadwnuR1VW11G2obeW+tkEVxNSsHQeNmDLkkjAcGvixvJ5t8M zHZUOGSNrxKfw1uLXmax6V4rF5qVuyCdkOyoy8GpUvz/2Tw3VrhexwHLWBKpDyhGchFS xrnuk9FRkVtTC4y/7FQ6nXeZjINHNjdmJWiPrhVK6X7/hUgbPKGkrUr5BJD/D1BDYDEO gf5mLKztL0nKm/yxIU12p/oRHCsIGheQH6myeKparwsg+OcgwD40N0G37m1GC6ekf4hk 9sxuz8+LXYEwQW5gBV2vAvBNxXeV5B6JAUBQPBYmVZAu1A6QIzJgCeZ58enAQ7WoCOxy 7Www== X-Gm-Message-State: AOAM533RpfhoqTyEsShWzouZA7JWeinDnE6ywin2sHraIGTCUtZTpQmn huGg3W+fm+Aus/gocVsJp6CM2IvRM9M6aw== X-Google-Smtp-Source: ABdhPJzsLP/k7Rkeg4waAMHbbGAoHRHoLKEcU9V3pNFlYMSEc464rpef0tSpHZmGLEeG2hoLyvSlyg== X-Received: by 2002:ac8:ecd:: with SMTP id w13mr17257516qti.91.1612820984365; Mon, 08 Feb 2021 13:49:44 -0800 (PST) Received: from localhost.localdomain ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id e15sm12720078qtq.43.2021.02.08.13.49.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Feb 2021 13:49:44 -0800 (PST) To: libc-alpha@sourceware.org Subject: [PATCH 00/10] [f]stat[fs,vfs] consolidation Date: Mon, 8 Feb 2021 18:49:26 -0300 Message-Id: <20210208214936.1502047-1-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Adhemerval Zanella <adhemerval.zanella@linaro.org> Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces@sourceware.org> |
Series |
stat[fs,vfs] consolidation
|
|
Message
Adhemerval Zanella Netto
Feb. 8, 2021, 9:49 p.m. UTC
The recent thread from OpenRISC work [1] showed that even through after the stat refactor to add y2038 support, the default internals still do not set a saner default ABI. The 'generic' internal interface still assumes non-LFS support calls and sets both the kernel_stat.h and the statfs.h with this assumption. This is misleading and requires newer ports to override both definitions (as done by arc and riscv32). This a refactor set I intended to push and the idea is to make LFS only support as default. It requires to set XSTAT_IS_XSTAT64 to 1 and STATFS_IS_STATFS64 to __STATFS_MATCHES_STATFS64 (the STAT_IS_KERNEL_STAT is not really required for newer ports, only for older ones with non-LFS ABI). It allows to consolide the [f]stat[fs,vfs] using the same strategy done for stat functions, with alpha being the only outlier (and the hackery required to support moved to an alpha specific implementation). The final patch also removes a recent addition to the 'generic' folder (stat-check.c). My longer plan is to remove the 'generic' folder altogether, by consolidating the implementations, moving the outliers to arch-specific implementations, and setting a more saner default abi (that assumes LFS and 64-bit time). [1] https://sourceware.org/pipermail/libc-alpha/2021-January/122167.html Adhemerval Zanella (10): linux: Fix STATFS_IS_STATFS64 definition linux: Set default kernel_stat.h to LFS linux: Set LFS statfs as default linux: Consolidate fstatfs implementations linux: Consolidate statfs implementations linux: Consolidate fstatvfs implementations linux: Consolidate statvfs implementations linux: Consolidate internal_statvfs linux: Remove overflow.h linux: Remove stat-check.c include/sys/statfs.h | 7 +- include/sys/statvfs.h | 3 +- sysdeps/unix/sysv/linux/Makefile | 2 +- .../{generic/wordsize-32 => alpha}/fstatfs.c | 13 +--- sysdeps/unix/sysv/linux/alpha/fstatfs64.c | 52 ++++++++++++- sysdeps/unix/sysv/linux/alpha/fstatvfs.c | 1 - sysdeps/unix/sysv/linux/alpha/fstatvfs64.c | 1 - .../sysv/linux/alpha/internal_statvfs64.c | 1 - .../{generic/wordsize-32 => alpha}/statfs.c | 16 ++-- sysdeps/unix/sysv/linux/alpha/statfs64.c | 52 ++++++++++++- sysdeps/unix/sysv/linux/alpha/statvfs.c | 1 - sysdeps/unix/sysv/linux/alpha/statvfs64.c | 1 - sysdeps/unix/sysv/linux/alpha/syscalls.list | 4 - sysdeps/unix/sysv/linux/arc/kernel_stat.h | 27 ------- sysdeps/unix/sysv/linux/arm/kernel_stat.h | 40 ++++++++++ .../linux/{generic => csky}/bits/statfs.h | 11 --- .../sysv/linux/{riscv => csky}/kernel_stat.h | 12 ++- sysdeps/unix/sysv/linux/fstatat64.c | 12 +++ sysdeps/unix/sysv/linux/fstatfs.c | 62 +++++++++++++++ sysdeps/unix/sysv/linux/fstatfs64.c | 67 +++-------------- sysdeps/unix/sysv/linux/fstatvfs.c | 11 ++- sysdeps/unix/sysv/linux/fstatvfs64.c | 53 +++++-------- sysdeps/unix/sysv/linux/generic/Makefile | 2 +- sysdeps/unix/sysv/linux/generic/stat-check.c | 29 ------- .../sysv/linux/generic/wordsize-32/overflow.h | 69 ----------------- sysdeps/unix/sysv/linux/i386/kernel_stat.h | 40 ++++++++++ sysdeps/unix/sysv/linux/ia64/kernel_stat.h | 22 ------ sysdeps/unix/sysv/linux/internal_statvfs.c | 70 +++++++++++------ sysdeps/unix/sysv/linux/internal_statvfs.h | 8 +- sysdeps/unix/sysv/linux/internal_statvfs64.c | 4 - sysdeps/unix/sysv/linux/kernel_stat.h | 58 +++++--------- sysdeps/unix/sysv/linux/m68k/kernel_stat.h | 40 ++++++++++ sysdeps/unix/sysv/linux/mips/kernel_stat.h | 6 +- .../sysv/linux/mips/mips64/n64/fstatfs64.c | 1 - .../sysv/linux/mips/mips64/n64/statfs64.c | 1 - .../sysv/linux/mips/mips64/n64/syscalls.list | 3 - sysdeps/unix/sysv/linux/nios2/bits/statfs.h | 75 +++++++++++++++++++ .../linux/{generic => nios2}/kernel_stat.h | 18 ++--- .../linux/powerpc/powerpc64/kernel_stat.h | 22 ------ .../sysv/linux/s390/s390-32/kernel_stat.h | 40 ++++++++++ .../sysv/linux/s390/s390-64/kernel_stat.h | 22 ------ sysdeps/unix/sysv/linux/sh/kernel_stat.h | 40 ++++++++++ .../sysv/linux/sparc/sparc64/kernel_stat.h | 7 +- sysdeps/unix/sysv/linux/statfs.c | 61 +++++++++++++++ sysdeps/unix/sysv/linux/statfs64.c | 69 ++--------------- sysdeps/unix/sysv/linux/statvfs.c | 11 ++- sysdeps/unix/sysv/linux/statvfs64.c | 54 +++++-------- .../unix/sysv/linux/wordsize-64/fstatfs64.c | 1 - .../unix/sysv/linux/wordsize-64/fstatvfs.c | 5 -- .../unix/sysv/linux/wordsize-64/fstatvfs64.c | 1 - .../linux/wordsize-64/internal_statvfs64.c | 1 - .../unix/sysv/linux/wordsize-64/statfs64.c | 1 - sysdeps/unix/sysv/linux/wordsize-64/statvfs.c | 5 -- .../unix/sysv/linux/wordsize-64/statvfs64.c | 1 - .../unix/sysv/linux/wordsize-64/syscalls.list | 2 - sysdeps/unix/sysv/linux/x86_64/kernel_stat.h | 22 ------ sysdeps/unix/sysv/linux/xstatconv.c | 7 +- 57 files changed, 688 insertions(+), 579 deletions(-) rename sysdeps/unix/sysv/linux/{generic/wordsize-32 => alpha}/fstatfs.c (76%) delete mode 100644 sysdeps/unix/sysv/linux/alpha/fstatvfs.c delete mode 100644 sysdeps/unix/sysv/linux/alpha/fstatvfs64.c delete mode 100644 sysdeps/unix/sysv/linux/alpha/internal_statvfs64.c rename sysdeps/unix/sysv/linux/{generic/wordsize-32 => alpha}/statfs.c (72%) delete mode 100644 sysdeps/unix/sysv/linux/alpha/statvfs.c delete mode 100644 sysdeps/unix/sysv/linux/alpha/statvfs64.c delete mode 100644 sysdeps/unix/sysv/linux/arc/kernel_stat.h create mode 100644 sysdeps/unix/sysv/linux/arm/kernel_stat.h rename sysdeps/unix/sysv/linux/{generic => csky}/bits/statfs.h (79%) rename sysdeps/unix/sysv/linux/{riscv => csky}/kernel_stat.h (77%) create mode 100644 sysdeps/unix/sysv/linux/fstatfs.c delete mode 100644 sysdeps/unix/sysv/linux/generic/stat-check.c delete mode 100644 sysdeps/unix/sysv/linux/generic/wordsize-32/overflow.h create mode 100644 sysdeps/unix/sysv/linux/i386/kernel_stat.h delete mode 100644 sysdeps/unix/sysv/linux/ia64/kernel_stat.h delete mode 100644 sysdeps/unix/sysv/linux/internal_statvfs64.c create mode 100644 sysdeps/unix/sysv/linux/m68k/kernel_stat.h delete mode 100644 sysdeps/unix/sysv/linux/mips/mips64/n64/fstatfs64.c delete mode 100644 sysdeps/unix/sysv/linux/mips/mips64/n64/statfs64.c create mode 100644 sysdeps/unix/sysv/linux/nios2/bits/statfs.h rename sysdeps/unix/sysv/linux/{generic => nios2}/kernel_stat.h (71%) delete mode 100644 sysdeps/unix/sysv/linux/powerpc/powerpc64/kernel_stat.h create mode 100644 sysdeps/unix/sysv/linux/s390/s390-32/kernel_stat.h delete mode 100644 sysdeps/unix/sysv/linux/s390/s390-64/kernel_stat.h create mode 100644 sysdeps/unix/sysv/linux/sh/kernel_stat.h create mode 100644 sysdeps/unix/sysv/linux/statfs.c delete mode 100644 sysdeps/unix/sysv/linux/wordsize-64/fstatfs64.c delete mode 100644 sysdeps/unix/sysv/linux/wordsize-64/fstatvfs.c delete mode 100644 sysdeps/unix/sysv/linux/wordsize-64/fstatvfs64.c delete mode 100644 sysdeps/unix/sysv/linux/wordsize-64/internal_statvfs64.c delete mode 100644 sysdeps/unix/sysv/linux/wordsize-64/statfs64.c delete mode 100644 sysdeps/unix/sysv/linux/wordsize-64/statvfs.c delete mode 100644 sysdeps/unix/sysv/linux/wordsize-64/statvfs64.c delete mode 100644 sysdeps/unix/sysv/linux/x86_64/kernel_stat.h
Comments
On 2/8/21 4:49 PM, Adhemerval Zanella via Libc-alpha wrote: > The recent thread from OpenRISC work [1] showed that even through after > the stat refactor to add y2038 support, the default internals still do > not set a saner default ABI. > > The 'generic' internal interface still assumes non-LFS support calls > and sets both the kernel_stat.h and the statfs.h with this assumption. > This is misleading and requires newer ports to override both definitions > (as done by arc and riscv32). > > This a refactor set I intended to push and the idea is to make LFS only > support as default. It requires to set XSTAT_IS_XSTAT64 to 1 and > STATFS_IS_STATFS64 to __STATFS_MATCHES_STATFS64 (the STAT_IS_KERNEL_STAT > is not really required for newer ports, only for older ones with > non-LFS ABI). > > It allows to consolide the [f]stat[fs,vfs] using the same strategy done > for stat functions, with alpha being the only outlier (and the hackery > required to support moved to an alpha specific implementation). > > The final patch also removes a recent addition to the 'generic' folder > (stat-check.c). My longer plan is to remove the 'generic' folder > altogether, by consolidating the implementations, moving the outliers > to arch-specific implementations, and setting a more saner default abi > (that assumes LFS and 64-bit time). Overall I think this goes in the right direction, moving the old defaults to new defaults and flipping all the flags to match the newer defaults. I've given each patch a light review, and I think it helps cleanup the existing mess of code. > [1] https://sourceware.org/pipermail/libc-alpha/2021-January/122167.html > > Adhemerval Zanella (10): > linux: Fix STATFS_IS_STATFS64 definition > linux: Set default kernel_stat.h to LFS > linux: Set LFS statfs as default > linux: Consolidate fstatfs implementations > linux: Consolidate statfs implementations > linux: Consolidate fstatvfs implementations > linux: Consolidate statvfs implementations > linux: Consolidate internal_statvfs > linux: Remove overflow.h > linux: Remove stat-check.c > > include/sys/statfs.h | 7 +- > include/sys/statvfs.h | 3 +- > sysdeps/unix/sysv/linux/Makefile | 2 +- > .../{generic/wordsize-32 => alpha}/fstatfs.c | 13 +--- > sysdeps/unix/sysv/linux/alpha/fstatfs64.c | 52 ++++++++++++- > sysdeps/unix/sysv/linux/alpha/fstatvfs.c | 1 - > sysdeps/unix/sysv/linux/alpha/fstatvfs64.c | 1 - > .../sysv/linux/alpha/internal_statvfs64.c | 1 - > .../{generic/wordsize-32 => alpha}/statfs.c | 16 ++-- > sysdeps/unix/sysv/linux/alpha/statfs64.c | 52 ++++++++++++- > sysdeps/unix/sysv/linux/alpha/statvfs.c | 1 - > sysdeps/unix/sysv/linux/alpha/statvfs64.c | 1 - > sysdeps/unix/sysv/linux/alpha/syscalls.list | 4 - > sysdeps/unix/sysv/linux/arc/kernel_stat.h | 27 ------- > sysdeps/unix/sysv/linux/arm/kernel_stat.h | 40 ++++++++++ > .../linux/{generic => csky}/bits/statfs.h | 11 --- > .../sysv/linux/{riscv => csky}/kernel_stat.h | 12 ++- > sysdeps/unix/sysv/linux/fstatat64.c | 12 +++ > sysdeps/unix/sysv/linux/fstatfs.c | 62 +++++++++++++++ > sysdeps/unix/sysv/linux/fstatfs64.c | 67 +++-------------- > sysdeps/unix/sysv/linux/fstatvfs.c | 11 ++- > sysdeps/unix/sysv/linux/fstatvfs64.c | 53 +++++-------- > sysdeps/unix/sysv/linux/generic/Makefile | 2 +- > sysdeps/unix/sysv/linux/generic/stat-check.c | 29 ------- > .../sysv/linux/generic/wordsize-32/overflow.h | 69 ----------------- > sysdeps/unix/sysv/linux/i386/kernel_stat.h | 40 ++++++++++ > sysdeps/unix/sysv/linux/ia64/kernel_stat.h | 22 ------ > sysdeps/unix/sysv/linux/internal_statvfs.c | 70 +++++++++++------ > sysdeps/unix/sysv/linux/internal_statvfs.h | 8 +- > sysdeps/unix/sysv/linux/internal_statvfs64.c | 4 - > sysdeps/unix/sysv/linux/kernel_stat.h | 58 +++++--------- > sysdeps/unix/sysv/linux/m68k/kernel_stat.h | 40 ++++++++++ > sysdeps/unix/sysv/linux/mips/kernel_stat.h | 6 +- > .../sysv/linux/mips/mips64/n64/fstatfs64.c | 1 - > .../sysv/linux/mips/mips64/n64/statfs64.c | 1 - > .../sysv/linux/mips/mips64/n64/syscalls.list | 3 - > sysdeps/unix/sysv/linux/nios2/bits/statfs.h | 75 +++++++++++++++++++ > .../linux/{generic => nios2}/kernel_stat.h | 18 ++--- > .../linux/powerpc/powerpc64/kernel_stat.h | 22 ------ > .../sysv/linux/s390/s390-32/kernel_stat.h | 40 ++++++++++ > .../sysv/linux/s390/s390-64/kernel_stat.h | 22 ------ > sysdeps/unix/sysv/linux/sh/kernel_stat.h | 40 ++++++++++ > .../sysv/linux/sparc/sparc64/kernel_stat.h | 7 +- > sysdeps/unix/sysv/linux/statfs.c | 61 +++++++++++++++ > sysdeps/unix/sysv/linux/statfs64.c | 69 ++--------------- > sysdeps/unix/sysv/linux/statvfs.c | 11 ++- > sysdeps/unix/sysv/linux/statvfs64.c | 54 +++++-------- > .../unix/sysv/linux/wordsize-64/fstatfs64.c | 1 - > .../unix/sysv/linux/wordsize-64/fstatvfs.c | 5 -- > .../unix/sysv/linux/wordsize-64/fstatvfs64.c | 1 - > .../linux/wordsize-64/internal_statvfs64.c | 1 - > .../unix/sysv/linux/wordsize-64/statfs64.c | 1 - > sysdeps/unix/sysv/linux/wordsize-64/statvfs.c | 5 -- > .../unix/sysv/linux/wordsize-64/statvfs64.c | 1 - > .../unix/sysv/linux/wordsize-64/syscalls.list | 2 - > sysdeps/unix/sysv/linux/x86_64/kernel_stat.h | 22 ------ > sysdeps/unix/sysv/linux/xstatconv.c | 7 +- > 57 files changed, 688 insertions(+), 579 deletions(-) > rename sysdeps/unix/sysv/linux/{generic/wordsize-32 => alpha}/fstatfs.c (76%) > delete mode 100644 sysdeps/unix/sysv/linux/alpha/fstatvfs.c > delete mode 100644 sysdeps/unix/sysv/linux/alpha/fstatvfs64.c > delete mode 100644 sysdeps/unix/sysv/linux/alpha/internal_statvfs64.c > rename sysdeps/unix/sysv/linux/{generic/wordsize-32 => alpha}/statfs.c (72%) > delete mode 100644 sysdeps/unix/sysv/linux/alpha/statvfs.c > delete mode 100644 sysdeps/unix/sysv/linux/alpha/statvfs64.c > delete mode 100644 sysdeps/unix/sysv/linux/arc/kernel_stat.h > create mode 100644 sysdeps/unix/sysv/linux/arm/kernel_stat.h > rename sysdeps/unix/sysv/linux/{generic => csky}/bits/statfs.h (79%) > rename sysdeps/unix/sysv/linux/{riscv => csky}/kernel_stat.h (77%) > create mode 100644 sysdeps/unix/sysv/linux/fstatfs.c > delete mode 100644 sysdeps/unix/sysv/linux/generic/stat-check.c > delete mode 100644 sysdeps/unix/sysv/linux/generic/wordsize-32/overflow.h > create mode 100644 sysdeps/unix/sysv/linux/i386/kernel_stat.h > delete mode 100644 sysdeps/unix/sysv/linux/ia64/kernel_stat.h > delete mode 100644 sysdeps/unix/sysv/linux/internal_statvfs64.c > create mode 100644 sysdeps/unix/sysv/linux/m68k/kernel_stat.h > delete mode 100644 sysdeps/unix/sysv/linux/mips/mips64/n64/fstatfs64.c > delete mode 100644 sysdeps/unix/sysv/linux/mips/mips64/n64/statfs64.c > create mode 100644 sysdeps/unix/sysv/linux/nios2/bits/statfs.h > rename sysdeps/unix/sysv/linux/{generic => nios2}/kernel_stat.h (71%) > delete mode 100644 sysdeps/unix/sysv/linux/powerpc/powerpc64/kernel_stat.h > create mode 100644 sysdeps/unix/sysv/linux/s390/s390-32/kernel_stat.h > delete mode 100644 sysdeps/unix/sysv/linux/s390/s390-64/kernel_stat.h > create mode 100644 sysdeps/unix/sysv/linux/sh/kernel_stat.h > create mode 100644 sysdeps/unix/sysv/linux/statfs.c > delete mode 100644 sysdeps/unix/sysv/linux/wordsize-64/fstatfs64.c > delete mode 100644 sysdeps/unix/sysv/linux/wordsize-64/fstatvfs.c > delete mode 100644 sysdeps/unix/sysv/linux/wordsize-64/fstatvfs64.c > delete mode 100644 sysdeps/unix/sysv/linux/wordsize-64/internal_statvfs64.c > delete mode 100644 sysdeps/unix/sysv/linux/wordsize-64/statfs64.c > delete mode 100644 sysdeps/unix/sysv/linux/wordsize-64/statvfs.c > delete mode 100644 sysdeps/unix/sysv/linux/wordsize-64/statvfs64.c > delete mode 100644 sysdeps/unix/sysv/linux/x86_64/kernel_stat.h >
There is now a build failure for Hurd that looks like it probably comes from one of these changes. ../sysdeps/mach/hurd/fstatfs.c:31:24: error: 'fstatfs' aliased to undefined symbol '__fstatfs' 31 | weak_alias (__fstatfs, fstatfs) | ^~~~~~~ ./../include/libc-symbols.h:152:26: note: in definition of macro '_weak_alias' 152 | extern __typeof (name) aliasname __attribute__ ((weak, alias (#name))) \ | ^~~~~~~~~ ../sysdeps/mach/hurd/fstatfs.c:31:1: note: in expansion of macro 'weak_alias' 31 | weak_alias (__fstatfs, fstatfs) | ^~~~~~~~~~
On 2/11/21 3:08 PM, Joseph Myers wrote: > There is now a build failure for Hurd that looks like it probably comes > from one of these changes. > > ../sysdeps/mach/hurd/fstatfs.c:31:24: error: 'fstatfs' aliased to undefined symbol '__fstatfs' > 31 | weak_alias (__fstatfs, fstatfs) > | ^~~~~~~ > ./../include/libc-symbols.h:152:26: note: in definition of macro '_weak_alias' > 152 | extern __typeof (name) aliasname __attribute__ ((weak, alias (#name))) \ > | ^~~~~~~~~ > ../sysdeps/mach/hurd/fstatfs.c:31:1: note: in expansion of macro 'weak_alias' > 31 | weak_alias (__fstatfs, fstatfs) > | ^~~~~~~~~~ > I didn't run a full bmg build for reviewing. I should though just to review such refactoring. Adhemerval, Are you able to look into this?
On 11/02/2021 17:13, Carlos O'Donell wrote: > On 2/11/21 3:08 PM, Joseph Myers wrote: >> There is now a build failure for Hurd that looks like it probably comes >> from one of these changes. >> >> ../sysdeps/mach/hurd/fstatfs.c:31:24: error: 'fstatfs' aliased to undefined symbol '__fstatfs' >> 31 | weak_alias (__fstatfs, fstatfs) >> | ^~~~~~~ >> ./../include/libc-symbols.h:152:26: note: in definition of macro '_weak_alias' >> 152 | extern __typeof (name) aliasname __attribute__ ((weak, alias (#name))) \ >> | ^~~~~~~~~ >> ../sysdeps/mach/hurd/fstatfs.c:31:1: note: in expansion of macro 'weak_alias' >> 31 | weak_alias (__fstatfs, fstatfs) >> | ^~~~~~~~~~ >> > > I didn't run a full bmg build for reviewing. > > I should though just to review such refactoring. > > Adhemerval, Are you able to look into this? > Working on it, I forgot to fire up a hurd build for this one...
On 2/11/21 3:17 PM, Adhemerval Zanella wrote: > > > On 11/02/2021 17:13, Carlos O'Donell wrote: >> On 2/11/21 3:08 PM, Joseph Myers wrote: >>> There is now a build failure for Hurd that looks like it probably comes >>> from one of these changes. >>> >>> ../sysdeps/mach/hurd/fstatfs.c:31:24: error: 'fstatfs' aliased to undefined symbol '__fstatfs' >>> 31 | weak_alias (__fstatfs, fstatfs) >>> | ^~~~~~~ >>> ./../include/libc-symbols.h:152:26: note: in definition of macro '_weak_alias' >>> 152 | extern __typeof (name) aliasname __attribute__ ((weak, alias (#name))) \ >>> | ^~~~~~~~~ >>> ../sysdeps/mach/hurd/fstatfs.c:31:1: note: in expansion of macro 'weak_alias' >>> 31 | weak_alias (__fstatfs, fstatfs) >>> | ^~~~~~~~~~ >>> >> >> I didn't run a full bmg build for reviewing. >> >> I should though just to review such refactoring. >> >> Adhemerval, Are you able to look into this? >> > > Working on it, I forgot to fire up a hurd build for this one... DJ, /buildon build-many-glibcs ;-)