[v4,0/3] Support y2038 semctl_syscall()

Message ID 20200326163724.377351-1-alistair.francis@wdc.com
Series Support y2038 semctl_syscall() |


Alistair Francis March 26, 2020, 4:37 p.m. UTC
  This series does three things:
 1. Creates a bits/semid_ds_t.h file (in every arch) that specifies
    struct semid_ds so we no longer have to use macros defined in
 2. Removes the sem-pad.h file as it is no longer needed.
 3. Adds a new __semid_ds32 that is passed to the kernel (as part of
    a union) when running on 32-bit systems. If we are doing an
    IPC_STAT command then the 32-bit sem_{c,o}time{_high} values are
    combined to create a 64-bit value.

The semctl_syscall() function passes a union semun to the kernel. The
union includes struct semid_ds as a member. On 32-bit architectures the
Linux kernel provides a *_high version of the 32-bit sem_otime and
sem_ctime values. These can be combined to get a 64-bit version of the

This patch adjusts the struct semid_ds to support the *_high versions
of sem_otime and sem_ctime. For 32-bit systems with a 64-bit time_t
this can be used to get a 64-bit time from the two 32-bit values.

This series was tested by running:
  ./scripts/build-many-glibcs.py ... compilers
  ./scripts/build-many-glibcs.py ... glibcs
on my x86_64 machine.

I also ran make check on RV32 and I only see a total of 9 test failures.

 - Remove the __IPC_TIME64 macro
    - It was only used once and doesn't work if __IPC_64 is 0 (which is
      usually is)
 - Address failures pointed out by Vineet Gupta

Alistair Francis (3):
  bits/sem.h: Split out struct semid_ds
  semctl: Remove the sem-pad.h file
  sysv: linux: Pass 64-bit version of semctl syscall

 sysdeps/unix/sysv/linux/Makefile              |  3 +-
 sysdeps/unix/sysv/linux/bits/sem-pad.h        | 33 ----------
 sysdeps/unix/sysv/linux/bits/sem.h            | 26 +-------
 sysdeps/unix/sysv/linux/bits/semid_ds_t.h     | 61 +++++++++++++++++++
 sysdeps/unix/sysv/linux/hppa/bits/sem-pad.h   | 26 --------
 .../unix/sysv/linux/hppa/bits/semid_ds_t.h    | 61 +++++++++++++++++++
 sysdeps/unix/sysv/linux/mips/bits/sem-pad.h   | 24 --------
 .../unix/sysv/linux/mips/bits/semid_ds_t.h    | 45 ++++++++++++++
 .../unix/sysv/linux/powerpc/bits/sem-pad.h    | 26 --------
 .../unix/sysv/linux/powerpc/bits/semid_ds_t.h | 61 +++++++++++++++++++
 sysdeps/unix/sysv/linux/semctl.c              | 24 ++++++--
 sysdeps/unix/sysv/linux/sparc/bits/sem-pad.h  | 26 --------
 .../unix/sysv/linux/sparc/bits/semid_ds_t.h   | 61 +++++++++++++++++++
 sysdeps/unix/sysv/linux/x86/bits/sem-pad.h    | 24 --------
 sysdeps/unix/sysv/linux/x86/bits/semid_ds_t.h | 49 +++++++++++++++
 15 files changed, 362 insertions(+), 188 deletions(-)
 delete mode 100644 sysdeps/unix/sysv/linux/bits/sem-pad.h
 create mode 100644 sysdeps/unix/sysv/linux/bits/semid_ds_t.h
 delete mode 100644 sysdeps/unix/sysv/linux/hppa/bits/sem-pad.h
 create mode 100644 sysdeps/unix/sysv/linux/hppa/bits/semid_ds_t.h
 delete mode 100644 sysdeps/unix/sysv/linux/mips/bits/sem-pad.h
 create mode 100644 sysdeps/unix/sysv/linux/mips/bits/semid_ds_t.h
 delete mode 100644 sysdeps/unix/sysv/linux/powerpc/bits/sem-pad.h
 create mode 100644 sysdeps/unix/sysv/linux/powerpc/bits/semid_ds_t.h
 delete mode 100644 sysdeps/unix/sysv/linux/sparc/bits/sem-pad.h
 create mode 100644 sysdeps/unix/sysv/linux/sparc/bits/semid_ds_t.h
 delete mode 100644 sysdeps/unix/sysv/linux/x86/bits/sem-pad.h
 create mode 100644 sysdeps/unix/sysv/linux/x86/bits/semid_ds_t.h