From patchwork Fri Sep 12 23:29:11 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Evans X-Patchwork-Id: 2830 Received: (qmail 3903 invoked by alias); 12 Sep 2014 23:29:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 3828 invoked by uid 89); 12 Sep 2014 23:29:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oa0-f73.google.com Received: from mail-oa0-f73.google.com (HELO mail-oa0-f73.google.com) (209.85.219.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 12 Sep 2014 23:29:14 +0000 Received: by mail-oa0-f73.google.com with SMTP id jd19so229022oac.4 for ; Fri, 12 Sep 2014 16:29:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:cc:date:message-id:mime-version :content-type; bh=ExhVXXCq3mtRyXDg/XGOY6RZ5vkJRz1dMzWHIekE0wI=; b=JSk4SLyTLt7kKv8Ol3FqTAsO6hQmmFuDj05ddTabyHgzmQc5uIN0qCT263mzD3e3jQ w9GXEBMBBXN55ebSMOGHVUoqbbwLVgq9N85UWcJsZlI2vlh+zOs8L+/bNTqzlN6a/v8P 6Fn2mZKO88CjsF/JUtqykP5LBtJKozYPTPQBDn02vm5Lcufit3zFMSe7KRJkbgaQUBKP Y4j3vp6yyIk8ByMivcw7p81RpixC0xYlzmFQHRAZ1GCuM00MzrSnXd7cccMQ4vPSLYBm E7q6uNp8CVoL7DkHDUVSH2hVd/Iv1rTdK9Ltp8fvLeVeXUvC6RcmH6TYXdP26QNtTPA1 2Mrw== X-Gm-Message-State: ALoCoQmbq+5EMYbNHlPRWb3q9fDwMYkBms45sopmYKtgWHUF+iXFx+z0t6VNFjHiPLduwRJMU1sJ X-Received: by 10.43.155.134 with SMTP id li6mr6961479icc.3.1410564552642; Fri, 12 Sep 2014 16:29:12 -0700 (PDT) Received: from corpmail-nozzle1-1.hot.corp.google.com ([100.108.1.104]) by gmr-mx.google.com with ESMTPS id l45si255650yha.2.2014.09.12.16.29.12 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Sep 2014 16:29:12 -0700 (PDT) Received: from ruffy.mtv.corp.google.com ([172.17.128.44]) by corpmail-nozzle1-1.hot.corp.google.com with ESMTPS id rKGPKA50.1; Fri, 12 Sep 2014 16:29:12 -0700 From: Doug Evans To: gdb-patches@sourceware.org Subject: [PATCH] Allow DW_FORM_GNU_addr_index in Fission skeleton CUs cc: dblaikie@gmail.com, ccoutant@google.com Date: Fri, 12 Sep 2014 16:29:11 -0700 Message-ID: MIME-Version: 1.0 X-IsSubscribed: yes Hi. Way back when, I made DW_FORM_GNU_addr_index in Fission skeleton CUs an error. There's no need for this restriction, so this patch removes it. David, is this something you'd like to see in 7.8.1? It's safe enough for me to add it there. 2014-09-12 Doug Evans * dwarf2read.c (read_attribute_value): Allow DW_FORM_GNU_addr_index in Fission skeleton CUs. diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index be32309..430a945 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -16077,14 +16077,6 @@ read_attribute_value (const struct die_reader_specs *reader, info_ptr = read_attribute_value (reader, attr, form, info_ptr); break; case DW_FORM_GNU_addr_index: - if (reader->dwo_file == NULL) - { - /* For now flag a hard error. - Later we can turn this into a complaint. */ - error (_("Dwarf Error: %s found in non-DWO CU [in module %s]"), - dwarf_form_name (form), - bfd_get_filename (abfd)); - } DW_ADDR (attr) = read_addr_index_from_leb128 (cu, info_ptr, &bytes_read); info_ptr += bytes_read; break;