Remove unused variables in procfs.c etc.

Message ID yddwot3n1z1.fsf@CeBiTec.Uni-Bielefeld.DE
State New, archived

Commit Message

Rainer Orth Aug. 6, 2018, 11:55 a.m. UTC
  The recent patch to enable -Wunused-variable uncovered a couple of
instances in Solaris-specific files:

/vol/src/gnu/gdb/hg/master/dist/gdb/proc-api.c: In function ‘void _initialize_proc_api()’:
/vol/src/gnu/gdb/hg/master/dist/gdb/proc-api.c:422:28: error: unused variable ‘c’ [-Werror=unused-variable]
   struct cmd_list_element *c;

/vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c: In function ‘void procfs_init_inferior(target_ops*, int)’:
/vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c:2895:12: error: unused variable ‘signals’ [-Werror=unused-variable]
   sigset_t signals;
/vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c: In member function ‘virtual char* procfs_target::make_corefile_notes(bfd*, int*)’:
/vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c:3845:19: error: unused variable ‘old_chain’ [-Werror=unused-variable]
   struct cleanup *old_chain;
/vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c:3847:18: error: unused variable ‘fpregs’ [-Werror=unused-variable]
   gdb_fpregset_t fpregs;

Fixed as follows.  Tested on amd64-pc-solaris2.11, installed as obvious.



# HG changeset patch
# Parent  84125362cdb6fb98ee6e31d4d3bbc1e8214e21bc
Remove unused variables in procfs.c etc.

diff --git a/gdb/proc-api.c b/gdb/proc-api.c
--- a/gdb/proc-api.c
+++ b/gdb/proc-api.c
@@ -419,8 +419,6 @@  proc_prettyfprint_status (long flags, in
 _initialize_proc_api (void)
-  struct cmd_list_element *c;
   add_setshow_boolean_cmd ("procfs-trace", no_class, &procfs_trace, _("\
 Set tracing for /proc api calls."), _("\
 Show tracing for /proc api calls."), NULL,
diff --git a/gdb/procfs.c b/gdb/procfs.c
--- a/gdb/procfs.c
+++ b/gdb/procfs.c
@@ -2892,7 +2892,6 @@  static void
 procfs_init_inferior (struct target_ops *ops, int pid)
   procinfo *pi;
-  sigset_t signals;
   int fail;
   int lwpid;
@@ -3842,9 +3841,7 @@  find_stop_signal (void)
 char *
 procfs_target::make_corefile_notes (bfd *obfd, int *note_size)
-  struct cleanup *old_chain;
   gdb_gregset_t gregs;
-  gdb_fpregset_t fpregs;
   char fname[16] = {'\0'};
   char psargs[80] = {'\0'};
   procinfo *pi = find_procinfo_or_die ( (), 0);