From patchwork Mon Oct 29 09:34:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 29938 Received: (qmail 70953 invoked by alias); 29 Oct 2018 09:34:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 67123 invoked by uid 89); 29 Oct 2018 09:34:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy=Parent X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 29 Oct 2018 09:34:07 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 98A98EA3 for ; Mon, 29 Oct 2018 10:34:05 +0100 (CET) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 5w4bHZn-DiU3 for ; Mon, 29 Oct 2018 10:34:03 +0100 (CET) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 808E5EA2 for ; Mon, 29 Oct 2018 10:34:03 +0100 (CET) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id w9T9Y3B3004891; Mon, 29 Oct 2018 10:34:03 +0100 (MET) From: Rainer Orth To: gdb-patches@sourceware.org Subject: [OB PATH] Provide get_shell declaration in procfs.c Date: Mon, 29 Oct 2018 10:34:03 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes The Solaris build is currently broken: /vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c: In member function ‘virtual void procfs_target::create_inferior(const char*, const string&, char**, int)’: /vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c:3038:28: error: ‘get_shell’ was not declared in this scope const char *shell_file = get_shell (); ^~~~~~~~~ /vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c:3038:28: note: suggested alternative: ‘getusershell’ const char *shell_file = get_shell (); ^~~~~~~~~ getusershell While the Solaris buildbots noticed this, for some reason no mail was ever sent by the buildmaster. The following patch fixes this. Tested on amd64-pc-solaris2.11, installed on master. Rainer # HG changeset patch # Parent 3d302cff9ea7d827e06f221af07867dffe829434 Provide get_shell declaration in procfs.c diff --git a/gdb/procfs.c b/gdb/procfs.c --- a/gdb/procfs.c +++ b/gdb/procfs.c @@ -47,6 +47,7 @@ #include "procfs.h" #include "observable.h" #include "common/scoped_fd.h" +#include "common/pathstuff.h" /* This module provides the interface between GDB and the /proc file system, which is used on many versions of Unix