From patchwork Mon Sep 24 14:36:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 29524 Received: (qmail 26108 invoked by alias); 24 Sep 2018 14:43:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 26086 invoked by uid 89); 24 Sep 2018 14:43:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy=losing, managed, H*a:set, H*a:sender X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Sep 2018 14:43:36 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 97FD2DE2; Mon, 24 Sep 2018 16:36:06 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 0E4JnGBouNoA; Mon, 24 Sep 2018 16:36:04 +0200 (CEST) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id B0F05DE0; Mon, 24 Sep 2018 16:36:03 +0200 (CEST) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id w8OEa152029176; Mon, 24 Sep 2018 16:36:01 +0200 (MEST) From: Rainer Orth To: Sergio Durigan Junior Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Provide Solaris 11 buildbots References: <874lelw9r3.fsf@redhat.com> <877ejguuo0.fsf@redhat.com> <87fty4teps.fsf@redhat.com> <871s9ote89.fsf@redhat.com> Date: Mon, 24 Sep 2018 16:36:01 +0200 In-Reply-To: (Rainer Orth's message of "Thu, 20 Sep 2018 19:55:08 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes Hi Sergio, >>>> So, there were a few problems in the master.cfg file which prevented the >>>> builders to actually build GDB. I fixed them, and they're now >>>> processing the queue. However, the builds are failing. For example: >>>> >>>> https://gdb-build.sergiodj.net/builders/Solaris11-sparcv9-m64/builds/3/steps/compile%20gdb/logs/stdio >>>> >>>> This seems to be the problem you were talking about, regarding >>>> unittests/string_view-selftests.o. You mentioned that this breakage >>>> shouldn't happen if we don't use -D_GLIBCXX_DEBUG, right? Can you >>>> please take a look at this? >>> >>> until your --enable-unit-tests patch is in (when we can keep the default >>> options and just add --disable-unit-tests to the configure line), we'd >>> need to build with CFLAGS/CXXFLAGS=-g -O -D_GLIBCXX_DEBUG until PR >>> build/23676 is resolved. That's what worked for me locally. >> >> Ah, I thought that if we didn't use "-g -D_GLIBCXX_DEBUG", then the >> build would be OK. > > That's what I tried first when I encountered the problem here. However, > even the minimal testcase in the PR fails with just -g alone. > > Could you please try if the following patch allows the build to succeed? it seems we managed to mess up the configure flags badly here: right now the buildbots are configured with just CFLAGS/CXXFLAGS=-m64, nothing more. I hope the following patch should fix things: * There's no need for disable_default_compilation_flags = True: the default works just fine, we only need to add -O at the moment. Isn't it enough to do this once in RunTestGDBSolaris_Common? * Obviously the -m64 needs to be appended in RunTestGDBPlainSolaris_c64 to both CFLAGS and CXXFLAGS to avoid losing the -O above. * Not in the patch, but wouldn't it be enough to set enable_targets_all, make_command, and run_testsuite only once in RunTestGDBSolaris_Common? Thanks. Rainer diff --git a/master.cfg b/master.cfg --- a/master.cfg +++ b/master.cfg @@ -1293,23 +1293,18 @@ class RunTestGDBSolaris_Common (BuildAnd # build/23676. This can be avoided either by performing a -g # -O build or with --disable-unit-tests from Sergio's proposed # patch. - self.disable_default_compilation_flags = True + self.extra_CFLAGS = [ '-O' ] + self.extra_CXXFLAGS = self.extra_CFLAGS BuildAndTestGDBFactory.__init__ (self, **kwargs) class RunTestGDBPlainSolaris_c64 (RunTestGDBSolaris_Common): """Compiling for Solaris""" def __init__ (self, **kwargs): - self.extra_CFLAGS = [ '-m64' ] - self.extra_CXXFLAGS = self.extra_CFLAGS self.enable_targets_all = False self.make_command = 'gmake' self.run_testsuite = False - # While a regular gdb build succeeds, a -g -D_GLIBCXX_DEBUG - # build as used by the buildbot fails as reported in PR - # build/23676. This can be avoided either by performing a -g - # -O build or with --disable-unit-tests from Sergio's proposed - # patch. - self.disable_default_compilation_flags = True + self.extra_CFLAGS.append ('-m64') + self.extra_CXXFLAGS.append ('-m64') BuildAndTestGDBFactory.__init__ (self, **kwargs) # All branches that are going to be watched.