From patchwork Fri Sep 22 14:44:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 23079 Received: (qmail 121335 invoked by alias); 22 Sep 2017 14:45:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 120017 invoked by uid 89); 22 Sep 2017 14:45:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-19.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, KAM_STOCKGEN, RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=06 X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Sep 2017 14:44:53 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 505AE246; Fri, 22 Sep 2017 16:44:51 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id EFzGyd2Vjl-r; Fri, 22 Sep 2017 16:44:40 +0200 (CEST) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id E9CA5245; Fri, 22 Sep 2017 16:44:39 +0200 (CEST) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id v8MEic8K001853; Fri, 22 Sep 2017 16:44:38 +0200 (MEST) From: Rainer Orth To: Pedro Alves Cc: Andreas Schwab , gdb-patches@sourceware.org Subject: Re: Obsolete/remove Solaris < 10 [was: Re: Fix gdb 8.1 Solaris compilation] References: <47bb2956-5654-0ce3-26dd-9f6b76ff6e08@redhat.com> Date: Fri, 22 Sep 2017 16:44:38 +0200 In-Reply-To: <47bb2956-5654-0ce3-26dd-9f6b76ff6e08@redhat.com> (Pedro Alves's message of "Thu, 21 Sep 2017 15:39:50 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (usg-unix-v) MIME-Version: 1.0 Hi Pedro, > On 09/21/2017 03:30 PM, Rainer Orth wrote: > >> This bad interaction between gnulib and fixed Solaris 9 headers may be >> fixable, but even trying to seems like a total waste of time. >> >> How is obsoletion/removal handled in gdb? In gcc, in one release a >> target is obsoleted and trying to build it yields an error which can be >> overridden with --enable-obsolete. Unless someone steps up to continue >> maintenance, the code is removed in the next release. > > GDB is more aggressive: > > https://sourceware.org/gdb/wiki/Internals%20Obsoleting-code > > For Solaris, I believe it's been a while that the only maintenance > we've seen comes from you. Which kind of makes you the de-facto > maintainer. :-) Since gcc obsoleted Solaris 9 years ago, and nobody I feared that much ;-) > all these years stepped forward, I think we should be able to just drop > it. I think you've proposed this in the past, even. I very Indeed: I found a line or two of notes about it. Must have been in the context of removing support for unstructured /proc in procfs.c and friends. I've dusted off and completed that patch as well... > much doubt anyone would step forward this time. Indeed. I've opened a tracking PR gdb/22185 and produced a first patch. It will need a bit more testing (especially on Linux which also uses proc-service.c), but it's basically straightforward. Rainer # HG changeset patch # Parent 5123ae285cd10f18efd6d5db4a75bc4989514ef1 Remove support for Solaris < 10 (PR gdb/22185) diff --git a/gdb/NEWS b/gdb/NEWS --- a/gdb/NEWS +++ b/gdb/NEWS @@ -115,6 +115,10 @@ FreeBSD/aarch64 aarch64*-*-freebsd* FreeBSD/aarch64 aarch64*-*-freebsd* +* Removed targets and native configurations + +Solaris 2.0-9 i?86-*-solaris2.[0-9], sparc*-*-solaris2.[0-9] + *** Changes in GDB 8.0 * GDB now supports access to the PKU register on GNU/Linux. The register is diff --git a/gdb/configure.ac b/gdb/configure.ac --- a/gdb/configure.ac +++ b/gdb/configure.ac @@ -508,13 +508,6 @@ esac # We might need to link with -lm; most simulators need it. AC_CHECK_LIB(m, main) -# We need to link with -lw to get `wctype' on Solaris before Solaris -# 2.6. Solaris 2.6 and beyond have this function in libc, and have a -# libw that some versions of the GNU linker cannot hanle (GNU ld 2.9.1 -# is known to have this problem). Therefore we avoid libw if we can. -AC_CHECK_FUNC(wctype, [], - [AC_CHECK_LIB(w, wctype)]) - # Some systems (e.g. Solaris) have `gethostbyname' in libnsl. AC_SEARCH_LIBS(gethostbyname, nsl) @@ -1308,17 +1301,6 @@ AC_CHECK_HEADERS(sys/user.h, [], [], #endif ]) -# On Solaris 2.[789], we need to define _MSE_INT_H to avoid a clash -# between and that would cause AC_CHECK_HEADERS to -# think that we don't have if we're using GCC. -case $host_os in - solaris2.[[789]]) - if test "$GCC" = yes; then - AC_DEFINE(_MSE_INT_H, 1, - [Define to 1 to avoid a clash between and on - Solaris 2.[789] when using GCC. ]) - fi ;; -esac AC_CHECK_HEADERS(curses.h cursesX.h ncurses.h ncurses/ncurses.h ncurses/term.h) AC_CHECK_HEADERS(term.h, [], [], [#if HAVE_CURSES_H @@ -1770,39 +1752,10 @@ dnl and not doing a canadian cross build if test ${build} = ${host} -a ${host} = ${target} ; then case ${host_os} in solaris*) - # See if thread_db library is around for Solaris thread debugging. - # Note that we must explicitly test for version 1 of the library - # because version 0 (present on Solaris 2.4 or earlier) doesn't have - # the same API. - AC_MSG_CHECKING(for Solaris thread debugging library) - if test -f /usr/lib/libthread_db.so.1 ; then - AC_MSG_RESULT(yes) - AC_DEFINE(HAVE_THREAD_DB_LIB, 1, - [Define if using Solaris thread debugging.]) - CONFIG_OBS="${CONFIG_OBS} sol-thread.o" - CONFIG_SRCS="${CONFIG_SRCS} sol-thread.c" - AC_CHECK_LIB(dl, dlopen) - CONFIG_LDFLAGS="${CONFIG_LDFLAGS} $RDYNAMIC" - # Sun randomly tweaked the prototypes in - # at one point. - AC_MSG_CHECKING(if is old) - AC_CACHE_VAL(gdb_cv_proc_service_is_old,[ - AC_TRY_COMPILE([ - #include - ps_err_e ps_pdwrite - (struct ps_prochandle*, psaddr_t, const void*, size_t); - ],, gdb_cv_proc_service_is_old=no, - gdb_cv_proc_service_is_old=yes) - ]) - AC_MSG_RESULT($gdb_cv_proc_service_is_old) - if test $gdb_cv_proc_service_is_old = yes; then - AC_DEFINE(PROC_SERVICE_IS_OLD, 1, - [Define if on solaris uses int instead of - size_t, and assorted other type changes.]) - fi - else - AC_MSG_RESULT(no) - fi + CONFIG_OBS="${CONFIG_OBS} sol-thread.o" + CONFIG_SRCS="${CONFIG_SRCS} sol-thread.c" + AC_CHECK_LIB(dl, dlopen) + CONFIG_LDFLAGS="${CONFIG_LDFLAGS} $RDYNAMIC" ;; aix*) AC_MSG_CHECKING(for AiX thread debugging library) diff --git a/gdb/configure.host b/gdb/configure.host --- a/gdb/configure.host +++ b/gdb/configure.host @@ -20,6 +20,7 @@ case $host in vax-*-netbsdelf*) ;; *-*-irix* | \ + *-*-solaris2.[01] | *-*-solaris2.[2-9]* | \ alpha*-*-osf* | \ alpha*-*-freebsd* | \ alpha*-*-kfreebsd*-gnu | \ @@ -113,9 +114,8 @@ i[34567]86-*-linux*) gdb_host=linux ;; i[34567]86-*-gnu*) gdb_host=i386gnu ;; i[3456]86-*-nto*) gdb_host=nto ;; i[34567]86-*-openbsd*) gdb_host=obsd ;; -i[34567]86-*-solaris2.1[0-9]* | x86_64-*-solaris2.1[0-9]*) - gdb_host=sol2-64 ;; -i[34567]86-*-solaris*) gdb_host=i386sol2 ;; +i[34567]86-*-solaris2* | x86_64-*-solaris2*) + gdb_host=sol2 ;; i[34567]86-*-cygwin*) gdb_host=cygwin ;; ia64-*-linux*) gdb_host=linux ;; diff --git a/gdb/configure.nat b/gdb/configure.nat --- a/gdb/configure.nat +++ b/gdb/configure.nat @@ -85,6 +85,11 @@ case ${gdb_host} in darwin) NATDEPFILES='fork-child.o fork-inferior.o darwin-nat.o \ darwin-nat-info.o' + ;; + sol2) + NATDEPFILES='fork-child.o fork-inferior.o \ + procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o' + HAVE_NATIVE_GCORE_HOST=1 ;; esac @@ -212,17 +217,6 @@ case ${gdb_host} in ;; esac ;; - i386sol2) - case ${gdb_host_cpu} in - i386) - # Host: Solaris x86 - NATDEPFILES='fork-child.o fork-inferior.o \ - i386-v4-nat.o i386-sol2-nat.o \ - procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o' - HAVE_NATIVE_GCORE_HOST=1 - ;; - esac - ;; linux) case ${gdb_host_cpu} in aarch64) @@ -461,24 +455,15 @@ case ${gdb_host} in ;; sol2) case ${gdb_host_cpu} in + i386) + # Host: Solaris x86_64 + NATDEPFILES="${NATDEPFILES} \ + amd64-nat.o i386-v4-nat.o i386-sol2-nat.o" + ;; sparc) # Host: Solaris SPARC & UltraSPARC NAT_FILE='nm-sol2.h' - NATDEPFILES='sparc-sol2-nat.o \ - fork-child.o fork-inferior.o \ - procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o' - HAVE_NATIVE_GCORE_HOST=1 - ;; - esac - ;; - sol2-64) - case ${gdb_host_cpu} in - i386) - # Host: Solaris x86_64 - NATDEPFILES='fork-child.o fork-inferior.o \ - amd64-nat.o i386-v4-nat.o i386-sol2-nat.o \ - procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o' - HAVE_NATIVE_GCORE_HOST=1 + NATDEPFILES="${NATDEPFILES} sparc-sol2-nat.o" ;; esac ;; diff --git a/gdb/configure.tgt b/gdb/configure.tgt --- a/gdb/configure.tgt +++ b/gdb/configure.tgt @@ -223,17 +223,12 @@ i[34567]86-*-nto*) i386-nto-tdep.o nto-tdep.o" build_gdbserver=yes ;; -i[34567]86-*-solaris2.1[0-9]* | x86_64-*-solaris2.1[0-9]*) +i[34567]86-*-solaris2* | x86_64-*-solaris2*) # Target: Solaris x86_64 gdb_target_obs="i386-tdep.o i386.o i387-tdep.o amd64-tdep.o amd64.o \ amd64-sol2-tdep.o i386-sol2-tdep.o sol2-tdep.o \ solib-svr4.o" ;; -i[34567]86-*-solaris*) - # Target: Solaris x86 - gdb_target_obs="i386-tdep.o i387-tdep.o i386-sol2-tdep.o sol2-tdep.o \ - i386.o solib-svr4.o" - ;; i[34567]86-*-linux*) # Target: Intel 386 running GNU/Linux gdb_target_obs="i386-tdep.o i386.o i386-linux-tdep.o \ @@ -591,12 +586,6 @@ sparc64-*-openbsd*) nbsd-tdep.o obsd-tdep.o bsd-uthread.o solib-svr4.o \ ravenscar-thread.o sparc-ravenscar-thread.o" ;; -sparc-*-solaris2.[0-6] | sparc-*-solaris2.[0-6].*) - # Target: Solaris SPARC - gdb_target_obs="sparc-tdep.o sparc-sol2-tdep.o sol2-tdep.o \ - solib-svr4.o \ - ravenscar-thread.o sparc-ravenscar-thread.o" - ;; sparc-*-solaris2* | sparcv9-*-solaris2* | sparc64-*-solaris2*) # Target: Solaris UltraSPARC gdb_target_obs="sparc64-tdep.o sparc64-sol2-tdep.o sparc-tdep.o \ diff --git a/gdb/proc-service.c b/gdb/proc-service.c --- a/gdb/proc-service.c +++ b/gdb/proc-service.c @@ -34,24 +34,6 @@ #include "gregset.h" -/* Fix-up some broken systems. */ - -/* The prototypes in are slightly different on older - systems. Compensate for the discrepancies. */ - -#ifdef PROC_SERVICE_IS_OLD -typedef const struct ps_prochandle *gdb_ps_prochandle_t; -typedef char *gdb_ps_read_buf_t; -typedef char *gdb_ps_write_buf_t; -typedef int gdb_ps_size_t; -#else -typedef struct ps_prochandle *gdb_ps_prochandle_t; -typedef void *gdb_ps_read_buf_t; -typedef const void *gdb_ps_write_buf_t; -typedef size_t gdb_ps_size_t; -#endif - - /* Helper functions. */ /* Convert a psaddr_t to a CORE_ADDR. */ @@ -107,7 +89,7 @@ ps_xfer_memory (const struct ps_prochand symbol is stored in SYM_ADDR. */ ps_err_e -ps_pglobal_lookup (gdb_ps_prochandle_t ph, const char *obj, +ps_pglobal_lookup (ps_prochandle_t ph, const char *obj, const char *name, psaddr_t *sym_addr) { struct inferior *inf = find_inferior_ptid (ph->ptid); @@ -129,8 +111,8 @@ ps_pglobal_lookup (gdb_ps_prochandle_t p them into BUF. */ ps_err_e -ps_pdread (gdb_ps_prochandle_t ph, psaddr_t addr, - gdb_ps_read_buf_t buf, gdb_ps_size_t size) +ps_pdread (ps_prochandle_t ph, psaddr_t addr, + ps_read_buf_t buf, ps_size_t size) { return ps_xfer_memory (ph, addr, (gdb_byte *) buf, size, 0); } @@ -138,8 +120,8 @@ ps_pdread (gdb_ps_prochandle_t ph, psadd /* Write SIZE bytes from BUF into the target process PH at address ADDR. */ ps_err_e -ps_pdwrite (gdb_ps_prochandle_t ph, psaddr_t addr, - gdb_ps_write_buf_t buf, gdb_ps_size_t size) +ps_pdwrite (ps_prochandle_t ph, psaddr_t addr, + ps_write_buf_t buf, ps_size_t size) { return ps_xfer_memory (ph, addr, (gdb_byte *) buf, size, 1); } @@ -148,7 +130,7 @@ ps_pdwrite (gdb_ps_prochandle_t ph, psad and store them in GREGSET. */ ps_err_e -ps_lgetregs (gdb_ps_prochandle_t ph, lwpid_t lwpid, prgregset_t gregset) +ps_lgetregs (ps_prochandle_t ph, lwpid_t lwpid, prgregset_t gregset) { ptid_t ptid = ptid_build (ptid_get_pid (ph->ptid), lwpid, 0); struct regcache *regcache @@ -164,7 +146,7 @@ ps_lgetregs (gdb_ps_prochandle_t ph, lwp from GREGSET. */ ps_err_e -ps_lsetregs (gdb_ps_prochandle_t ph, lwpid_t lwpid, const prgregset_t gregset) +ps_lsetregs (ps_prochandle_t ph, lwpid_t lwpid, const prgregset_t gregset) { ptid_t ptid = ptid_build (ptid_get_pid (ph->ptid), lwpid, 0); struct regcache *regcache @@ -180,8 +162,7 @@ ps_lsetregs (gdb_ps_prochandle_t ph, lwp process PH and store them in FPREGSET. */ ps_err_e -ps_lgetfpregs (gdb_ps_prochandle_t ph, lwpid_t lwpid, - gdb_prfpregset_t *fpregset) +ps_lgetfpregs (ps_prochandle_t ph, lwpid_t lwpid, gdb_prfpregset_t *fpregset) { ptid_t ptid = ptid_build (ptid_get_pid (ph->ptid), lwpid, 0); struct regcache *regcache @@ -197,7 +178,7 @@ ps_lgetfpregs (gdb_ps_prochandle_t ph, l process PH from FPREGSET. */ ps_err_e -ps_lsetfpregs (gdb_ps_prochandle_t ph, lwpid_t lwpid, +ps_lsetfpregs (ps_prochandle_t ph, lwpid_t lwpid, const gdb_prfpregset_t *fpregset) { ptid_t ptid = ptid_build (ptid_get_pid (ph->ptid), lwpid, 0); @@ -214,7 +195,7 @@ ps_lsetfpregs (gdb_ps_prochandle_t ph, l -- not used on Solaris. */ pid_t -ps_getpid (gdb_ps_prochandle_t ph) +ps_getpid (ps_prochandle_t ph) { return ptid_get_pid (ph->ptid); } diff --git a/gdb/sol-thread.c b/gdb/sol-thread.c --- a/gdb/sol-thread.c +++ b/gdb/sol-thread.c @@ -700,34 +700,6 @@ sol_thread_alive (struct target_ops *ops /* These routines implement the lower half of the thread_db interface, i.e. the ps_* routines. */ -/* Various versions of have slightly different - function prototypes. In particular, we have - - NEWER OLDER - struct ps_prochandle * const struct ps_prochandle * - void* char* - const void* char* - int size_t - - Which one you have depends on the Solaris version and what patches - you've applied. On the theory that there are only two major - variants, we have configure check the prototype of ps_pdwrite (), - and use that info to make appropriate typedefs here. */ - -#ifdef PROC_SERVICE_IS_OLD -typedef const struct ps_prochandle *gdb_ps_prochandle_t; -typedef char *gdb_ps_read_buf_t; -typedef char *gdb_ps_write_buf_t; -typedef int gdb_ps_size_t; -typedef psaddr_t gdb_ps_addr_t; -#else -typedef struct ps_prochandle *gdb_ps_prochandle_t; -typedef void *gdb_ps_read_buf_t; -typedef const void *gdb_ps_write_buf_t; -typedef size_t gdb_ps_size_t; -typedef psaddr_t gdb_ps_addr_t; -#endif - /* The next four routines are called by libthread_db to tell us to stop and stop a particular process or lwp. Since GDB ensures that these are all stopped by the time we call anything in thread_db, @@ -736,7 +708,7 @@ typedef psaddr_t gdb_ps_addr_t; /* Process stop. */ ps_err_e -ps_pstop (gdb_ps_prochandle_t ph) +ps_pstop (ps_prochandle_t ph) { return PS_OK; } @@ -744,7 +716,7 @@ ps_pstop (gdb_ps_prochandle_t ph) /* Process continue. */ ps_err_e -ps_pcontinue (gdb_ps_prochandle_t ph) +ps_pcontinue (ps_prochandle_t ph) { return PS_OK; } @@ -752,7 +724,7 @@ ps_pcontinue (gdb_ps_prochandle_t ph) /* LWP stop. */ ps_err_e -ps_lstop (gdb_ps_prochandle_t ph, lwpid_t lwpid) +ps_lstop (ps_prochandle_t ph, lwpid_t lwpid) { return PS_OK; } @@ -760,7 +732,7 @@ ps_lstop (gdb_ps_prochandle_t ph, lwpid_ /* LWP continue. */ ps_err_e -ps_lcontinue (gdb_ps_prochandle_t ph, lwpid_t lwpid) +ps_lcontinue (ps_prochandle_t ph, lwpid_t lwpid) { return PS_OK; } @@ -768,8 +740,8 @@ ps_lcontinue (gdb_ps_prochandle_t ph, lw /* Looks up the symbol LD_SYMBOL_NAME in the debugger's symbol table. */ ps_err_e -ps_pglobal_lookup (gdb_ps_prochandle_t ph, const char *ld_object_name, - const char *ld_symbol_name, gdb_ps_addr_t *ld_symbol_addr) +ps_pglobal_lookup (ps_prochandle_t ph, const char *ld_object_name, + const char *ld_symbol_name, ps_addr_t *ld_symbol_addr) { struct bound_minimal_symbol ms; @@ -784,7 +756,7 @@ ps_pglobal_lookup (gdb_ps_prochandle_t p /* Common routine for reading and writing memory. */ static ps_err_e -rw_common (int dowrite, const struct ps_prochandle *ph, gdb_ps_addr_t addr, +rw_common (int dowrite, const struct ps_prochandle *ph, ps_addr_t addr, gdb_byte *buf, int size) { int ret; @@ -819,8 +791,8 @@ rw_common (int dowrite, const struct ps_ /* Copies SIZE bytes from target process .data segment to debugger memory. */ ps_err_e -ps_pdread (gdb_ps_prochandle_t ph, gdb_ps_addr_t addr, - gdb_ps_read_buf_t buf, gdb_ps_size_t size) +ps_pdread (ps_prochandle_t ph, ps_addr_t addr, + ps_read_buf_t buf, ps_size_t size) { return rw_common (0, ph, addr, (gdb_byte *) buf, size); } @@ -828,8 +800,8 @@ ps_pdread (gdb_ps_prochandle_t ph, gdb_p /* Copies SIZE bytes from debugger memory .data segment to target process. */ ps_err_e -ps_pdwrite (gdb_ps_prochandle_t ph, gdb_ps_addr_t addr, - gdb_ps_write_buf_t buf, gdb_ps_size_t size) +ps_pdwrite (ps_prochandle_t ph, ps_addr_t addr, + ps_write_buf_t buf, ps_size_t size) { return rw_common (1, ph, addr, (gdb_byte *) buf, size); } @@ -837,8 +809,8 @@ ps_pdwrite (gdb_ps_prochandle_t ph, gdb_ /* Copies SIZE bytes from target process .text segment to debugger memory. */ ps_err_e -ps_ptread (gdb_ps_prochandle_t ph, gdb_ps_addr_t addr, - gdb_ps_read_buf_t buf, gdb_ps_size_t size) +ps_ptread (ps_prochandle_t ph, ps_addr_t addr, + ps_read_buf_t buf, ps_size_t size) { return rw_common (0, ph, addr, (gdb_byte *) buf, size); } @@ -846,8 +818,8 @@ ps_ptread (gdb_ps_prochandle_t ph, gdb_p /* Copies SIZE bytes from debugger memory .text segment to target process. */ ps_err_e -ps_ptwrite (gdb_ps_prochandle_t ph, gdb_ps_addr_t addr, - gdb_ps_write_buf_t buf, gdb_ps_size_t size) +ps_ptwrite (ps_prochandle_t ph, ps_addr_t addr, + ps_write_buf_t buf, ps_size_t size) { return rw_common (1, ph, addr, (gdb_byte *) buf, size); } @@ -855,7 +827,7 @@ ps_ptwrite (gdb_ps_prochandle_t ph, gdb_ /* Get general-purpose registers for LWP. */ ps_err_e -ps_lgetregs (gdb_ps_prochandle_t ph, lwpid_t lwpid, prgregset_t gregset) +ps_lgetregs (ps_prochandle_t ph, lwpid_t lwpid, prgregset_t gregset) { ptid_t ptid = ptid_build (ptid_get_pid (inferior_ptid), lwpid, 0); struct regcache *regcache @@ -870,7 +842,7 @@ ps_lgetregs (gdb_ps_prochandle_t ph, lwp /* Set general-purpose registers for LWP. */ ps_err_e -ps_lsetregs (gdb_ps_prochandle_t ph, lwpid_t lwpid, +ps_lsetregs (ps_prochandle_t ph, lwpid_t lwpid, const prgregset_t gregset) { ptid_t ptid = ptid_build (ptid_get_pid (inferior_ptid), lwpid, 0); @@ -898,7 +870,7 @@ ps_plog (const char *fmt, ...) /* Get size of extra register set. Currently a noop. */ ps_err_e -ps_lgetxregsize (gdb_ps_prochandle_t ph, lwpid_t lwpid, int *xregsize) +ps_lgetxregsize (ps_prochandle_t ph, lwpid_t lwpid, int *xregsize) { return PS_OK; } @@ -906,7 +878,7 @@ ps_lgetxregsize (gdb_ps_prochandle_t ph, /* Get extra register set. Currently a noop. */ ps_err_e -ps_lgetxregs (gdb_ps_prochandle_t ph, lwpid_t lwpid, caddr_t xregset) +ps_lgetxregs (ps_prochandle_t ph, lwpid_t lwpid, caddr_t xregset) { return PS_OK; } @@ -914,7 +886,7 @@ ps_lgetxregs (gdb_ps_prochandle_t ph, lw /* Set extra register set. Currently a noop. */ ps_err_e -ps_lsetxregs (gdb_ps_prochandle_t ph, lwpid_t lwpid, caddr_t xregset) +ps_lsetxregs (ps_prochandle_t ph, lwpid_t lwpid, caddr_t xregset) { return PS_OK; } @@ -922,7 +894,7 @@ ps_lsetxregs (gdb_ps_prochandle_t ph, lw /* Get floating-point registers for LWP. */ ps_err_e -ps_lgetfpregs (gdb_ps_prochandle_t ph, lwpid_t lwpid, +ps_lgetfpregs (ps_prochandle_t ph, lwpid_t lwpid, prfpregset_t *fpregset) { ptid_t ptid = ptid_build (ptid_get_pid (inferior_ptid), lwpid, 0); @@ -938,7 +910,7 @@ ps_lgetfpregs (gdb_ps_prochandle_t ph, l /* Set floating-point regs for LWP. */ ps_err_e -ps_lsetfpregs (gdb_ps_prochandle_t ph, lwpid_t lwpid, +ps_lsetfpregs (ps_prochandle_t ph, lwpid_t lwpid, const prfpregset_t * fpregset) { ptid_t ptid = ptid_build (ptid_get_pid (inferior_ptid), lwpid, 0); @@ -957,7 +929,7 @@ ps_lsetfpregs (gdb_ps_prochandle_t ph, l (e.g. procfs) method, but this ought to work. */ ps_err_e -ps_pdmodel (gdb_ps_prochandle_t ph, int *data_model) +ps_pdmodel (ps_prochandle_t ph, int *data_model) { if (exec_bfd == 0) *data_model = PR_MODEL_UNKNOWN; @@ -978,7 +950,7 @@ ps_pdmodel (gdb_ps_prochandle_t ph, int of libthread_db would fail because of ps_lgetLDT being undefined. */ ps_err_e -ps_lgetLDT (gdb_ps_prochandle_t ph, lwpid_t lwpid, +ps_lgetLDT (ps_prochandle_t ph, lwpid_t lwpid, struct ssd *pldt) { /* NOTE: only used on Solaris, therefore OK to refer to procfs.c. */