From patchwork Thu Sep 20 17:55:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 29492 Received: (qmail 88955 invoked by alias); 20 Sep 2018 17:55:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 88858 invoked by uid 89); 20 Sep 2018 17:55:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy= X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Sep 2018 17:55:14 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 1DD75A5; Thu, 20 Sep 2018 19:55:12 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id xSu8ALPaNarY; Thu, 20 Sep 2018 19:55:09 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p54ACFE4B.dip0.t-ipconnect.de [84.172.254.75]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 5BCBAA4; Thu, 20 Sep 2018 19:55:09 +0200 (CEST) From: Rainer Orth To: Sergio Durigan Junior Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Provide Solaris 11 buildbots References: <874lelw9r3.fsf@redhat.com> <877ejguuo0.fsf@redhat.com> <87fty4teps.fsf@redhat.com> <871s9ote89.fsf@redhat.com> Date: Thu, 20 Sep 2018 19:55:08 +0200 In-Reply-To: <871s9ote89.fsf@redhat.com> (Sergio Durigan Junior's message of "Thu, 20 Sep 2018 10:50:30 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes Hi Sergio, >>> So, there were a few problems in the master.cfg file which prevented the >>> builders to actually build GDB. I fixed them, and they're now >>> processing the queue. However, the builds are failing. For example: >>> >>> https://gdb-build.sergiodj.net/builders/Solaris11-sparcv9-m64/builds/3/steps/compile%20gdb/logs/stdio >>> >>> This seems to be the problem you were talking about, regarding >>> unittests/string_view-selftests.o. You mentioned that this breakage >>> shouldn't happen if we don't use -D_GLIBCXX_DEBUG, right? Can you >>> please take a look at this? >> >> until your --enable-unit-tests patch is in (when we can keep the default >> options and just add --disable-unit-tests to the configure line), we'd >> need to build with CFLAGS/CXXFLAGS=-g -O -D_GLIBCXX_DEBUG until PR >> build/23676 is resolved. That's what worked for me locally. > > Ah, I thought that if we didn't use "-g -D_GLIBCXX_DEBUG", then the > build would be OK. That's what I tried first when I encountered the problem here. However, even the minimal testcase in the PR fails with just -g alone. Could you please try if the following patch allows the build to succeed? Thanks. Rainer diff --git a/master.cfg b/master.cfg --- a/master.cfg +++ b/master.cfg @@ -1293,7 +1293,8 @@ class RunTestGDBSolaris_Common (BuildAnd # build/23676. This can be avoided either by performing a -g # -O build or with --disable-unit-tests from Sergio's proposed # patch. - self.disable_default_compilation_flags = True + self.extra_CFLAGS = [ '-O' ] + self.extra_CXXFLAGS = self.extra_CFLAGS BuildAndTestGDBFactory.__init__ (self, **kwargs) class RunTestGDBPlainSolaris_c64 (RunTestGDBSolaris_Common): @@ -1309,7 +1310,8 @@ class RunTestGDBPlainSolaris_c64 (RunTes # build/23676. This can be avoided either by performing a -g # -O build or with --disable-unit-tests from Sergio's proposed # patch. - self.disable_default_compilation_flags = True + self.extra_CFLAGS = [ '-O' ] + self.extra_CXXFLAGS = self.extra_CFLAGS BuildAndTestGDBFactory.__init__ (self, **kwargs) # Classes needed for ARM (running on Aarch64, on Yao's buildslave)