From patchwork Sun Oct 26 17:44:55 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Evans X-Patchwork-Id: 3380 Received: (qmail 27591 invoked by alias); 26 Oct 2014 17:45:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 27577 invoked by uid 89); 26 Oct 2014 17:45:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f52.google.com Received: from mail-pa0-f52.google.com (HELO mail-pa0-f52.google.com) (209.85.220.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 26 Oct 2014 17:45:45 +0000 Received: by mail-pa0-f52.google.com with SMTP id fa1so2310566pad.11 for ; Sun, 26 Oct 2014 10:45:43 -0700 (PDT) X-Received: by 10.68.111.161 with SMTP id ij1mr12420141pbb.10.1414345543463; Sun, 26 Oct 2014 10:45:43 -0700 (PDT) Received: from seba.sebabeach.org.gmail.com (173-13-178-50-sfba.hfc.comcastbusiness.net. [173.13.178.50]) by mx.google.com with ESMTPSA id yw3sm8768567pbc.88.2014.10.26.10.45.42 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 26 Oct 2014 10:45:42 -0700 (PDT) From: Doug Evans To: gdb-patches@sourceware.org Subject: [COMMITTED PATCH] Move block_found decl to symtab.h. Date: Sun, 26 Oct 2014 10:44:55 -0700 Message-ID: MIME-Version: 1.0 X-IsSubscribed: yes Hi. This is a minor cleanup that removes a FIXME. Ideally what we want is to remove/rework block_found instead of passing results back in a global. Another day ... Committed. 2014-10-26 Doug Evans * parser-defs.h (block_found): Move decl from here ... * symtab.h (block_found): ... to here. diff --git a/gdb/parser-defs.h b/gdb/parser-defs.h index e43b1ae..2ba6e05 100644 --- a/gdb/parser-defs.h +++ b/gdb/parser-defs.h @@ -67,11 +67,6 @@ extern CORE_ADDR expression_context_pc; we've encountered so far. */ extern const struct block *innermost_block; -/* The block in which the most recently discovered symbol was found. - FIXME: Should be declared along with lookup_symbol in symtab.h; is not - related specifically to parsing. */ -extern const struct block *block_found; - /* Number of arguments seen so far in innermost function call. */ extern int arglist_len; diff --git a/gdb/symtab.h b/gdb/symtab.h index 9d1aa98..73108f0 100644 --- a/gdb/symtab.h +++ b/gdb/symtab.h @@ -1011,6 +1011,10 @@ DEF_VEC_P (symtab_ptr); extern int currently_reading_symtab; +/* The block in which the most recently looked up symbol was found. */ + +extern const struct block *block_found; + /* symtab.c lookup functions */ extern const char multiple_symbols_ask[];