From patchwork Sat Nov 15 18:26:09 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Evans X-Patchwork-Id: 3769 Received: (qmail 32099 invoked by alias); 15 Nov 2014 18:27:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 32031 invoked by uid 89); 15 Nov 2014 18:27:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f176.google.com Received: from mail-pd0-f176.google.com (HELO mail-pd0-f176.google.com) (209.85.192.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 15 Nov 2014 18:27:02 +0000 Received: by mail-pd0-f176.google.com with SMTP id ft15so18550815pdb.7 for ; Sat, 15 Nov 2014 10:27:00 -0800 (PST) X-Received: by 10.70.119.70 with SMTP id ks6mr11605144pdb.80.1416076020806; Sat, 15 Nov 2014 10:27:00 -0800 (PST) Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53]) by mx.google.com with ESMTPSA id y11sm4237146pbt.23.2014.11.15.10.26.59 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 15 Nov 2014 10:27:00 -0800 (PST) From: Doug Evans To: Yao Qi Cc: "gdb-patches\@sourceware.org" Subject: Re: [PATCH 7/9] Rewrite lookup_static_symbol to use gdbarch routine References: <87d29cvqfu.fsf@codesourcery.com> <87y4rfjm9h.fsf@codesourcery.com> Date: Sat, 15 Nov 2014 10:26:09 -0800 In-Reply-To: (Doug Evans's message of "Fri, 14 Nov 2014 09:23:55 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-IsSubscribed: yes Doug Evans writes: > On Thu, Nov 13, 2014 at 4:52 AM, Yao Qi wrote: >> Doug Evans writes: >> >> Hi Doug, >> Sorry for the delayed response. >> >>> 2014-11-08 Doug Evans >>> >>> PR symtab/17564 >>> * gdb.base/symtab-search-order.exp: New file. >>> * gdb.base/symtab-search-order.c: New file. >>> * gdb.base/symtab-search-order-1.c: New file. >>> * gdb.base/symtab-search-order-shlib-1.c: New file. >> >> These new .c files need copyright headers. > > These files are so trivial, I left them out. > [The .exp file *does* have a copyright header.] > > I know the contribution checklist page mentions always adding them, > even if the GNU standards only require them for legally significant > headers. > It's not clear that that is intended to apply in particular cases such as these. > > [I can add them, but establishing some clarity would be nice.] Hi. To keep things moving along I added the copyright headers. However, I think we could be a bit more lax when it comes to such trivial testcases. GCC isn't this pedantic about it. diff --git a/gdb/testsuite/gdb.base/symtab-search-order-1.c b/gdb/testsuite/gdb.base/symtab-search-order-1.c index bff9b7a..317b0e7 100644 --- a/gdb/testsuite/gdb.base/symtab-search-order-1.c +++ b/gdb/testsuite/gdb.base/symtab-search-order-1.c @@ -1 +1,18 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2014 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + static int static_global = 23; diff --git a/gdb/testsuite/gdb.base/symtab-search-order-shlib-1.c b/gdb/testsuite/gdb.base/symtab-search-order-shlib-1.c index a23da5f..537be53 100644 --- a/gdb/testsuite/gdb.base/symtab-search-order-shlib-1.c +++ b/gdb/testsuite/gdb.base/symtab-search-order-shlib-1.c @@ -1,3 +1,20 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2014 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + static int static_global = 42; int diff --git a/gdb/testsuite/gdb.base/symtab-search-order.c b/gdb/testsuite/gdb.base/symtab-search-order.c index ab38db6..ea58957 100644 --- a/gdb/testsuite/gdb.base/symtab-search-order.c +++ b/gdb/testsuite/gdb.base/symtab-search-order.c @@ -1,3 +1,20 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2014 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + extern int shlib_1_func (void); int