From patchwork Tue Jun 21 11:29:22 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Arnez X-Patchwork-Id: 13274 Received: (qmail 125835 invoked by alias); 21 Jun 2016 11:29:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 125825 invoked by uid 89); 21 Jun 2016 11:29:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=sk:wmissin, sk:Wmissin, H*o:Research, S390 X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 21 Jun 2016 11:29:28 +0000 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u5LBTCAP094897 for ; Tue, 21 Jun 2016 07:29:26 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0b-001b2d01.pphosted.com with ESMTP id 23pygp3fe4-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 21 Jun 2016 07:29:26 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 21 Jun 2016 12:29:25 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 21 Jun 2016 12:29:23 +0100 X-IBM-Helo: d06dlp01.portsmouth.uk.ibm.com X-IBM-MailFrom: arnez@linux.vnet.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 465AA17D805D for ; Tue, 21 Jun 2016 12:30:39 +0100 (BST) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u5LBTMjP8061188 for ; Tue, 21 Jun 2016 11:29:22 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u5LBTMUs007515 for ; Tue, 21 Jun 2016 05:29:22 -0600 Received: from oc1027705133.ibm.com (dyn-9-152-212-53.boeblingen.de.ibm.com [9.152.212.53]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u5LBTMR1007493 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 21 Jun 2016 05:29:22 -0600 From: Andreas Arnez To: gdb-patches@sourceware.org Cc: Ulrich Weigand Subject: [COMMITTED PATCH] S390 gdbserver: Mark local funcs/vars as static Date: Tue, 21 Jun 2016 13:29:22 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16062111-0020-0000-0000-000001C5B87C X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16062111-0021-0000-0000-00001C775B5A Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-06-21_06:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606210134 X-IsSubscribed: yes Compiling with '-Wmissing-declarations' yields warnings in linux-s390-low.c. To fix this, mark appropriate functions as static. gdb/gdbserver/ChangeLog: * linux-s390-low.c (s390_emit_eq_goto): Mark function static. (s390_emit_ne_goto): Likewise. (s390_emit_lt_goto): Likewise. (s390_emit_le_goto): Likewise. (s390_emit_gt_goto): Likewise. (s390_emit_ge_goto): Likewise. (s390x_emit_eq_goto): Likewise. (s390x_emit_ne_goto): Likewise. (s390x_emit_lt_goto): Likewise. (s390x_emit_le_goto): Likewise. (s390x_emit_gt_goto): Likewise. (s390x_emit_ge_goto): Likewise. (s390_emit_ops_impl): Mark variable static. (s390x_emit_ops): Likewise. --- gdb/gdbserver/linux-s390-low.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/gdb/gdbserver/linux-s390-low.c b/gdb/gdbserver/linux-s390-low.c index f5a7d85..231b614 100644 --- a/gdb/gdbserver/linux-s390-low.c +++ b/gdb/gdbserver/linux-s390-low.c @@ -1970,7 +1970,7 @@ s390_emit_void_call_2 (CORE_ADDR fn, int arg1) /* The "emit_eq_goto" emit_ops method for s390. */ -void +static void s390_emit_eq_goto (int *offset_p, int *size_p) { static const unsigned char buf[] = { @@ -1990,7 +1990,7 @@ s390_emit_eq_goto (int *offset_p, int *size_p) /* The "emit_ne_goto" emit_ops method for s390. */ -void +static void s390_emit_ne_goto (int *offset_p, int *size_p) { static const unsigned char buf[] = { @@ -2010,7 +2010,7 @@ s390_emit_ne_goto (int *offset_p, int *size_p) /* The "emit_lt_goto" emit_ops method for s390. */ -void +static void s390_emit_lt_goto (int *offset_p, int *size_p) { static const unsigned char buf[] = { @@ -2038,7 +2038,7 @@ s390_emit_lt_goto (int *offset_p, int *size_p) /* The "emit_le_goto" emit_ops method for s390. */ -void +static void s390_emit_le_goto (int *offset_p, int *size_p) { static const unsigned char buf[] = { @@ -2066,7 +2066,7 @@ s390_emit_le_goto (int *offset_p, int *size_p) /* The "emit_gt_goto" emit_ops method for s390. */ -void +static void s390_emit_gt_goto (int *offset_p, int *size_p) { static const unsigned char buf[] = { @@ -2094,7 +2094,7 @@ s390_emit_gt_goto (int *offset_p, int *size_p) /* The "emit_ge_goto" emit_ops method for s390. */ -void +static void s390_emit_ge_goto (int *offset_p, int *size_p) { static const unsigned char buf[] = { @@ -2123,7 +2123,7 @@ s390_emit_ge_goto (int *offset_p, int *size_p) /* The "emit_ops" structure for s390. Named _impl to avoid name collision with s390_emit_ops function. */ -struct emit_ops s390_emit_ops_impl = +static struct emit_ops s390_emit_ops_impl = { s390_emit_prologue, s390_emit_epilogue, @@ -2580,7 +2580,7 @@ s390x_emit_void_call_2 (CORE_ADDR fn, int arg1) /* The "emit_eq_goto" emit_ops method for s390x. */ -void +static void s390x_emit_eq_goto (int *offset_p, int *size_p) { static const unsigned char buf[] = { @@ -2598,7 +2598,7 @@ s390x_emit_eq_goto (int *offset_p, int *size_p) /* The "emit_ne_goto" emit_ops method for s390x. */ -void +static void s390x_emit_ne_goto (int *offset_p, int *size_p) { static const unsigned char buf[] = { @@ -2616,7 +2616,7 @@ s390x_emit_ne_goto (int *offset_p, int *size_p) /* The "emit_lt_goto" emit_ops method for s390x. */ -void +static void s390x_emit_lt_goto (int *offset_p, int *size_p) { static const unsigned char buf[] = { @@ -2634,7 +2634,7 @@ s390x_emit_lt_goto (int *offset_p, int *size_p) /* The "emit_le_goto" emit_ops method for s390x. */ -void +static void s390x_emit_le_goto (int *offset_p, int *size_p) { static const unsigned char buf[] = { @@ -2652,7 +2652,7 @@ s390x_emit_le_goto (int *offset_p, int *size_p) /* The "emit_gt_goto" emit_ops method for s390x. */ -void +static void s390x_emit_gt_goto (int *offset_p, int *size_p) { static const unsigned char buf[] = { @@ -2670,7 +2670,7 @@ s390x_emit_gt_goto (int *offset_p, int *size_p) /* The "emit_ge_goto" emit_ops method for s390x. */ -void +static void s390x_emit_ge_goto (int *offset_p, int *size_p) { static const unsigned char buf[] = { @@ -2688,7 +2688,7 @@ s390x_emit_ge_goto (int *offset_p, int *size_p) /* The "emit_ops" structure for s390x. */ -struct emit_ops s390x_emit_ops = +static struct emit_ops s390x_emit_ops = { s390x_emit_prologue, s390x_emit_epilogue,