From patchwork Wed Mar 27 21:34:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 32031 Received: (qmail 102279 invoked by alias); 27 Mar 2019 21:35:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 100460 invoked by uid 89); 27 Mar 2019 21:35:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=unavailable version=3.3.1 spammy=HX-Languages-Length:2062 X-HELO: mail-wr1-f52.google.com Received: from mail-wr1-f52.google.com (HELO mail-wr1-f52.google.com) (209.85.221.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Mar 2019 21:35:06 +0000 Received: by mail-wr1-f52.google.com with SMTP id q1so20367884wrp.0 for ; Wed, 27 Mar 2019 14:35:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=fmqAE1hMARAf0mgBfDvMvkGK7WCfo9Cw+S0dfflZP8I=; b=cY8tI6tYAFckKjI2KnC+kKiJGQl2+3zA5saoBcXDSls463t4pKv2o2oHGje7HZDBzp Kkebvr3S2xE70K1v1GVXCoqdgdbI6aWf3r5xM36WKgcxTyngTYM5FpCuUA6FILNEAhtB AguKuhLd39vk+qb0eYqKqUO9w1SDHo9GlL5IJOSyeZsgFY9/0h/HlinmJ+0elKhp7ua3 i0RjKIIsDLrjLh+D7d0ALXkYgI0vMPETd0edkTsc1MAp9L/GcCcU0g2ybD0uCw/lATXe yOR43JXUBMzV+j6cFsU9WQ0pjCejn5xaUaiFmj9MLq8bKFcB5BRxLlOFtcvTs5DbfLRs u6hQ== Return-Path: Received: from localhost (host81-151-161-58.range81-151.btcentralplus.com. [81.151.161.58]) by smtp.gmail.com with ESMTPSA id o12sm8878886wrx.92.2019.03.27.14.35.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Mar 2019 14:35:03 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: kevinb@redhat.com, macro@linux-mips.org, brobecker@adacore.com, green@moxielogic.com, qiyao@sourceware.org, shorne@gmail.com, Andrew Burgess Subject: [PATCH 21/25] gdb/v850: Use default gdbarch methods where possible Date: Wed, 27 Mar 2019 21:34:17 +0000 Message-Id: In-Reply-To: References: In-Reply-To: References: X-IsSubscribed: yes Make use of the default gdbarch methods for gdbarch_dummy_id, gdbarch_unwind_pc, and gdbarch_unwind_sp where possible. I have not tested this change but, by inspecting the code, I believe the default methods are equivalent to the code being deleted. gdb/ChangeLog: * v850-tdep.c (v850_unwind_sp): Delete. (v850_unwind_pc): Delete. (v850_dummy_id): Delete. (v850_gdbarch_init): Don't register deleted functions with gdbarch. --- gdb/ChangeLog | 8 ++++++++ gdb/v850-tdep.c | 25 ------------------------- 2 files changed, 8 insertions(+), 25 deletions(-) diff --git a/gdb/v850-tdep.c b/gdb/v850-tdep.c index 4f3cc5e9e2b..4be63b1cb77 100644 --- a/gdb/v850-tdep.c +++ b/gdb/v850-tdep.c @@ -1326,28 +1326,6 @@ static const struct frame_unwind v850_frame_unwind = { default_frame_sniffer }; -static CORE_ADDR -v850_unwind_sp (struct gdbarch *gdbarch, struct frame_info *next_frame) -{ - return frame_unwind_register_unsigned (next_frame, - gdbarch_sp_regnum (gdbarch)); -} - -static CORE_ADDR -v850_unwind_pc (struct gdbarch *gdbarch, struct frame_info *next_frame) -{ - return frame_unwind_register_unsigned (next_frame, - gdbarch_pc_regnum (gdbarch)); -} - -static struct frame_id -v850_dummy_id (struct gdbarch *gdbarch, struct frame_info *this_frame) -{ - CORE_ADDR sp = get_frame_register_unsigned (this_frame, - gdbarch_sp_regnum (gdbarch)); - return frame_id_build (sp, get_frame_pc (this_frame)); -} - static CORE_ADDR v850_frame_base_address (struct frame_info *this_frame, void **this_cache) { @@ -1464,9 +1442,6 @@ v850_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) set_gdbarch_skip_prologue (gdbarch, v850_skip_prologue); set_gdbarch_frame_align (gdbarch, v850_frame_align); - set_gdbarch_unwind_sp (gdbarch, v850_unwind_sp); - set_gdbarch_unwind_pc (gdbarch, v850_unwind_pc); - set_gdbarch_dummy_id (gdbarch, v850_dummy_id); frame_base_set_default (gdbarch, &v850_frame_base); /* Hook in ABI-specific overrides, if they have been registered. */