From patchwork Fri Jan 6 10:25:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 62791 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4470C384F032 for ; Fri, 6 Jan 2023 10:28:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4470C384F032 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1673000906; bh=jcdgqCCodrkrGvXu/A1dTmdurdyIuJ6uFOGqjP8e6Zc=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=fEvVYfX3LOXdSZveIpZKrGar52Trsk/xG6ABnJEvrrKUXtOHfUHdvr+A43bkc/M1C JH3qiLNj0ECE0B1aSEHWdYsqrfJAxBIETu8OfVWXCe6MdIb3Krusr7LwdKdGq+vRyA t7w/bzfuZsExBDOaburwWUBs1hyJIf4DvMsq8D4M= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C5CC03857B93 for ; Fri, 6 Jan 2023 10:26:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C5CC03857B93 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-356-hZV69JQGOFaFbRalfxIRVw-1; Fri, 06 Jan 2023 05:26:14 -0500 X-MC-Unique: hZV69JQGOFaFbRalfxIRVw-1 Received: by mail-ed1-f71.google.com with SMTP id z20-20020a05640240d400b0047028edd264so955010edb.20 for ; Fri, 06 Jan 2023 02:26:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jcdgqCCodrkrGvXu/A1dTmdurdyIuJ6uFOGqjP8e6Zc=; b=F3k/RgMF4dKXEhFCfNWXsECa1cWgNDypr05lbSqsmGqNvK6g3udymknDJyHRXtSX6n P2HAna7+yOKQ/xEVtC0wYOwLEArCVIepoe9JnM71vi9BxY5i1DzaRaRU52C60W3gf0fV qXgXQvaRHwD+d+hZwPreX8OoLzw6I29tx3lpzFgiBUqR37CAfuR5kryH/fcPHQ0ZFYqe JZPv7sN7+xqbYGqmDlV8/Yx9ylCr/XY0yc89TJYCxVAWrcOxsDBgOpIZYEpFLZ6tEhd1 uhEjhu7GRlq1IBUvU5NahIVXmv5UyKaLXWb69CwUcXb/La5iSTBVtqhutVkdW0OW8+DP /0tQ== X-Gm-Message-State: AFqh2kqjtZQZclzl9Ha78TOXGBVXjkAIJzvLotyXrNFv8kzc//UyNNEJ QxuqNtGpngomX4FJx8HwOgFeclxHGlPeyDoj6RBf0DO+JvTYNvoLuWBdRI7Js6n/LPXgZlTMxju XKmJUejYJbS0a6/eLGhgCyi022DDdiqfqybqMSiQihdn0NbX2h4DcieS1ZaBBSo7WYWm6cwt0uw == X-Received: by 2002:aa7:d484:0:b0:468:ccfb:7201 with SMTP id b4-20020aa7d484000000b00468ccfb7201mr44934485edr.17.1673000773174; Fri, 06 Jan 2023 02:26:13 -0800 (PST) X-Google-Smtp-Source: AMrXdXv9EKP86oirHUPOoTyech/wvUIFWoCX1uMzQme74gIesmQrzx2KONrz8/w/aoMcCFK5LdewEA== X-Received: by 2002:aa7:d484:0:b0:468:ccfb:7201 with SMTP id b4-20020aa7d484000000b00468ccfb7201mr44934474edr.17.1673000772913; Fri, 06 Jan 2023 02:26:12 -0800 (PST) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id m2-20020a509302000000b0046892e493dcsm366196eda.26.2023.01.06.02.26.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jan 2023 02:26:12 -0800 (PST) To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 10/15] gdb/tui: make m_horizontal_offset private Date: Fri, 6 Jan 2023 10:25:37 +0000 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Burgess via Gdb-patches From: Andrew Burgess Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" I noticed that tui_source_window_base::m_horizontal_offset was protected, but could be made private, so lets do that. This makes more sense in the context of a later commit where I plan to add another member variable that is similar to m_horizontal_offset. The new member variable could also be private. So I had to choose, place the new member variable next to m_horizontal_offset making it protected, but grouping similar variables together, or make m_horizontal_offset private, and then add the new variable as private too. I chose to make m_horizontal_offset private, which is this commit. There should be no user visible changes after this commit. --- gdb/tui/tui-winsource.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gdb/tui/tui-winsource.h b/gdb/tui/tui-winsource.h index 7d6d64d35c4..bf0ca96c09b 100644 --- a/gdb/tui/tui-winsource.h +++ b/gdb/tui/tui-winsource.h @@ -124,8 +124,7 @@ struct tui_source_window_base : public tui_win_info /* Redraw the complete line of a source or disassembly window. */ void show_source_line (int lineno); - /* Used for horizontal scroll. */ - int m_horizontal_offset = 0; + /* Where to start generating content from. */ struct tui_line_or_address m_start_line_or_addr; /* Architecture associated with code at this location. */ @@ -179,6 +178,9 @@ struct tui_source_window_base : public tui_win_info private: + /* Used for horizontal scroll. */ + int m_horizontal_offset = 0; + void show_source_content (); /* Called when the user "set style enabled" setting is changed. */