From patchwork Mon Nov 25 14:16:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 101831 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 527603858C33 for ; Mon, 25 Nov 2024 14:18:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 527603858C33 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=SJjsECvb X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id E07DE3858C2B for ; Mon, 25 Nov 2024 14:16:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E07DE3858C2B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E07DE3858C2B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732544176; cv=none; b=lJqs8LLHw5iYz2VTJo+316G+Ug+9qDiV2VEs27t3NX8G5ZyXb7+vlIV3j6LD+0W3W63zgpVt/yWycjMDAJseT+BQ8PMDcPVUSwFhoHu7HZhLhUsz+yhKoYVjHJikPPr86WCDwdYWbezGIbmMYEedrWVYU2d1b2a1rHQ15KyW1Og= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732544176; c=relaxed/simple; bh=nzx2udk/TMm4ZpZ+ynfpVDVcTsufRGdUygdYmh/h/9Q=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=hNfMrydtE7151Yf0jSrTq2wO867GSpznJloBH9mLGIFJWgx7+xrYoZhXwy0HmvN6apwNxWXKR6P/n0LWa+ScMMuvwFhsRpPZ2ca9SNV/KclcNWT/tUjQTdXirBtt1vZ45bvqcsUL8jXWuk6cECGStIiGnhEEpTx5+npJ2r2aAqY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E07DE3858C2B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732544175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oBNHG6BYYafFADB5Fhht8pk7XgNUbqQkrKX8Vqjieg0=; b=SJjsECvb9j5/HMkfOjJT6bQ0eT+uU7eLv/iVonJG9nvVzSXHzYhMe4JVJpu50wwkmJrg5B 8fUK4B0WgF/qtiv+SYHZ1AwEzqkCXu7Bc1pPiOw3/Ub9UEXUTduv0Sohnyezkf/26eA30B hZSwVvV23XvmM3tGqhEipTBcsoQfzp0= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-98-wB3gZYKfPueX_DgQqgKLUQ-1; Mon, 25 Nov 2024 09:16:14 -0500 X-MC-Unique: wB3gZYKfPueX_DgQqgKLUQ-1 X-Mimecast-MFC-AGG-ID: wB3gZYKfPueX_DgQqgKLUQ Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3823326e95aso2405396f8f.3 for ; Mon, 25 Nov 2024 06:16:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732544173; x=1733148973; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oBNHG6BYYafFADB5Fhht8pk7XgNUbqQkrKX8Vqjieg0=; b=k/U2EOa7zbMptiUzyrfaZqCteUHPi8Et7b+8k2CpZ//4l7rLRKm97+Oo0Hd3+tHUIc SzxK4mAU0J0a9FvYDqoV+5BOXGWvS3cUE0rMTePrBUPdUOT7GOi0pTjfphgRzL0KDIX8 ijkWsOoAo/WRWi1gEa/dBcDSMzzY0BHQkZ5WC4atu7sFAfp/ffMYqFPb/OdSzO8+F077 oEliWbWtrIchuTD8jmQrk2DddEV9Z6bQSmYt2GmG/aB8cxrZxliVSfcKOj24lZu8K6l9 bG0DlpovwWT3Vn0LKIYU7n+cNPT68Yi/0zfe7HazdhCTaSCqGyj35wEz8LmJ+FYQu4zn smhg== X-Gm-Message-State: AOJu0YzoTxvjDc/2gv6Mv2KzfSQKnqebIH/GgsfgfB3wry19RVf/u79f 6mYPW3ZDe6TqYf7MP0gk0tPetso4qlLNTIH4Xn1kj2NwdI5gG9Q+g1HyjKJU4LFxwXtM/mz3WAb Fg24/cXD0d1GIyHUoNj7B0rIj4DPIjCCuyvybeRPRdc4vJoAWsR/dhtvlVyQjEF6LorlreKwZq/ /u4FDwRrDJ1LXuYoCv5Fq44VKfBCaZ51C22B6nr3ccD6A= X-Gm-Gg: ASbGncunxW8ki4ivtweyfOugoAg+opcMovSp9Cs2rbXEX+qjjNQUnKWKNyGCg0QfDr/ V0HB3M8Sy8olhTFvri2a4XkcbddLQkhGVbdn9YkFrFGJnfV2bpP36pv4VeM2ikfwm38TK/DebWH 24CJnbQAsyn24TH3t6sBI65eyOShorGVO1lTnwM9OYEhyITvEfMp6/cvFVPotFaPlyi28jfdcl0 eNBAZVKSTAmGx56OLOH5si1R3ObBsdlHDpV9tSDjOcVsveb+gxDf+tiYHRzQCz7QrAlP7kNKEXF Dw== X-Received: by 2002:a5d:5c0e:0:b0:382:4e57:48f8 with SMTP id ffacd0b85a97d-38260bc9755mr12632884f8f.43.1732544172935; Mon, 25 Nov 2024 06:16:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IE4ct6b4H8NEymgA0hiN8pepnOVAewIrm6rHH03yCgoCvs9srtuWrMz5M7V4jjXc0CXDOM/Uw== X-Received: by 2002:a5d:5c0e:0:b0:382:4e57:48f8 with SMTP id ffacd0b85a97d-38260bc9755mr12632842f8f.43.1732544172448; Mon, 25 Nov 2024 06:16:12 -0800 (PST) Received: from localhost (197.209.200.146.dyn.plus.net. [146.200.209.197]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3825fafe158sm10488465f8f.27.2024.11.25.06.16.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Nov 2024 06:16:11 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv2 1/2] gdb: make core_target_open static Date: Mon, 25 Nov 2024 14:16:06 +0000 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _eIyJ8RjNmCwB98NqavJcsi1M9t_nw_UP06AvZ-5rPw_1732544173 X-Mimecast-Originator: redhat.com content-type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org The core_target_open function is only used in corelow.c, so lets make it static. There should be no user visible changes after this commit. --- gdb/corelow.c | 8 ++++++-- gdb/gdbcore.h | 4 ---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gdb/corelow.c b/gdb/corelow.c index c176b24022d..4945b758382 100644 --- a/gdb/corelow.c +++ b/gdb/corelow.c @@ -59,6 +59,10 @@ #define O_LARGEFILE 0 #endif +/* Forward declarations. */ + +static void core_target_open (const char *arg, int from_tty); + /* A mem_range and the build-id associated with the file mapped into the given range. */ @@ -904,9 +908,9 @@ locate_exec_from_corefile_build_id (bfd *abfd, core_target *target, } } -/* See gdbcore.h. */ +/* Open and set up the core file bfd. */ -void +static void core_target_open (const char *arg, int from_tty) { const char *p; diff --git a/gdb/gdbcore.h b/gdb/gdbcore.h index 782643acf56..eb318d557d4 100644 --- a/gdb/gdbcore.h +++ b/gdb/gdbcore.h @@ -124,10 +124,6 @@ extern void (*deprecated_file_changed_hook) (const char *filename); extern bool write_files; -/* Open and set up the core file bfd. */ - -extern void core_target_open (const char *arg, int from_tty); - extern void core_file_command (const char *filename, int from_tty); extern void exec_file_attach (const char *filename, int from_tty);