diff mbox series

[PUSHED] gdb/testsuite: add some xfail in gdb.base/startup-with-shell.exp

Message ID f56707caa021dbe9a6e68aaa2dd0b13ba01f53df.1735055622.git.aburgess@redhat.com
State New
Headers
Series [PUSHED] gdb/testsuite: add some xfail in gdb.base/startup-with-shell.exp |

Commit Message

Andrew Burgess Dec. 24, 2024, 3:54 p.m. UTC 
  I pushed the patch below.  This is patch #1 with an updated commit log
message.  I figured that changing the FAIL to XFAIL was worth merging
ahead of this series.

Thanks,
Andrew

---

There are two tests that fail in gdb.base/startup-with-shell.exp when
using the native-extended-remote board.  I plan to fix these issues,
and I've posted a series that does just that:

  https://inbox.sourceware.org/gdb-patches/cover.1730731085.git.aburgess@redhat.com

But until that series is reviewed, I thought I'd merge this commit,
which marks the FAIL as XFAIL and links them to the relevant bug
number.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28392

Tested-By: Guinevere Larsen <guinevere@redhat.com>
---
 gdb/testsuite/gdb.base/startup-with-shell.exp | 9 +++++++++
 1 file changed, 9 insertions(+)


base-commit: 671c82e945f0fb02b58ee6edb47176606adfc3c0
diff mbox series

Patch

diff --git a/gdb/testsuite/gdb.base/startup-with-shell.exp b/gdb/testsuite/gdb.base/startup-with-shell.exp
index 670fab6a543..87a755904f6 100644
--- a/gdb/testsuite/gdb.base/startup-with-shell.exp
+++ b/gdb/testsuite/gdb.base/startup-with-shell.exp
@@ -55,11 +55,17 @@  proc initial_setup_simple { startup_with_shell run_args } {
     }
 }
 
+# Are we using 'remote' or 'extended-remote' protocol?
+set is_remote_p [gdb_protocol_is_remote]
+
 ## Run the actual tests
 
 with_test_prefix "startup_with_shell = on; run_args = *.unique-extension" {
     initial_setup_simple "on" "$unique_file_dir/*.unique-extension"
     gdb_test_no_output "set print characters unlimited"
+    if { $is_remote_p } {
+	setup_xfail "*-*-*" gdb/28392
+    }
     gdb_test "print argv\[1\]" "\\\$$decimal = $hex \"$unique_file\"" \
 	"first argument expanded"
 }
@@ -74,6 +80,9 @@  with_test_prefix "startup_with_shell = off; run_args = *.unique-extension" {
 with_test_prefix "startup_with_shell = on; run_args = \$TEST" {
     set env(TEST) "1234"
     initial_setup_simple "on" "\$TEST"
+    if { $is_remote_p } {
+	setup_xfail "*-*-*" gdb/28392
+    }
     gdb_test "print argv\[1\]" "\\\$$decimal = $hex \"1234\"" \
 	"testing first argument"
     unset env(TEST)