From patchwork Wed Oct 19 15:24:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 59068 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8A893384B12B for ; Wed, 19 Oct 2022 15:26:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8A893384B12B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666193174; bh=ixV7giNbCuSgs6h4Kf7zWl3gsTQr3+ixysQqZZ0MVnw=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=kFxlna2bY7TanfVbDRPDsjoeQ/o/Rvq8KEugfd4KHuccgZ5CkAYiYigMRLXouxzcf RCtSpuK25sFkD49mZ6uTH0phDFZUFpvtNrjPlnxjUfgUdE+/g5XQk+jZwwN4RfJl2r MKyvYueAHtXhGuRTxFg6OhgKTek3wuXOmKLNSTbc= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B97E83853571 for ; Wed, 19 Oct 2022 15:25:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B97E83853571 Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-621-oKBIcPMCNvCKqWvoeyRCpQ-1; Wed, 19 Oct 2022 11:24:59 -0400 X-MC-Unique: oKBIcPMCNvCKqWvoeyRCpQ-1 Received: by mail-qt1-f198.google.com with SMTP id fy10-20020a05622a5a0a00b0039cd5097697so12262390qtb.7 for ; Wed, 19 Oct 2022 08:24:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ixV7giNbCuSgs6h4Kf7zWl3gsTQr3+ixysQqZZ0MVnw=; b=4Qz6E7txdN0gzJiHnQGGZ7tANT2iDrU2ZkmRyfHdNpJyETVLoSxEhC7mjTdtQltxqy NJpDt8aGx8mkSsUsHPPibMFQ+TmoKdNoQupWjgMImNkjJsoOYNclKeQKwFkqMl8PmgHF p7aSB0uyDLtf+otLiQNlfNPwHlk5jcMJRZ4Vn59pR5lq3zYP5r8XpH3bf9BaFHbRpTc9 sOKP4E3BlWYPL/LFFg1sKjDAD9yxZ7sPQaPT9jKnteKlx4fw9lF3Qiz7DaYFj3v2+V9P uRcLKsVwXD9cjfk1eu7GsqYtPQw0eozTaxhFBAwYlPeO6t5uzovGL+y/dVok7ti1pPur HJlA== X-Gm-Message-State: ACrzQf2huQ54FOwqBaqvlBbNOwHfs00NrBq6BXTr+0/At25dddxM14Uy KjmUp4psBfDOK6WTI7cXAfj006cTUViV2RNO7ghKkoyRXO7rNMv0r3C1f9XZ63aZ1Himmix4nlh bb3MvfSUS+OfeN4aQ0TQUiI44/n0N7brhJKuG1dbWw9sjzXjWD/If7N3/sX5voTCkJK0TmqmoFA == X-Received: by 2002:a05:6214:2306:b0:473:f77a:85a7 with SMTP id gc6-20020a056214230600b00473f77a85a7mr7068379qvb.106.1666193099073; Wed, 19 Oct 2022 08:24:59 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5740C0Wh0WgBpCeK16pvcfVepntTOF10HEvNzL4Cc9U4lD6RRqCC5WjAJuStzps2qP+XB8jw== X-Received: by 2002:a05:6214:2306:b0:473:f77a:85a7 with SMTP id gc6-20020a056214230600b00473f77a85a7mr7068340qvb.106.1666193098507; Wed, 19 Oct 2022 08:24:58 -0700 (PDT) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id y2-20020a05620a0e0200b006ee8874f5d8sm4969117qkm.28.2022.10.19.08.24.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 08:24:58 -0700 (PDT) To: gdb-patches@sourceware.org Subject: [PATCH 02/10] sim/ppc: don't try to print an uninitialized variable Date: Wed, 19 Oct 2022 16:24:41 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Burgess via Gdb-patches From: Andrew Burgess Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" The ppc simulator, in sim_create_inferior, tries to print the function local entry_point variable before the variable is initialized. In this commit, I defer the debug print line until the variable has been initialized. --- sim/ppc/sim_calls.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sim/ppc/sim_calls.c b/sim/ppc/sim_calls.c index 729f6dcb6f3..3dcce19f628 100644 --- a/sim/ppc/sim_calls.c +++ b/sim/ppc/sim_calls.c @@ -161,8 +161,6 @@ sim_create_inferior (SIM_DESC sd, char * const *envp) { unsigned_word entry_point; - TRACE(trace_gdb, ("sim_create_inferior(start_address=0x%x, ...)\n", - entry_point)); if (simulator == NULL) error ("No program loaded"); @@ -172,6 +170,9 @@ sim_create_inferior (SIM_DESC sd, else entry_point = 0xfff00000; /* ??? */ + TRACE(trace_gdb, ("sim_create_inferior(start_address=0x%x, ...)\n", + entry_point)); + psim_init(simulator); psim_stack(simulator, argv, envp);