From patchwork Mon Feb 27 21:29:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 65707 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 387AF384FB4F for ; Mon, 27 Feb 2023 21:30:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 387AF384FB4F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1677533437; bh=K7K0/FcbIlAJJwr5q98ONmMSWTVEe+8yTrUmxMtATws=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=rs5qb98Q9zD/Ds7BTOQnVl0DIEf3PqmHBX3ma3Xh9ZVeCs9BSkPgz8IzGAgy6J79p Sr/oVvBD3o+0LBkIGxa/8lm7SM4EpsEfHsKFYWyXVb2+rLcqEUeUkEazWnWkO38zB0 luDqNe8K6e8RYav6qiZHFmJrwxzDlLbeB87N3cRM= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 4AF6E3858425 for ; Mon, 27 Feb 2023 21:29:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4AF6E3858425 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-529-y-jn4aUeN9iDX-MG712MSw-1; Mon, 27 Feb 2023 16:29:37 -0500 X-MC-Unique: y-jn4aUeN9iDX-MG712MSw-1 Received: by mail-wr1-f71.google.com with SMTP id 1-20020a056000154100b002c54d9b8312so1106791wry.5 for ; Mon, 27 Feb 2023 13:29:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677533376; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K7K0/FcbIlAJJwr5q98ONmMSWTVEe+8yTrUmxMtATws=; b=DNFzpDnDn//bWa5mNWWCgclN6dJIsP4IFlc9tsIXDvrLyHxQMrupyeBe4WKfW+cIPR XhZBOSeuou9DZc4w0qYMpKFHIh/aOv3Vm9iRsXZg4bydcA2Er16DMUWW4K/+OfFzldHf 03QPMPw6WTPdB+5zsvAOkjbfoM/Nd90kFanAa1LwU7rwC3mYM6OGKUGL4w2+rogRIEce bgv/2nh35bVuTIrPm9Xkki7NCGh6NxD1rKm1/QaN0eR/d87GGQuWPQrUPw4NJNCLRUob IG7/Wy2+dUflhe8gQU1/50r/gcKaMlhngmGb6z7ZqyZN23H9qFfsz8HXKrqafyIPcvrO qAmw== X-Gm-Message-State: AO0yUKUlrHK4DXJIqquHYEuQ5DC8gjkboknWfn6ryLa3tvan/OzX6kpB vfOPeVUF+9zgpmGCXzYh85C1ZY0b9elagFHlkr3VRviItm3tqHjvT3dO68IhZcIVtVHu2SVDmJe GusjfsXuuEdosqXKdb+LpLd02JgwdflR7st2stcnWcznhXg//H07hkuBW+3QiLkQ9XjQn7SvJmi 9Fcac= X-Received: by 2002:a05:600c:4b27:b0:3eb:38a2:2bcd with SMTP id i39-20020a05600c4b2700b003eb38a22bcdmr371781wmp.28.1677533376145; Mon, 27 Feb 2023 13:29:36 -0800 (PST) X-Google-Smtp-Source: AK7set+YevLee+KBHz9OcmsYi4DCx46MnuO6smC5EsJcCi/jOAMMcB6By5kkL8s3+Olbaz4btmKDNg== X-Received: by 2002:a05:600c:4b27:b0:3eb:38a2:2bcd with SMTP id i39-20020a05600c4b2700b003eb38a22bcdmr371771wmp.28.1677533375901; Mon, 27 Feb 2023 13:29:35 -0800 (PST) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id n41-20020a05600c3ba900b003e20fa01a86sm11099082wms.13.2023.02.27.13.29.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Feb 2023 13:29:35 -0800 (PST) To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 04/13] gdb: remove use of alloca from corefile.c Date: Mon, 27 Feb 2023 21:29:17 +0000 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_INVALID, DKIM_SIGNED, GIT_PATCH_0, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Burgess via Gdb-patches From: Andrew Burgess Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Remove uses of alloca from corefile.c and replace with gdb::byte_vector. There should be no user visible changes after this commit. --- gdb/corefile.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/gdb/corefile.c b/gdb/corefile.c index 5cb559000b8..c76b812f717 100644 --- a/gdb/corefile.c +++ b/gdb/corefile.c @@ -334,10 +334,10 @@ read_code_unsigned_integer (CORE_ADDR memaddr, int len, CORE_ADDR read_memory_typed_address (CORE_ADDR addr, struct type *type) { - gdb_byte *buf = (gdb_byte *) alloca (type->length ()); + gdb::byte_vector buf (type->length ()); - read_memory (addr, buf, type->length ()); - return extract_typed_address (buf, type); + read_memory (addr, buf.data (), type->length ()); + return extract_typed_address (buf.data (), type); } /* See gdbcore.h. */ @@ -370,10 +370,10 @@ write_memory_unsigned_integer (CORE_ADDR addr, int len, enum bfd_endian byte_order, ULONGEST value) { - gdb_byte *buf = (gdb_byte *) alloca (len); + gdb::byte_vector buf (len); - store_unsigned_integer (buf, len, byte_order, value); - write_memory (addr, buf, len); + store_unsigned_integer (buf.data (), len, byte_order, value); + write_memory (addr, buf.data (), len); } /* Store VALUE at ADDR in the inferior as a LEN-byte signed @@ -383,10 +383,10 @@ write_memory_signed_integer (CORE_ADDR addr, int len, enum bfd_endian byte_order, LONGEST value) { - gdb_byte *buf = (gdb_byte *) alloca (len); + gdb::byte_vector buf (len); - store_signed_integer (buf, len, byte_order, value); - write_memory (addr, buf, len); + store_signed_integer (buf.data (), len, byte_order, value); + write_memory (addr, buf.data (), len); } /* The current default bfd target. Points to storage allocated for