From patchwork Mon Feb 27 21:29:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 65709 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1A6E5384FB61 for ; Mon, 27 Feb 2023 21:31:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1A6E5384FB61 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1677533465; bh=QXSkgdBHPpUezicTdbfgril25G+iUdFOk//mSDTOpV8=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=ZhXTyDkQkn8xTBQ7wygNOfD+YGii7270qocJipVL24J0hmJt+N9O5oaavaSJXBHVJ AS9MU6xhIvhxuJulPolSrqgRd9hYqFw4OoLuAYDqMZthfUM72Q/+sOKzYEIWwcDCRJ qYwzWJmI0UugOztbwQfW2C2DVKD6Nyv+Eow/HLD8= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 32CEC38582A3 for ; Mon, 27 Feb 2023 21:29:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 32CEC38582A3 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-213-EVHiT1KNPpyQGcEmktfjag-1; Mon, 27 Feb 2023 16:29:41 -0500 X-MC-Unique: EVHiT1KNPpyQGcEmktfjag-1 Received: by mail-wr1-f72.google.com with SMTP id k6-20020adfc706000000b002c716981a1fso1119060wrg.1 for ; Mon, 27 Feb 2023 13:29:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677533380; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QXSkgdBHPpUezicTdbfgril25G+iUdFOk//mSDTOpV8=; b=6kQkYCPVvjuDoME9owokErrE7KdpBLWnLoRfyWqNifCKn6s9tA4SRaesC49tFucJZy zqPtEzs0hixnYgDz5cXzGmUxXGuw38CKzjftrLolzS9zhp01b5/V2Wu+1Bpx2LrgYoea lYJe8pwRJTKfzSqvRkw/oXHr5Ouybk1FHuFPwsUpMCm2iMQMg2/KVx/ySmQKfkEoQeBJ tzbrga5JGNbNTEDdVNy2hc6rcrXQ6w8bzpDD6m2su8oG5j7Khz9GknCZEtTrzxI/gz7F mu2kh3l2VFZRi0wgICv97MCKMrRSjAyAq3TkK1JWXPiTmTPxRhgqHS5rNNGHdGNzIwam oa+Q== X-Gm-Message-State: AO0yUKUNXSXJGVrC7B6QTiMcm+/a0JSdJKYUaCde2Hq/jOA1v3fqRlFt +b5H8bkO4qGYz0UcSha6a54Yy71woLC5rNQDuHADF5VfaCn5DcOvRuATym7mT3FkL6iiy9E+M0L 1BXLUuAtfvbKhUksgTuotemlAudoGNowdxpYJ0c/r1oaW0ePNtcft+LVTgFu9mCokn8djqWgLU3 JfU0E= X-Received: by 2002:a05:600c:181d:b0:3ea:f6c4:5f2a with SMTP id n29-20020a05600c181d00b003eaf6c45f2amr427986wmp.17.1677533380310; Mon, 27 Feb 2023 13:29:40 -0800 (PST) X-Google-Smtp-Source: AK7set/KtZzaE1fsAZeJbQRreJlhq22TfavjQCUbc352oGVse6oGA5gd+VzXuSAs/XfY7IvG7OtlsA== X-Received: by 2002:a05:600c:181d:b0:3ea:f6c4:5f2a with SMTP id n29-20020a05600c181d00b003eaf6c45f2amr427977wmp.17.1677533380037; Mon, 27 Feb 2023 13:29:40 -0800 (PST) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id 2-20020a05600c028200b003e9ded91c27sm13834769wmk.4.2023.02.27.13.29.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Feb 2023 13:29:39 -0800 (PST) To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 07/13] gdb: remove use of alloca from findvar.c Date: Mon, 27 Feb 2023 21:29:20 +0000 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Burgess via Gdb-patches From: Andrew Burgess Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Remove the use of alloca from findvar.c and replace it with gdb::byte_vector. There should be no user visible changes after this commit. --- gdb/findvar.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gdb/findvar.c b/gdb/findvar.c index 60b5ca3faf3..2c5ee11a2c7 100644 --- a/gdb/findvar.c +++ b/gdb/findvar.c @@ -951,11 +951,11 @@ address_from_register (int regnum, frame_info_ptr frame) pointer types. Avoid constructing a value object in those cases. */ if (gdbarch_convert_register_p (gdbarch, regnum, type)) { - gdb_byte *buf = (gdb_byte *) alloca (type->length ()); + gdb::byte_vector buf (type->length ()); int optim, unavail, ok; ok = gdbarch_register_to_value (gdbarch, frame, regnum, type, - buf, &optim, &unavail); + buf.data (), &optim, &unavail); if (!ok) { /* This function is used while computing a location expression. @@ -965,7 +965,7 @@ address_from_register (int regnum, frame_info_ptr frame) error_value_optimized_out (); } - return unpack_long (type, buf); + return unpack_long (type, buf.data ()); } value = gdbarch_value_from_register (gdbarch, type, regnum, null_frame_id);