From patchwork Thu Mar 22 12:57:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 26427 Received: (qmail 115495 invoked by alias); 22 Mar 2018 12:57:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 115419 invoked by uid 89); 22 Mar 2018 12:57:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wm0-f65.google.com Received: from mail-wm0-f65.google.com (HELO mail-wm0-f65.google.com) (74.125.82.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Mar 2018 12:57:15 +0000 Received: by mail-wm0-f65.google.com with SMTP id x82so15879394wmg.1 for ; Thu, 22 Mar 2018 05:57:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=oWiHTzNqGCiJrfe8w1Uvu2/sZ9FY38p1bdwm6789N9U=; b=OPaKOYnSBXA2kFU8Lr58XnAHW/2FkYAMNDtelHOIlEWTYZdlmP8638HadOdnX54M3j X6A+EKmtnJsJ0Jt6uULYUZWvmbD0kgy3IMxD9OZA7lqrkOeS5bIsEUd5X9cVzdV2OwzJ wOsBdNzgWr+diCPHKkkBgzbDzQmjf1vOmI0GyltNzI2NuJO1l4XPnMz0vKC+2DWYRIfA W6hFf14CWI5H1IHYCkI3CDvMbX2GQHYtLhIWp0ao6ymvz2xZW8zCmnG46er+6IoRB45+ xJSJ4eZlH/uBcPNBmkgko1MY1tqDnO+JXqVnmou7yuqQNjr9lsKdn3oL9aHpfhLVyqYI c2Xg== X-Gm-Message-State: AElRT7HV6I4Y7Ez7/bynML3HZ62U75OfHwXIo3FU1LrFaCXHEMXjNpd4 CnSwXsC3e6XFLnawjwl5FGPq4rKQ X-Google-Smtp-Source: AG47ELuOr8JFMIWZJIGpxc9daebGINO7zurjgqDxGQKG7w/VdEoRwE3xM0LkqRJp2AVrwsNcp9x7Mw== X-Received: by 10.28.147.12 with SMTP id v12mr5493576wmd.139.1521723432798; Thu, 22 Mar 2018 05:57:12 -0700 (PDT) Received: from localhost (host86-177-103-167.range86-177.btcentralplus.com. [86.177.103.167]) by smtp.gmail.com with ESMTPSA id z9sm8958738wrz.4.2018.03.22.05.57.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 22 Mar 2018 05:57:12 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 1/2] gdb: Minor cleanup in some gdb.arch/* tests Date: Thu, 22 Mar 2018 12:57:08 +0000 Message-Id: In-Reply-To: References: In-Reply-To: References: X-IsSubscribed: yes A small number of tests incorrectly tried to pass -Wa,-g through to GCC as an extra compile time flag, either to gdb_compile or prepare_for_testing. There were two mistakes, first, the 'debug' flag was already being passed, this will cause GCC to add a suitable -g flag, which should then be propagated to the assembler. Secondly, in order to pass additional compiler flags, the syntax would be 'additional_flags=-Wa,-g'. As it was, the flag was just being ignored. Given that all these tests pass 'debug', and the invalid flag has been ignored for some time, I'm just removing the flags in this commit. There should be no change in the test results after this commit. gdb/testsuite/ChangeLog: * gdb.arch/amd64-disp-step-avx.exp: Remove unneeded assembler flag option, syntax was wrong anyway. * gdb.arch/amd64-disp-step.exp: Likewise. * gdb.arch/arm-disp-step.exp: Likewise. * gdb.arch/i386-disp-step.exp: Likewise. * gdb.arch/sparc64-regs.exp: Likewise. --- gdb/testsuite/ChangeLog | 9 +++++++++ gdb/testsuite/gdb.arch/amd64-disp-step-avx.exp | 4 +--- gdb/testsuite/gdb.arch/amd64-disp-step.exp | 4 +--- gdb/testsuite/gdb.arch/arm-disp-step.exp | 4 +--- gdb/testsuite/gdb.arch/i386-disp-step.exp | 5 ++--- gdb/testsuite/gdb.arch/sparc64-regs.exp | 4 +--- 6 files changed, 15 insertions(+), 15 deletions(-) diff --git a/gdb/testsuite/gdb.arch/amd64-disp-step-avx.exp b/gdb/testsuite/gdb.arch/amd64-disp-step-avx.exp index 5c20aeb35b4..362ed7b7b3a 100644 --- a/gdb/testsuite/gdb.arch/amd64-disp-step-avx.exp +++ b/gdb/testsuite/gdb.arch/amd64-disp-step-avx.exp @@ -25,10 +25,8 @@ if { ![istarget x86_64-*-* ] || ![is_lp64_target] } { standard_testfile .S -set additional_flags "-Wa,-g" - if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \ - [list debug $additional_flags]] } { + [list debug]] } { return -1 } diff --git a/gdb/testsuite/gdb.arch/amd64-disp-step.exp b/gdb/testsuite/gdb.arch/amd64-disp-step.exp index 84f7e69e40e..2731f04dc70 100644 --- a/gdb/testsuite/gdb.arch/amd64-disp-step.exp +++ b/gdb/testsuite/gdb.arch/amd64-disp-step.exp @@ -27,9 +27,7 @@ set newline "\[\r\n\]*" standard_testfile .S -set additional_flags "-Wa,-g" - -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable [list debug $additional_flags]] != "" } { +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable [list debug]] != "" } { untested "failed to compile" return -1 } diff --git a/gdb/testsuite/gdb.arch/arm-disp-step.exp b/gdb/testsuite/gdb.arch/arm-disp-step.exp index 760d392885e..7268105f2dc 100644 --- a/gdb/testsuite/gdb.arch/arm-disp-step.exp +++ b/gdb/testsuite/gdb.arch/arm-disp-step.exp @@ -24,9 +24,7 @@ if {![is_aarch32_target]} then { standard_testfile .S -set additional_flags "-Wa,-g" - -if { [prepare_for_testing "failed to prepare" $testfile $srcfile [list debug $additional_flags]] } { +if { [prepare_for_testing "failed to prepare" $testfile $srcfile [list debug]] } { return -1 } diff --git a/gdb/testsuite/gdb.arch/i386-disp-step.exp b/gdb/testsuite/gdb.arch/i386-disp-step.exp index ff0713cef96..c4bed320743 100644 --- a/gdb/testsuite/gdb.arch/i386-disp-step.exp +++ b/gdb/testsuite/gdb.arch/i386-disp-step.exp @@ -25,9 +25,8 @@ if { ![is_x86_like_target] } then { standard_testfile .S -set additional_flags "-Wa,-g" - -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable [list debug $additional_flags]] != "" } { +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" \ + executable [list debug]] != "" } { untested "failed to compile" return -1 } diff --git a/gdb/testsuite/gdb.arch/sparc64-regs.exp b/gdb/testsuite/gdb.arch/sparc64-regs.exp index 3e84de6dd01..9fece51dda2 100644 --- a/gdb/testsuite/gdb.arch/sparc64-regs.exp +++ b/gdb/testsuite/gdb.arch/sparc64-regs.exp @@ -25,10 +25,8 @@ if ![istarget "sparc64*-*-linux*"] then { standard_testfile .S -set additional_flags "-Wa,-g" - if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \ - [list debug $additional_flags]] } { + [list debug]] } { return -1 }