From patchwork Sun Sep 25 08:44:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tsukasa OI X-Patchwork-Id: 58001 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 48CA63858029 for ; Sun, 25 Sep 2022 08:45:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 48CA63858029 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1664095544; bh=REIoVI6ZRfSTUW5o/sHfzLqzuoXG5uerheJGDcVhgqM=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=n6Majy4ua7FOOPqodJJue/ZcDseekBtYNKYUXbT6y9VdgX0kGvwq6TGXe7oo0fYSm U2ZglK5AjmhoOkanVnmpnlHxRfVee56zHzzTJRCZg5PoLZvwOvOn4o5IqwAfTzsphB tUOVIj7/m2lBUXsGNgZXhk8blex3PbJ8usmyI9L4= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id 2137B38582BF for ; Sun, 25 Sep 2022 08:45:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2137B38582BF Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 58240300089; Sun, 25 Sep 2022 08:45:17 +0000 (UTC) To: Tsukasa OI , Andrew Burgess , Mike Frysinger , Stephane Carrez , "Frank Ch . Eigler" Subject: [PATCH 5/7] sim/m68hc11: Add ATTRIBUTE_PRINTF Date: Sun, 25 Sep 2022 08:44:15 +0000 Message-Id: In-Reply-To: References: Mime-Version: 1.0 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tsukasa OI via Gdb-patches From: Tsukasa OI Reply-To: Tsukasa OI Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Clang generates a warning if the format string of a printf-like function is not a literal ("-Wformat-nonliteral"). On the default configuration, it causes a build failure (unless "--disable-werror" is specified). To avoid warnings on the printf-like wrapper, it requires proper __attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason. This commit adds ATTRIBUTE_PRINTF to a printf-like function. sim/ChangeLog: * m68hc11/m68hc11_sim.c (sim_memory_error): Add ATTRIBUTE_PRINTF. * m68hc11/sim-main.h (sim_memory_error): Likewise. --- sim/m68hc11/m68hc11_sim.c | 2 +- sim/m68hc11/sim-main.h | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/sim/m68hc11/m68hc11_sim.c b/sim/m68hc11/m68hc11_sim.c index 6ec45f78206..3f73215f2e2 100644 --- a/sim/m68hc11/m68hc11_sim.c +++ b/sim/m68hc11/m68hc11_sim.c @@ -1017,7 +1017,7 @@ cpu_single_step (sim_cpu *cpu) } /* VARARGS */ -void +void ATTRIBUTE_PRINTF(4, 5) sim_memory_error (sim_cpu *cpu, SIM_SIGNAL excep, uint16_t addr, const char *message, ...) { diff --git a/sim/m68hc11/sim-main.h b/sim/m68hc11/sim-main.h index e667c33a705..b8e485ebe97 100644 --- a/sim/m68hc11/sim-main.h +++ b/sim/m68hc11/sim-main.h @@ -538,8 +538,9 @@ extern void cpu_return (sim_cpu *cpu); extern void cpu_set_sp (sim_cpu *cpu, uint16_t val); extern int cpu_reset (sim_cpu *cpu); extern int cpu_restart (sim_cpu *cpu); -extern void sim_memory_error (sim_cpu *cpu, SIM_SIGNAL excep, - uint16_t addr, const char *message, ...); +extern void sim_memory_error (sim_cpu *cpu, SIM_SIGNAL excep, uint16_t addr, + const char *message, ...) + ATTRIBUTE_PRINTF (4, 5); extern void emul_os (int op, sim_cpu *cpu); extern void cpu_interp_m6811 (sim_cpu *cpu); extern void cpu_interp_m6812 (sim_cpu *cpu);