From patchwork Wed Aug 29 14:27:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 29105 Received: (qmail 79648 invoked by alias); 29 Aug 2018 14:27:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 78564 invoked by uid 89); 29 Aug 2018 14:27:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy=Administrator X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Aug 2018 14:27:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1535552857; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=CqA2RMnZ/DcLi/4jcgz3QjxMqeKZXw64AgLIqhak7r8=; b=GuELbcin/XeqxQcQCA3V8ovxDMR4XiG22+bgdny+ddllkO3Iq1aigQFmYTmz57YY +nW8nl2+TO5K8RqUdZmbW7Lyqtls3FIul0hOqGj5a0YmXQB5GGcqfjLaxlCmiTLo RsJu49wtbV7h+WFXVKpwWE006NbEnQ1qltUthfrDme0=; Received: from ESESBMB501.ericsson.se (Unknown_Domain [153.88.183.114]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id C0.1D.22015.95DA68B5; Wed, 29 Aug 2018 16:27:37 +0200 (CEST) Received: from ESESBMB501.ericsson.se (153.88.183.168) by ESESBMB501.ericsson.se (153.88.183.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 29 Aug 2018 16:27:36 +0200 Received: from NAM05-BY2-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB501.ericsson.se (153.88.183.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Wed, 29 Aug 2018 16:27:36 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W7gIUbsu/aUBv4l+LIQKHdbkIJQzylT/Jv1IWsGBiKA=; b=V9eYVh5p9FwfGR7HepnGfpOWPwK3/rZBPk9Ox3zx5vxDLJ2eCyG2H238wGesKaQrZd9b4C4tm0TKr1RUVN7469MLrKhSyeDhoORkQVOvdjeCeq2xCZRbbAEB+eHC5vTW/9U+MXO0WZBldVVPTGBYZa6h9x6hXw1AGUwxVhODeKc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.48.188] (192.75.88.130) by DM6PR15MB2393.namprd15.prod.outlook.com (2603:10b6:5:8d::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.15; Wed, 29 Aug 2018 14:27:33 +0000 Subject: Re: New ARI warning Wed Aug 29 01:57:16 UTC 2018 To: GDB Administrator , References: <20180829015716.GA50222@sourceware.org> From: Simon Marchi Message-ID: Date: Wed, 29 Aug 2018 10:27:25 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180829015716.GA50222@sourceware.org> Return-Path: simon.marchi@ericsson.com Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-IsSubscribed: yes On 2018-08-28 09:57 PM, GDB Administrator wrote: > 120a121,122 >> gdb/csky-tdep.c:1612: gettext: trailing new line: A message should not have a trailing new line > gdb/csky-tdep.c:1612: warning (_("Invalid breakpoint address 0x%x is an odd number.\n"), I pushed this obvious patch to fix this warning: From 2362e7f76adb395df19c867cd27c75f77a0ade6f Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Wed, 29 Aug 2018 10:26:11 -0400 Subject: [PATCH] Remove newline at end of warning message ... to fix this ARI warning: gdb/csky-tdep.c:1612: gettext: trailing new line: A message should not have a trailing new line gdb/csky-tdep.c:1612: warning (_("Invalid breakpoint address 0x%x is an odd number.\n"), gdb/ChangeLog: * csky-tdep.c (csky_memory_insert_breakpoint): Remove newline at end of warning message. --- gdb/ChangeLog | 5 +++++ gdb/csky-tdep.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 373e1b1..32054c6 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2018-08-29 Simon Marchi + + * csky-tdep.c (csky_memory_insert_breakpoint): Remove newline at + end of warning message. + 2018-08-29 Alan Hayward PR gdb/22943: diff --git a/gdb/csky-tdep.c b/gdb/csky-tdep.c index 997ca93..972ac59 100644 --- a/gdb/csky-tdep.c +++ b/gdb/csky-tdep.c @@ -1609,7 +1609,7 @@ csky_memory_insert_breakpoint (struct gdbarch *gdbarch, /* Sanity-check bp_address. */ if (bp_tgt->reqstd_address % 2) - warning (_("Invalid breakpoint address 0x%x is an odd number.\n"), + warning (_("Invalid breakpoint address 0x%x is an odd number."), (unsigned int) bp_tgt->reqstd_address); scoped_restore restore_memory = make_scoped_restore_show_memory_breakpoints (1);