From patchwork Tue Jan 16 21:24:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 84209 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EF5083858424 for ; Tue, 16 Jan 2024 21:25:18 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 3587C3858435 for ; Tue, 16 Jan 2024 21:24:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3587C3858435 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3587C3858435 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705440258; cv=none; b=hbk+ThA+FM+wUF/4QSVUC9c9ZRJCtlfe7cwTJq7w4dZxyRFkSO7J2+AmgVpegQOk+g+xPDsYWZH6J4VvbnbX1+pHLo9++QLC/++Vu5vVdzHir3EIJJxDZw58+8BuYqQ3rwnthOQg9dpzbNZ8OkZSSdBTjHHqamEqta7fzRXTMac= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705440258; c=relaxed/simple; bh=MVVUfUSt01juL7MyU4I/csTTjCPweFZHPlSp8XQXfg4=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=h7vB3/ohAaC6Y5GC1mJlIqPLr/s9K+fBgLSg54RL6EGtPixrs0ZwFDUTlGHftKuDYf3NgeUO0pMBKMGEdSuD7CqAU9J3EOmyLO1HE1m5igCE+nLTkrY8wC/Y2JJluCpsE6y7IbTrt4NJg0XHwnjS7/kaZpicz4/hKKyD6wuy5XI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705440254; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=36v4JYaDrpc6eYDLo/a8yYWUO3Oqkj9TQ420K6O143U=; b=B5A3KlILn7YhCXpAwqfr2vD+G/2dTr14wNK6uZ3kAknVcgmTyj5xmUk8x5LBndlzL+TAhf GAk+3ohjknXfgaj6eEExeZrWmSQiNTcIof4/nhYIGWE7y6Ae1qov+wI3Pi2T4wDXC85ZoK ZyY3B2Z7lbiQBqF6BI4xW8+gVVFt6HM= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-664-Cuq7Hb6KPhyEkzQDq1EnUg-1; Tue, 16 Jan 2024 16:24:13 -0500 X-MC-Unique: Cuq7Hb6KPhyEkzQDq1EnUg-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-337bf81e1efso374729f8f.2 for ; Tue, 16 Jan 2024 13:24:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705440251; x=1706045051; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=36v4JYaDrpc6eYDLo/a8yYWUO3Oqkj9TQ420K6O143U=; b=hVohNdaSLjHzXhFiYvjyGv9kF+O9QbqA5vgthworHRRxqAr38vNn1SCYKPEaXmKHH9 KbaEABCdDuXWGoqXVhUbHk/fSChWnY6NbxUk7Z8SdF1K6nIiUHKV8AsEFxCGh6Kbx1Is 54vBxbMIUYEsiZsqnrxCvHxOF9amOpHOTO9WmKTXOlqzzSVaXuZOf9828fckPAlFBvqc CjgF1UmvbCLyIrnrfJFNYmt0yUw487e+0z7T3MThQwvKGDFrBOrOrE6HUJKj/CDd2Zq9 Fk7EFN7iLwJ+Uv8xClSmham/CT1CXEvY6DA7/u8A6yOPLg/vUG/QVmTw0YtwcWMtZfQu PNMg== X-Gm-Message-State: AOJu0YxilKCG+uav5XUryrIxaTqmVdFUeVSaFjLgnQ7ao7DdAxyf5SWd ka4rsyOPgdVwj5DPOT93R6yoXG1umnArowF1ZuLsHrHPHGIOIg1LtXduRZf5PU2+OfDq4i0SSPk byrX6WrKkDSiA7EPvSBLAymYbpFGG/fMLRBTCfiqPO5IRDwc6bUvnTjFYbnEVJIG27noZB66pM9 RkWAjCvLES7CMajQ== X-Received: by 2002:adf:f045:0:b0:337:b6f6:adc7 with SMTP id t5-20020adff045000000b00337b6f6adc7mr854575wro.99.1705440251701; Tue, 16 Jan 2024 13:24:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IHzWsWgxDrX0RxXqVXGT3sWO+yGrIDRvsB8I1QvkJVs6Zp7ffRNTiiAtDpjbSS6crM/uEc7Cg== X-Received: by 2002:adf:f045:0:b0:337:b6f6:adc7 with SMTP id t5-20020adff045000000b00337b6f6adc7mr854571wro.99.1705440251385; Tue, 16 Jan 2024 13:24:11 -0800 (PST) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id m17-20020adfe951000000b00336e15fbc85sm62347wrn.82.2024.01.16.13.24.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jan 2024 13:24:10 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 4/5] gdb: remove some dead code from completer.c Date: Tue, 16 Jan 2024 21:24:01 +0000 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org In completer.c there is some code that is surrounded with '#if 0', this code: #if 0 /* There is no way to do this just long enough to affect quote inserting without also affecting the next completion. This should be fixed in readline. FIXME. */ /* Ensure that readline does the right thing with respect to inserting quotes. */ rl_completer_word_break_characters = ""; #endif This code, in some form, and always defined out, has been around since the original import of GDB. Though the comment hints at what the problem might be, it's not really clear what the issue is. And completion within GDB has moved on a long way since this code was written ... but not used. I'm proposing that we just remove this code. If/when a problem comes up then we can look at how to solve it. Maybe this code would be the answer ... but also, I suspect, given all the changes ... maybe not. I'm not sure carrying around this code for another 20+ years adds much value. There should be no user visible changes after this commit. --- gdb/completer.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/gdb/completer.c b/gdb/completer.c index 198d7893a6f..9c89aa43810 100644 --- a/gdb/completer.c +++ b/gdb/completer.c @@ -241,14 +241,6 @@ filename_completer (struct cmd_list_element *ignore, tracker.add_completion (make_completion_match_str (std::move (p_rl), text, word)); } -#if 0 - /* There is no way to do this just long enough to affect quote - inserting without also affecting the next completion. This - should be fixed in readline. FIXME. */ - /* Ensure that readline does the right thing - with respect to inserting quotes. */ - rl_completer_word_break_characters = ""; -#endif } /* The corresponding completer_handle_brkchars