From patchwork Mon Feb 27 21:29:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 65702 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CB56C385B532 for ; Mon, 27 Feb 2023 21:30:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CB56C385B532 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1677533403; bh=8wtp/KsDyL4t3rj7k4jtrXo2fxvKqjbmBDWdmUtaZjQ=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=A52RcsXk8LlakM3ujE4DNnGcH0XS67Ywh/6A+TKs8VIDHHy9dN6l378siYHpU9nlv 7FQuVDWG4qYv0qos5EUk2xITbpV83II2QVCRF/M07Rsunvc1b7Rp3eTGh0Epfz4m8V yYdjZCcdxPRbmilLodKPVePZAplPkf7ij3JVmpgs= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 435CC3858412 for ; Mon, 27 Feb 2023 21:29:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 435CC3858412 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-86-PbgmrN2VN6OWbcLN5Fu5Mg-1; Mon, 27 Feb 2023 16:29:34 -0500 X-MC-Unique: PbgmrN2VN6OWbcLN5Fu5Mg-1 Received: by mail-wm1-f70.google.com with SMTP id u19-20020a05600c00d300b003eb24ce58ceso2853516wmm.9 for ; Mon, 27 Feb 2023 13:29:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677533373; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8wtp/KsDyL4t3rj7k4jtrXo2fxvKqjbmBDWdmUtaZjQ=; b=yeqVs+88d6Ms0TYUAnqcyL8yyhhou68feq4jBqpDRm/VO9ksWDBuN4zIbF2KS/WxLb 9hJ8NJHQs6fZRAcR8tuLTJgNosOHasrJWukuI2iQ4GlBvMWNGC9/O9UBqLUQ5XtNzzGj Ph9buj1k37AW4V3zHh4fLh3b1fpQyn0opd80AY83TGFYXtXWUDZ06nHNaoeO5Wz3eOG7 dAFs5mTdkvBkDmvxep8/pw7BO1x4tLxkbxPEVHCQAA0RlFx14iaHSbiygRzZ1rK8Ddti d4QjO1WuSJxEQBacZ1BMU0dPPiwfJW4N0ShnSq75N6fjutbHOHwYHq2U2Pryh7CuCt7d KKYQ== X-Gm-Message-State: AO0yUKX99y5P28sa5R2WClyxA55Nf1nxGnX482e95EepfooZTm43MEfC UIn1veQ3m577OjyCa1G2cAwN5OxDQ09tGAfLpMJ2iS4YQibVos11EX51ME2od2S+mYVIqfKTKv2 1bbLF/jDUbzHqa8FWbns+Ac8+feOtkHwsfacSxh8ayQ4VQIwyHriMfMeAzYlpDBMR9RJvuIcQlc 1fGAs= X-Received: by 2002:a05:600c:44d4:b0:3eb:29fe:7baa with SMTP id f20-20020a05600c44d400b003eb29fe7baamr406668wmo.34.1677533373006; Mon, 27 Feb 2023 13:29:33 -0800 (PST) X-Google-Smtp-Source: AK7set9HiBkvu24TdGRxGV2CXxzkKOym5vPz6/5xSepNNshfEG2346FMWxOjPl7pvvJVsepdRmyT0A== X-Received: by 2002:a05:600c:44d4:b0:3eb:29fe:7baa with SMTP id f20-20020a05600c44d400b003eb29fe7baamr406656wmo.34.1677533372583; Mon, 27 Feb 2023 13:29:32 -0800 (PST) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id k14-20020a05600c1c8e00b003eae73f0fc1sm11409441wms.18.2023.02.27.13.29.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Feb 2023 13:29:32 -0800 (PST) To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 02/13] gdb: remove use of alloca from auxv.c Date: Mon, 27 Feb 2023 21:29:15 +0000 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Burgess via Gdb-patches From: Andrew Burgess Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Remove the last use of alloca from auxv.c and replace it with gdb::byte_vector. There should be no user visible changes after this commit. --- gdb/auxv.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/gdb/auxv.c b/gdb/auxv.c index 812b2807554..aea58807f4c 100644 --- a/gdb/auxv.c +++ b/gdb/auxv.c @@ -86,7 +86,6 @@ ld_so_xfer_auxv (gdb_byte *readbuf, struct type *ptr_type = builtin_type (target_gdbarch ())->builtin_data_ptr; size_t ptr_size = ptr_type->length (); size_t auxv_pair_size = 2 * ptr_size; - gdb_byte *ptr_buf = (gdb_byte *) alloca (ptr_size); LONGEST retval; size_t block; @@ -123,10 +122,11 @@ ld_so_xfer_auxv (gdb_byte *readbuf, we might need a valgrind extension to make it work. This is PR 11440. */ - if (target_read_memory (pointer_address, ptr_buf, ptr_size) != 0) + gdb::byte_vector ptr_buf (ptr_size); + if (target_read_memory (pointer_address, ptr_buf.data (), ptr_size) != 0) return TARGET_XFER_E_IO; - data_address = extract_typed_address (ptr_buf, ptr_type); + data_address = extract_typed_address (ptr_buf.data (), ptr_type); /* Possibly still not initialized such as during an inferior startup. */ @@ -151,11 +151,11 @@ ld_so_xfer_auxv (gdb_byte *readbuf, if (offset >= auxv_pair_size) { - if (target_read_memory (data_address - auxv_pair_size, ptr_buf, + if (target_read_memory (data_address - auxv_pair_size, ptr_buf.data (), ptr_size) != 0) return TARGET_XFER_E_IO; - if (extract_typed_address (ptr_buf, ptr_type) == AT_NULL) + if (extract_typed_address (ptr_buf.data (), ptr_type) == AT_NULL) return TARGET_XFER_EOF; }