From patchwork Mon Feb 20 14:13:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 65264 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BAF73383E2B2 for ; Mon, 20 Feb 2023 14:14:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BAF73383E2B2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1676902465; bh=uz8SxnIf6llKj79RrjZLwI8Ae+NUbTFb0HCpU/7IOFM=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=FRzWrrbri65kLGcp7h9MKmImjNF33BUwtUnkxhYghlLp8aRXB8NwHxTVVxPHJX5ga gLZZ4h3Ix/Mm+fJXJYCF//Elmv2bsUA/KtAY9iF92x+KMiptL3jMnvU6iq8GmCrUxf KyXKVu5y8UKNO4PVOgQjZUtA7FH7gy/YmWsWeZzc= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9A662383FE0A for ; Mon, 20 Feb 2023 14:13:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9A662383FE0A Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-211-Fq_zZocAMGW95SvdUIDndg-1; Mon, 20 Feb 2023 09:13:58 -0500 X-MC-Unique: Fq_zZocAMGW95SvdUIDndg-1 Received: by mail-wr1-f69.google.com with SMTP id m15-20020adfa3cf000000b002be0eb97f4fso129438wrb.8 for ; Mon, 20 Feb 2023 06:13:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uz8SxnIf6llKj79RrjZLwI8Ae+NUbTFb0HCpU/7IOFM=; b=AAM+j+l4ncYQIROYH3w9IwRx7XorqXAvcH2PWGOaJjDFcSau6PnPB/CCxhnFaCT1R9 KI3uwa+Mmhw9NdpRp3LaO4eWPa6qRVKibltnZs5nB3rwTfQwzOlZbKWlepesLU3y8S2N 0f92KWDJWZU3THd9coQ6YU2RlhHazeL5ASIo2Du+UlAM7vGpd0esLduCtrhTAivIcj5J TXJ1c4DCjlmLU+QLdssfikUhKL6LmonLNiJhKszUPfFp5jK1I+tZ7PFGUr2flioPulf4 YLCLiHtAsiZ56gzrVTfsGqkTiFiTs4AMcSpwRvPn4VKd/oABSYA6VyF/D1ryivKerXfd iQ8Q== X-Gm-Message-State: AO0yUKUm3COoItDA90GYHDahuApsS9RJ5VJhtFIsc8qrAyPy9bzM+s2t pOmkWcCh/RivFMoaZ/mLMtP5ZBYAP0OR30ASUoNtxbKt5HUkO/UXwAe/g+YMYLIrBLkwUaTzmUc 6p1LhyCwL2V1xs1hvUhuC1Es6wWWtTFkp8TCRrwWsaxG/91CiwCvDGs45QMAkyWsCTVnfjpYyac JJ2c0= X-Received: by 2002:a05:600c:4aa8:b0:3e2:a9e:4eaa with SMTP id b40-20020a05600c4aa800b003e20a9e4eaamr10819761wmp.35.1676902436887; Mon, 20 Feb 2023 06:13:56 -0800 (PST) X-Google-Smtp-Source: AK7set+pcFSZVxa29Zp2pZQ749z2CY3aa+E8d0TZ0AzQoBhmtCoFIcUlI+eLdFdyZoOnARRTm3EzBQ== X-Received: by 2002:a05:600c:4aa8:b0:3e2:a9e:4eaa with SMTP id b40-20020a05600c4aa800b003e20a9e4eaamr10819750wmp.35.1676902436608; Mon, 20 Feb 2023 06:13:56 -0800 (PST) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id e13-20020a5d65cd000000b002c5640f9bf9sm364872wrw.85.2023.02.20.06.13.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 06:13:56 -0800 (PST) To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 1/8] gdb: remove an out of date comment about disp_del_at_next_stop Date: Mon, 20 Feb 2023 14:13:46 +0000 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Burgess via Gdb-patches From: Andrew Burgess Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Delete an out of date comment about disp_del_at_next_stop, the comment says: /* NOTE drow/2003-09-08: This state only exists for removing watchpoints. It's not clear that it's necessary... */ I'm sure this was true when the comment was added, but today the disp_del_at_next_stop state is not just used for deleting watchpoints, which leaves us with "It's not clear that it's necessary...", which doesn't really help at all. And then this comment is located on one random place where disp_del_at_next_stop is used, rather than at its definition site. Lets just delete the comment. No user visible changes after this commit. --- gdb/breakpoint.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 0db3adaf916..902119c7d2c 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -2938,8 +2938,6 @@ insert_bp_location (struct bp_location *bl, } else if (bl->loc_type == bp_loc_hardware_watchpoint - /* NOTE drow/2003-09-08: This state only exists for removing - watchpoints. It's not clear that it's necessary... */ && bl->owner->disposition != disp_del_at_next_stop) { int val;