From patchwork Tue Feb 11 09:01:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tankut Baris Aktemur X-Patchwork-Id: 37933 Received: (qmail 123796 invoked by alias); 11 Feb 2020 09:04:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 120103 invoked by uid 89); 11 Feb 2020 09:03:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mga07.intel.com Received: from mga07.intel.com (HELO mga07.intel.com) (134.134.136.100) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Feb 2020 09:03:30 +0000 Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Feb 2020 01:03:27 -0800 Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga005.jf.intel.com with ESMTP; 11 Feb 2020 01:03:26 -0800 Received: from ulvlx001.iul.intel.com (ulvlx001.iul.intel.com [172.28.207.17]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id 01B93PZY002298; Tue, 11 Feb 2020 09:03:25 GMT Received: from ulvlx001.iul.intel.com (localhost [127.0.0.1]) by ulvlx001.iul.intel.com with ESMTP id 01B93P72010674; Tue, 11 Feb 2020 10:03:25 +0100 Received: (from taktemur@localhost) by ulvlx001.iul.intel.com with LOCAL id 01B93PP3010670; Tue, 11 Feb 2020 10:03:25 +0100 From: Tankut Baris Aktemur To: gdb-patches@sourceware.org Subject: [PATCH 47/58] gdbserver: turn target op 'supports_agent' into a method Date: Tue, 11 Feb 2020 10:01:59 +0100 Message-Id: In-Reply-To: References: In-Reply-To: References: X-IsSubscribed: yes gdbserver/ChangeLog: 2020-02-10 Tankut Baris Aktemur Make process_stratum_target's supports_agent op a method of process_target. * target.h (struct process_stratum_target): Remove the target op. (class process_target): Add the target op. (target_supports_agent): Update the macro. * target.c (process_target::supports_agent): Define. Update the derived structs and callers below. * linux-low.c (linux_target_ops): Update. (linux_supports_agent): Turn into ... (linux_process_target::supports_agent): ... this. * linux-low.h (class linux_process_target): Update. * lynx-low.c (lynx_target_ops): Update. * nto-low.c (nto_target_ops): Update. * win32-low.c (win32_target_ops): Update. --- gdbserver/linux-low.c | 7 +++---- gdbserver/linux-low.h | 2 ++ gdbserver/lynx-low.c | 1 - gdbserver/nto-low.c | 1 - gdbserver/target.c | 6 ++++++ gdbserver/target.h | 9 ++++----- gdbserver/win32-low.c | 1 - 7 files changed, 15 insertions(+), 12 deletions(-) diff --git a/gdbserver/linux-low.c b/gdbserver/linux-low.c index fcca23f0510..5a3390bff54 100644 --- a/gdbserver/linux-low.c +++ b/gdbserver/linux-low.c @@ -6413,10 +6413,10 @@ linux_process_target::supports_disable_randomization () #endif } -static int -linux_supports_agent (void) +bool +linux_process_target::supports_agent () { - return 1; + return true; } static int @@ -7452,7 +7452,6 @@ linux_get_hwcap2 (int wordsize) static linux_process_target the_linux_target; static process_stratum_target linux_target_ops = { - linux_supports_agent, #ifdef HAVE_LINUX_BTRACE linux_enable_btrace, linux_low_disable_btrace, diff --git a/gdbserver/linux-low.h b/gdbserver/linux-low.h index e0938fdf340..63cb52e9204 100644 --- a/gdbserver/linux-low.h +++ b/gdbserver/linux-low.h @@ -434,6 +434,8 @@ public: unsigned char *readbuf, unsigned const char *writebuf, CORE_ADDR offset, int len) override; + + bool supports_agent () override; }; #define get_thread_lwp(thr) ((struct lwp_info *) (thread_target_data (thr))) diff --git a/gdbserver/lynx-low.c b/gdbserver/lynx-low.c index 43fa36c5fbd..bfa76cf7de6 100644 --- a/gdbserver/lynx-low.c +++ b/gdbserver/lynx-low.c @@ -735,7 +735,6 @@ static lynx_process_target the_lynx_target; /* The LynxOS target_ops vector. */ static process_stratum_target lynx_target_ops = { - NULL, /* support_agent */ NULL, /* enable_btrace */ NULL, /* disable_btrace */ NULL, /* read_btrace */ diff --git a/gdbserver/nto-low.c b/gdbserver/nto-low.c index 7940325c3b5..e97ebe395f7 100644 --- a/gdbserver/nto-low.c +++ b/gdbserver/nto-low.c @@ -947,7 +947,6 @@ nto_sw_breakpoint_from_kind (int kind, int *size) static nto_process_target the_nto_target; static process_stratum_target nto_target_ops = { - NULL, /* support_agent */ NULL, /* enable_btrace */ NULL, /* disable_btrace */ NULL, /* read_btrace */ diff --git a/gdbserver/target.c b/gdbserver/target.c index 34b3ffd1cfd..3e4d9730b6f 100644 --- a/gdbserver/target.c +++ b/gdbserver/target.c @@ -720,3 +720,9 @@ process_target::qxfer_libraries_svr4 (const char *annex, { gdb_assert_not_reached ("target op qxfer_libraries_svr4 not supported"); } + +bool +process_target::supports_agent () +{ + return false; +} diff --git a/gdbserver/target.h b/gdbserver/target.h index 3e90227c4fd..a89f7b14269 100644 --- a/gdbserver/target.h +++ b/gdbserver/target.h @@ -70,9 +70,6 @@ class process_target; shared code. */ struct process_stratum_target { - /* Return true if target supports debugging agent. */ - int (*supports_agent) (void); - /* Enable branch tracing for PTID based on CONF and allocate a branch trace target information struct for reading and for disabling branch trace. */ struct btrace_target_info *(*enable_btrace) @@ -497,6 +494,9 @@ public: unsigned char *readbuf, unsigned const char *writebuf, CORE_ADDR offset, int len); + + /* Return true if target supports debugging agent. */ + virtual bool supports_agent (); }; extern process_stratum_target *the_target; @@ -607,8 +607,7 @@ int kill_inferior (process_info *proc); the_target->pt->supports_disable_randomization () #define target_supports_agent() \ - (the_target->supports_agent ? \ - (*the_target->supports_agent) () : 0) + the_target->pt->supports_agent () static inline struct btrace_target_info * target_enable_btrace (ptid_t ptid, const struct btrace_config *conf) diff --git a/gdbserver/win32-low.c b/gdbserver/win32-low.c index f54d1bf0ef3..e24c6ced43d 100644 --- a/gdbserver/win32-low.c +++ b/gdbserver/win32-low.c @@ -1848,7 +1848,6 @@ win32_sw_breakpoint_from_kind (int kind, int *size) static win32_process_target the_win32_target; static process_stratum_target win32_target_ops = { - NULL, /* support_agent */ NULL, /* enable_btrace */ NULL, /* disable_btrace */ NULL, /* read_btrace */