From patchwork Tue Jun 23 21:45:02 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Palka X-Patchwork-Id: 7314 Received: (qmail 130280 invoked by alias); 23 Jun 2015 21:45:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 130271 invoked by uid 89); 23 Jun 2015 21:45:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-qk0-f177.google.com Received: from mail-qk0-f177.google.com (HELO mail-qk0-f177.google.com) (209.85.220.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 23 Jun 2015 21:45:05 +0000 Received: by qkbp125 with SMTP id p125so12306715qkb.2 for ; Tue, 23 Jun 2015 14:45:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type; bh=Bx/pFGGRPjVUnYH+74RXKx4EQ47FcjcaOCn4bPl2saY=; b=m/GkUDarc/jVcVJglJg5pbxaMPtTmZmOlarayVLGR/JcAd2D2xRX11qlPtGorW0CQ0 RbK+eI93NAaIg1NqM6iY3B2J42LvGx85zqbQfgTqIPs8c9Wz/auwnL0ZqCuJqjM+MZZd 2SKxO7wCEiBjBNNmLbrODOfJfvxipMsy3ZvmxNDZZ3z7UsF5ylWFDGHtyQlTfAGs9AcB lYUaWyVPhZs7UoxUb0HtFxwfC+XhXE6ypnrxHzkymMiQDbPbXR+Xmrg9OACE3bb9iIVf LuRh4WoWzTTInHGezfoNSiYMpYJ2c6TC5Cgzo3m4+UDnQQWs/X4MFMSowNh/0zrUGfw0 XpTQ== X-Gm-Message-State: ALoCoQku+kE2sxRQLywdgVIQw/TT8OzY9qgrBAb8v4aE4nUstNQbWMMUS6iDAi+7k507DdWL59VJ X-Received: by 10.55.41.233 with SMTP id p102mr50329822qkp.32.1435095903674; Tue, 23 Jun 2015 14:45:03 -0700 (PDT) Received: from [192.168.1.130] (ool-4353acd8.dyn.optonline.net. [67.83.172.216]) by mx.google.com with ESMTPSA id 188sm2135407qhu.15.2015.06.23.14.45.02 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Jun 2015 14:45:03 -0700 (PDT) From: Patrick Palka X-Google-Original-From: Patrick Palka Date: Tue, 23 Jun 2015 17:45:02 -0400 (EDT) To: Doug Evans cc: Keith Seitz , gdb-patches Subject: Re: Several regressions and we branch soon. In-Reply-To: Message-ID: References: <5589BECB.7090200@redhat.com> User-Agent: Alpine 2.20.8 (DEB 77 2015-05-01) MIME-Version: 1.0 On Tue, 23 Jun 2015, Doug Evans wrote: > On Tue, Jun 23, 2015 at 3:17 PM, Keith Seitz wrote: >> FWIW, I updated my virgin sandbox earlier, and I don't see a bunch of >> the failures that you are/have. I've listed the ones I do see below. >> FWIW, I have another branch that was last updated the first week of May >> which shows none of these problems. >> >> I'll start looking at these failures immediately. >> >> Keith >> >> On 06/23/2015 12:03 PM, Doug Evans wrote: >> >>>>> FAIL: gdb.base/default.exp: info set >>>>> FAIL: gdb.base/default.exp: show The problem here seems to be that the "show" function corresponding to the "mpx bound" command calls error("Intel(R) Memory Protection Extensions not supported on this target."); which throws an exception that causes the entire "info set"/"show" loop to exit early. Should "show foo" ever throw an exception? Should the "info set"/"show" loop expect an exception to be thrown from a show function? This diff fixes the default.exp FAILs as far as I can tell: diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c index 42d0346..d11efa1 100644 --- a/gdb/i386-tdep.c +++ b/gdb/i386-tdep.c @@ -8777,11 +8777,17 @@ i386_mpx_info_bounds (char *args, int from_tty) struct type *data_ptr_type = builtin_type (gdbarch)->builtin_data_ptr; if (!i386_mpx_enabled ()) - error (_("Intel(R) Memory Protection Extensions not\ - supported on this target.")); + { + printf_unfiltered (_("Intel(R) Memory Protection Extensions not " + "supported on this target.\n")); + return; + } if (args == NULL) - error (_("Address of pointer variable expected.")); + { + printf_unfiltered (_("Address of pointer variable expected.\n")); + return; + } addr = parse_and_eval_address (args); @@ -8856,7 +8862,7 @@ static struct cmd_list_element *mpx_set_cmdlist, *mpx_show_cmdlist; static void set_mpx_cmd (char *args, int from_tty) { - help_list (mpx_set_cmdlist, "set mpx", all_commands, gdb_stdout); + help_list (mpx_set_cmdlist, "set mpx ", all_commands, gdb_stdout); } /* Helper function for the CLI commands. */ @@ -8901,7 +8907,7 @@ is \"default\"."), add_prefix_cmd ("mpx", class_support, set_mpx_cmd, _("\ Set Intel(R) Memory Protection Extensions specific variables."), - &mpx_set_cmdlist, "set tdesc ", + &mpx_set_cmdlist, "set mpx ", 0 /* allow-unknown */, &setlist); /* Add "mpx" prefix for the show commands. */