From patchwork Tue Mar 18 19:51:09 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Maciej W. Rozycki" X-Patchwork-Id: 149 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx21.g.dreamhost.com (caibbdcaaahb.dreamhost.com [208.113.200.71]) by wilcox.dreamhost.com (Postfix) with ESMTP id CB0EB3600A0 for ; Tue, 18 Mar 2014 12:51:33 -0700 (PDT) Received: by homiemail-mx21.g.dreamhost.com (Postfix, from userid 14314964) id 6613B20FA7E3; Tue, 18 Mar 2014 12:51:33 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx21.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx21.g.dreamhost.com (Postfix) with ESMTPS id 1BE4F1F4B969 for ; Tue, 18 Mar 2014 12:51:33 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; q=dns; s=default; b=G/9Si 7ell4WUzpqiQ+554n1ZN94e5Ui8VHpqzkwVnPCAYb9IndaaJdsl620QqlXzxaZLB x9rGr3Et4oEY6lKKsOQVVt0onTamb8Gu0bxGXND6FdaAEH0iIG/nkGNuvD+CmtHJ 7cggF7aDZjs6e9eLDSHFZz/xYlcFRF/QROGcr8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; s=default; bh=iSnaTPAXu8h IVE4BQnryf0pE4N8=; b=WcpqZBXvP0JMO9Mow7tlXViZG3BYvZ8AGMdZVh4cIUE cW2XNznCIN49K5gIdUK/JSMEv57ur6SvR4diZGk/y0Ekvrelo90R6vRotxF5w5co MVdfy83JyHTDEECb0HscNcTH6ovLwIFrShQglAw8lGDSGc+hUbpmiozlIldWlRWU = Received: (qmail 26653 invoked by alias); 18 Mar 2014 19:51:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 26638 invoked by uid 89); 18 Mar 2014 19:51:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Mar 2014 19:51:28 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1WQ02i-0005sP-JO from Maciej_Rozycki@mentor.com ; Tue, 18 Mar 2014 12:51:20 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 18 Mar 2014 12:51:20 -0700 Received: from [172.30.64.246] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Tue, 18 Mar 2014 19:51:18 +0000 Date: Tue, 18 Mar 2014 19:51:09 +0000 From: "Maciej W. Rozycki" To: Joel Brobecker , Stan Shebs CC: , Andrew Cagney , Kevin Buettner Subject: Re: [PING][PATCH] Power: Correct little-endian e500v2 GPR frame offsets In-Reply-To: <20140312083446.GE4882@adacore.com> Message-ID: References: <20140312083446.GE4882@adacore.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 X-DH-Original-To: gdb@patchwork.siddhesh.in On Wed, 12 Mar 2014, Joel Brobecker wrote: > > > gdb/ > > > * rs6000-tdep.c (rs6000_frame_cache): Correct little-endian > > > GPR offset into SPE pseudo registers. > > Sorry for the delay. This is OK, but with one small comment. No worries and sorry to trouble you -- I missed Stan's earlier reply. > > > int i; > > > CORE_ADDR ev_addr = cache->base + fdata.ev_offset; > > > + CORE_ADDR off = byte_order == BFD_ENDIAN_BIG ? 4 : 0; > > > for (i = fdata.saved_ev; i < ppc_num_gprs; i++) > > Would you mind adding an empty line after the local variable > declarations? Sure, I have taken Stan's suggestion into account too. Here's the final version I applied. Thank you both for the review. 2014-03-18 Maciej W. Rozycki gdb/ * rs6000-tdep.c (rs6000_frame_cache): Correct little-endian GPR offset into SPE pseudo registers. Maciej gdb-rs6000-ev-gpr-le.diff Index: gdb-fsf-trunk-quilt/gdb/rs6000-tdep.c =================================================================== --- gdb-fsf-trunk-quilt.orig/gdb/rs6000-tdep.c 2014-03-18 19:00:27.000000000 +0000 +++ gdb-fsf-trunk-quilt/gdb/rs6000-tdep.c 2014-03-18 19:05:33.938923879 +0000 @@ -3257,12 +3257,14 @@ rs6000_frame_cache (struct frame_info *t { int i; CORE_ADDR ev_addr = cache->base + fdata.ev_offset; + CORE_ADDR off = (byte_order == BFD_ENDIAN_BIG ? 4 : 0); + for (i = fdata.saved_ev; i < ppc_num_gprs; i++) { cache->saved_regs[tdep->ppc_ev0_regnum + i].addr = ev_addr; - cache->saved_regs[tdep->ppc_gp0_regnum + i].addr = ev_addr + 4; + cache->saved_regs[tdep->ppc_gp0_regnum + i].addr = ev_addr + off; ev_addr += register_size (gdbarch, tdep->ppc_ev0_regnum); - } + } } }