procfs.c: Include "filestuff.h"
Commit Message
Fixes implicit function declaration
error in procfs.c:4927 about undeclared
make_cleanup_close().
gdb/ChangeLog:
PR gdb/18843
* procfs.c: Include "filestuff.h"
---
gdb/ChangeLog | 5 +++++
gdb/procfs.c | 1 +
2 files changed, 6 insertions(+)
Comments
Marcin Cieslak <saper@saper.info> writes:
> Fixes implicit function declaration
> error in procfs.c:4927 about undeclared
> make_cleanup_close().
>
> gdb/ChangeLog:
>
> PR gdb/18843
Nit: it should be "PR build/18843".
> * procfs.c: Include "filestuff.h"
It is a sentence so should be ended with ".".
Otherwise, patch is OK to me. You can push it in or I can push it in in
case you don't have write access to git repository.
On Wed, 19 Aug 2015, Yao Qi wrote:
> Otherwise, patch is OK to me. You can push it in or I can push it in in
> case you don't have write access to git repository.
Nits should be fixed. It is my first contribution to gdb ever,
so I doubt I have a write access anywhere :)
~Marcin
Marcin Cieslak <saper@saper.info> writes:
> Nits should be fixed. It is my first contribution to gdb ever,
> so I doubt I have a write access anywhere :)
Thanks. I pushed your patch in to both master and 7.10 branch.
@@ -1,3 +1,8 @@
+2015-08-18 Marcin Cieślak <saper@saper.info>
+
+ PR gdb/18843
+ * procfs.c: Include "filestuff.h"
+
2015-08-18 Sandra Loosemore <sandra@codesourcery.com>
* remote.c (strprefix): New.
@@ -30,6 +30,7 @@
#include "gdbthread.h"
#include "regcache.h"
#include "inf-child.h"
+#include "filestuff.h"
#if defined (NEW_PROC_API)
#define _STRUCTURED_PROC 1 /* Should be done by configure script. */