From patchwork Wed Sep 19 04:23:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sandra Loosemore X-Patchwork-Id: 29456 Received: (qmail 108793 invoked by alias); 19 Sep 2018 04:23:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 108784 invoked by uid 89); 19 Sep 2018 04:23:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=readline, H*r:0700 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Sep 2018 04:23:55 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1g2U1p-00011s-Qv from Sandra_Loosemore@mentor.com for gdb-patches@sourceware.org; Tue, 18 Sep 2018 21:23:53 -0700 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Tue, 18 Sep 2018 21:23:51 -0700 To: "gdb-patches@sourceware.org" From: Sandra Loosemore Subject: [patch, testsuite] skip tab-completion tests if no readline Message-ID: Date: Tue, 18 Sep 2018 22:23:49 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 I found a bunch of borked tab-completion tests when running tests on a remote Windows host, where the input stream is not a tty and has no readline support. I've copied the test for readline support verbatim from the older gdb.base/completion.exp testcase into these newer testcases. OK to commit? -Sandra commit b4262306c3d11c87c11c873d3bd6065fcb6b0625 Author: Sandra Loosemore Date: Tue Sep 18 21:10:55 2018 -0700 Skip GDB tab-completion tests if no readline. 2018-09-18 Sandra Loosemore gdb/testsuite/ * gdb.base/complete-empty.exp: Skip tab-completion tests if no readline. * gdb.base/utf8-identifiers.exp: Likewise. * gdb.cp/cpcompletion.exp: Likewise. * gdb.linespec/cpcompletion.exp: Likewise. * gdb.linespec/cpls-abi-tag.exp: Likewise. * gdb.linespec/cpls-ops.exp: Likewise. diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 701d979..6ec2f86 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,13 @@ +2018-09-18 Sandra Loosemore + + * gdb.base/complete-empty.exp: Skip tab-completion tests if + no readline. + * gdb.base/utf8-identifiers.exp: Likewise. + * gdb.cp/cpcompletion.exp: Likewise. + * gdb.linespec/cpcompletion.exp: Likewise. + * gdb.linespec/cpls-abi-tag.exp: Likewise. + * gdb.linespec/cpls-ops.exp: Likewise. + 2018-09-18 Sergio Durigan Junior * gdb.arch/amd64-invalid-stack-top.exp: Expect optional diff --git a/gdb/testsuite/gdb.base/complete-empty.exp b/gdb/testsuite/gdb.base/complete-empty.exp index 6a78538..c97b1fd 100644 --- a/gdb/testsuite/gdb.base/complete-empty.exp +++ b/gdb/testsuite/gdb.base/complete-empty.exp @@ -15,6 +15,13 @@ # This file is part of the gdb testsuite. +# Tests below are about tab-completion, which doesn't work if readline +# library isn't used. Check it first. + +if { ![readline_is_used] } { + return -1 +} + load_lib completion-support.exp gdb_exit diff --git a/gdb/testsuite/gdb.base/utf8-identifiers.exp b/gdb/testsuite/gdb.base/utf8-identifiers.exp index 12fe376..6afc884 100644 --- a/gdb/testsuite/gdb.base/utf8-identifiers.exp +++ b/gdb/testsuite/gdb.base/utf8-identifiers.exp @@ -56,6 +56,13 @@ gdb_test "continue" \ # names getting in the way of completion. gdb_test_no_output "nosharedlibrary" +# Tests below are about tab-completion, which doesn't work if readline +# library isn't used. Check it first. + +if { ![readline_is_used] } { + return -1 +} + # Test linespec completion. # A unique completion. diff --git a/gdb/testsuite/gdb.cp/cpcompletion.exp b/gdb/testsuite/gdb.cp/cpcompletion.exp index 9ec3bbf..0a5e804 100644 --- a/gdb/testsuite/gdb.cp/cpcompletion.exp +++ b/gdb/testsuite/gdb.cp/cpcompletion.exp @@ -15,6 +15,13 @@ # This file is part of the gdb testsuite. +# Tests below are about tab-completion, which doesn't work if readline +# library isn't used. Check it first. + +if { ![readline_is_used] } { + return -1 +} + load_lib completion-support.exp # A helper procedure to test location completions restricted by diff --git a/gdb/testsuite/gdb.linespec/cpcompletion.exp b/gdb/testsuite/gdb.linespec/cpcompletion.exp index d8aa5b2..1fc5390 100644 --- a/gdb/testsuite/gdb.linespec/cpcompletion.exp +++ b/gdb/testsuite/gdb.linespec/cpcompletion.exp @@ -15,6 +15,13 @@ # This file is part of the gdb testsuite. +# Tests below are about tab-completion, which doesn't work if readline +# library isn't used. Check it first. + +if { ![readline_is_used] } { + return -1 +} + load_lib completion-support.exp standard_testfile cpls.cc cpls2.cc cpls-hyphen.cc diff --git a/gdb/testsuite/gdb.linespec/cpls-abi-tag.exp b/gdb/testsuite/gdb.linespec/cpls-abi-tag.exp index e188637..a3a2e56 100644 --- a/gdb/testsuite/gdb.linespec/cpls-abi-tag.exp +++ b/gdb/testsuite/gdb.linespec/cpls-abi-tag.exp @@ -17,6 +17,13 @@ # Test ABI tag support in linespecs. +# Tests below are about tab-completion, which doesn't work if readline +# library isn't used. Check it first. + +if { ![readline_is_used] } { + return -1 +} + load_lib completion-support.exp standard_testfile cpls-abi-tag.cc diff --git a/gdb/testsuite/gdb.linespec/cpls-ops.exp b/gdb/testsuite/gdb.linespec/cpls-ops.exp index 355735e..ccd89a3 100644 --- a/gdb/testsuite/gdb.linespec/cpls-ops.exp +++ b/gdb/testsuite/gdb.linespec/cpls-ops.exp @@ -15,6 +15,13 @@ # This file is part of the gdb testsuite. +# Tests below are about tab-completion, which doesn't work if readline +# library isn't used. Check it first. + +if { ![readline_is_used] } { + return -1 +} + load_lib completion-support.exp standard_testfile cpls-ops.cc