From patchwork Sun Sep 25 08:44:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tsukasa OI X-Patchwork-Id: 58002 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4E9A2385828F for ; Sun, 25 Sep 2022 08:45:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4E9A2385828F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1664095546; bh=1WK1ezOpYCeZAsBaWAwmcPnXOzO2uoW13GDkHpaHZ6s=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Tw5D7TuTiIPtw7cGhQ7H0f08r3xZuIznKEKzr9tDh1C+Dk/S2hbXh08tdYp/YFctj L6lSaiR9BWigIlJwKXacOcGWMK5maGCGgl3zHlLRru47YLKJReu1RVubYJeq1NzXoO FL/UFFGzksLoDbAhyAIlaU5ifFueLxr7hH2qLvZg= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id 8AAF7385840C for ; Sun, 25 Sep 2022 08:45:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8AAF7385840C Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id CC9A5300089; Sun, 25 Sep 2022 08:45:06 +0000 (UTC) To: Tsukasa OI , Andrew Burgess , Mike Frysinger , Stephane Carrez , "Frank Ch . Eigler" Subject: [PATCH 4/7] sim/m32c: Add ATTRIBUTE_PRINTF Date: Sun, 25 Sep 2022 08:44:14 +0000 Message-Id: In-Reply-To: References: Mime-Version: 1.0 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tsukasa OI via Gdb-patches From: Tsukasa OI Reply-To: Tsukasa OI Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Clang generates a warning if the format string of a printf-like function is not a literal ("-Wformat-nonliteral"). On the default configuration, it causes a build failure (unless "--disable-werror" is specified). To avoid warnings on the printf-like wrapper, it requires proper __attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason. This commit adds ATTRIBUTE_PRINTF to the printf-like functions. sim/ChangeLog: * m32c/trace.c (op_printf, op_styled_printf): Add ATTRIBUTE_PRINTF. --- sim/m32c/trace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sim/m32c/trace.c b/sim/m32c/trace.c index 1888e69122b..0aa4440cade 100644 --- a/sim/m32c/trace.c +++ b/sim/m32c/trace.c @@ -89,7 +89,7 @@ compare_symbols (const void *ap, const void *bp) static char opbuf[1000]; -static int +static int ATTRIBUTE_PRINTF(2, 3) op_printf (char *buf, char *fmt, ...) { int ret; @@ -101,7 +101,7 @@ op_printf (char *buf, char *fmt, ...) return ret; } -static int +static int ATTRIBUTE_PRINTF(3, 4) op_styled_printf (char *buf, enum disassembler_style style, char *fmt, ...) { int ret;