From patchwork Fri Oct 12 00:01:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sandra Loosemore X-Patchwork-Id: 29715 Received: (qmail 39381 invoked by alias); 12 Oct 2018 00:01:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 39339 invoked by uid 89); 12 Oct 2018 00:01:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=spurious, H*r:0700 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 12 Oct 2018 00:01:47 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1gAktl-0001r9-Hd from Sandra_Loosemore@mentor.com for gdb-patches@sourceware.org; Thu, 11 Oct 2018 17:01:45 -0700 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Thu, 11 Oct 2018 17:01:43 -0700 To: "gdb-patches@sourceware.org" From: Sandra Loosemore Subject: [testsuite, obvious] fix pathname regexp in gdb.base/solib-vanish.exp Message-ID: Date: Thu, 11 Oct 2018 18:01:40 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 When cross-debugging from Windows host, names of source files typically print without a directory prefix. So I was getting a spurious failure like: Breakpoint 2, bar (y=1) at solib-vanish-lib2.c:21 21 return y + 1; /* break here */ (gdb) FAIL: gdb.base/solib-vanish.exp: continue to breakpoint: bar because the regexp expected a "/" in the filename. This is easy to fix, and in fact in the past I've committed a number of similar patches to adjust other testcases expecting a directory prefix as well. So I've committed this one as obvious. -Sandra commit d4330bde6891c74498cea8866ce9992181798861 Author: Sandra Loosemore Date: Thu Oct 11 16:51:26 2018 -0700 Fix pathname regexp in gdb.base/solib-vanish.exp. 2018-10-11 Sandra Loosemore gdb/testsuite/ * gdb.base/solib-vanish.exp: Fix regexp not to require a POSIX directory prefix on the filename. diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index f907323..ba5fae9 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2018-10-11 Sandra Loosemore + + * gdb.base/solib-vanish.exp: Fix regexp not to require a POSIX + directory prefix on the filename. + 2018-10-10 Sergio Durigan Junior * gdb.gdb/unittest.exp: Update expected message informing that diff --git a/gdb/testsuite/gdb.base/solib-vanish.exp b/gdb/testsuite/gdb.base/solib-vanish.exp index 928ca4e..a243d3d 100644 --- a/gdb/testsuite/gdb.base/solib-vanish.exp +++ b/gdb/testsuite/gdb.base/solib-vanish.exp @@ -98,7 +98,7 @@ gdb_breakpoint "${lib2name}.c:${lib2_lineno}" {allow-pending} # Verify that both the location and source code are displayed gdb_continue_to_breakpoint "bar" \ - ".*/${lib2name}.c:${lib2_lineno}.*break here.*" + ".*${lib2name}.c:${lib2_lineno}.*break here.*" # This should not segfault gdb_test "next" \