diff mbox series

sim prune_warnings

Message ID ZNniLeKvLHS55l2X@squeak.grove.modra.org
State New
Headers
Series sim prune_warnings |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Testing passed

Commit Message

Alan Modra Aug. 14, 2023, 8:13 a.m. UTC 
  Remove some of the warnings generated by newer versions of ld.
Without this patch "make check" in sim/ doesn't do much for some
targets.

OK?

	* testsuite/lib/sim-defs.exp (prune_warnings_extra): New.
	Arrange to run it from prune_warnings.

Comments

Tom Tromey Aug. 31, 2023, 1:25 p.m. UTC | #1 
>>>>> "Alan" == Alan Modra via Gdb-patches <gdb-patches@sourceware.org> writes:

Alan> Remove some of the warnings generated by newer versions of ld.
Alan> Without this patch "make check" in sim/ doesn't do much for some
Alan> targets.

Alan> OK?

Alan> 	* testsuite/lib/sim-defs.exp (prune_warnings_extra): New.
Alan> 	Arrange to run it from prune_warnings.

I didn't see a response to this, but IMO it seems fine.
Please go ahead.

thanks,
Tom
Alan Modra Aug. 31, 2023, 10:12 p.m. UTC | #2 
On Thu, Aug 31, 2023 at 07:25:50AM -0600, Tom Tromey wrote:
> >>>>> "Alan" == Alan Modra via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Alan> Remove some of the warnings generated by newer versions of ld.
> Alan> Without this patch "make check" in sim/ doesn't do much for some
> Alan> targets.
> 
> Alan> OK?
> 
> Alan> 	* testsuite/lib/sim-defs.exp (prune_warnings_extra): New.
> Alan> 	Arrange to run it from prune_warnings.
> 
> I didn't see a response to this, but IMO it seems fine.
> Please go ahead.

I committed the patch on Aug 19, when pushing the sim regen series.
It seemed obvious enough to me.  Without it I would have needed to
edit commit 9d4f36166d626 log to report a lot more fails.
Tom Tromey Sept. 1, 2023, 3:07 a.m. UTC | #3 
Alan> I committed the patch on Aug 19, when pushing the sim regen series.
Alan> It seemed obvious enough to me.  Without it I would have needed to
Alan> edit commit 9d4f36166d626 log to report a lot more fails.

Ok, thanks.  I sometimes reply to patches when I haven't seen any
traffic; I didn't think to check the git log.

Tom
Mike Frysinger Oct. 15, 2023, 9:38 a.m. UTC | #4 
On 14 Aug 2023 17:43, Alan Modra via Gdb-patches wrote:
> +    regsub -all "(^|\n)(\[^\n\]*: warning:\[^\n\]*missing \\.note\\.GNU-stack section\[^\n\]*\n?)+" $text "\\1" text
> +    regsub -all "(^|\n)(\[^\n\]*: warning:\[^\n\]*has a LOAD segment with RWX permissions\[^\n\]*\n?)+" $text "\\1" text

imo these are bugs that should be fixed rather than ignored.
i filed some for people to fixup.  haven't kept track of the
overall status though.

> +    regsub -all "(^|\n)(\[^\n\]*: NOTE: This behaviour is deprecated\[^\n\]*\n?)+" $text "\\1" text

not sure that i've seen this one before
-mike
diff mbox series

Patch

diff --git a/sim/testsuite/lib/sim-defs.exp b/sim/testsuite/lib/sim-defs.exp
index 5528d64684b..54860f2ea51 100644
--- a/sim/testsuite/lib/sim-defs.exp
+++ b/sim/testsuite/lib/sim-defs.exp
@@ -651,3 +651,22 @@  proc slurp_options { file } {
     close $f
     return $opt_array
 }
+
+proc prune_warnings_extra { text } {
+
+    regsub -all "(^|\n)(\[^\n\]*: warning:\[^\n\]*missing \\.note\\.GNU-stack section\[^\n\]*\n?)+" $text "\\1" text
+    regsub -all "(^|\n)(\[^\n\]*: NOTE: This behaviour is deprecated\[^\n\]*\n?)+" $text "\\1" text
+
+    regsub -all "(^|\n)(\[^\n\]*: warning:\[^\n\]*has a LOAD segment with RWX permissions\[^\n\]*\n?)+" $text "\\1" text
+
+    return $text
+}
+
+if { [info procs saved-prune_warnings] == [list] } {
+    rename prune_warnings saved-prune_warnings
+    proc prune_warnings { text } {
+	set text [saved-prune_warnings $text]
+	set text [prune_warnings_extra $text]
+	return $text
+    }
+}