From patchwork Wed Apr 12 08:25:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alan Hayward X-Patchwork-Id: 19987 Received: (qmail 67318 invoked by alias); 12 Apr 2017 08:25:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 67304 invoked by uid 89); 12 Apr 2017 08:25:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, MIME_BASE64_BLANKS, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR02-AM5-obe.outbound.protection.outlook.com Received: from mail-eopbgr00088.outbound.protection.outlook.com (HELO EUR02-AM5-obe.outbound.protection.outlook.com) (40.107.0.88) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Apr 2017 08:25:19 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0103.eurprd08.prod.outlook.com (10.160.211.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1019.17; Wed, 12 Apr 2017 08:25:17 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::c065:778f:9924:8660]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::c065:778f:9924:8660%14]) with mapi id 15.01.1019.026; Wed, 12 Apr 2017 08:25:17 +0000 From: Alan Hayward To: Yao Qi CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH 6/11] Add ALPHA_MAX_REGISTER_SIZE Date: Wed, 12 Apr 2017 08:25:17 +0000 Message-ID: References: <772F5764-0F2A-4F53-BC41-C36AF15BED21@arm.com> <86bms3wbh5.fsf@gmail.com> In-Reply-To: <86bms3wbh5.fsf@gmail.com> authentication-results: gmail.com; dkim=none (message not signed) header.d=none; gmail.com; dmarc=none action=none header.from=arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-microsoft-exchange-diagnostics: 1; AM3PR08MB0103; 7:UEEqoW/tcAbv0wagOFli8UZau71HRupfm0zKMX0ei7vNCw7E+5SuNxUK9dmS5/N47Plqt/h9DKYIGS95kx+gp9pft4nnqmteGVSC+OP6uAXsk7VesDktcq5TNNpWA9rYqpsxpJNEWybIIkl4nldjCBtxhb8CHu/WP3P3iMGuE9TLCuFIpUsGcjvmBqP3m8gJJWdm+dCAkH/RvqF5eebz8VPH76duPC3IXpcJf0ewNl3TZI8KLvRAHZOLDKTQA3Xag5exTzC5xLDvmAidEGojyCxJVzPVtCkmDEUvGt/9PTF++WTRzDZjb57yezlp5xMhOOf5dJSMiACsUkmcbU4M7g== x-ms-office365-filtering-correlation-id: 60fe033d-4c77-41f6-4c92-08d4817d736c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081)(201702281549075); SRVR:AM3PR08MB0103; nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041248)(20161123564025)(20161123560025)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(6072148); SRVR:AM3PR08MB0103; BCL:0; PCL:0; RULEID:; SRVR:AM3PR08MB0103; x-forefront-prvs: 027578BB13 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39410400002)(39860400002)(39840400002)(39450400003)(39850400002)(39400400002)(24454002)(377424004)(6116002)(3846002)(102836003)(5250100002)(7736002)(82746002)(6916009)(305945005)(2950100002)(83716003)(36756003)(50986999)(54356999)(76176999)(2900100001)(33656002)(575784001)(86362001)(189998001)(66066001)(1411001)(6486002)(6506006)(99286003)(38730400002)(4326008)(110136004)(6436002)(54906002)(6512007)(229853002)(53936002)(5660300001)(39060400002)(3280700002)(3660700001)(25786009)(6246003)(53546009)(2906002)(8676002)(81166006)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR08MB0103; H:AM3PR08MB0101.eurprd08.prod.outlook.com; FPR:; SPF:None; MLV:ovrnspm; PTR:InfoNoRecords; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: <750A41A51D36384B857046673105F350@eurprd08.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2017 08:25:17.0432 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0103 > On 11 Apr 2017, at 10:16, Yao Qi wrote: > > Alan Hayward writes: > >> diff --git a/gdb/alpha-tdep.h b/gdb/alpha-tdep.h >> index ab46ba56bef1ffb1cea541c506ffed6a5ae9b556..316d94d0bb53e9bc7943d406bf81f7d597437ff3 100644 >> --- a/gdb/alpha-tdep.h >> +++ b/gdb/alpha-tdep.h >> @@ -26,6 +26,9 @@ struct regcache; >> real way to know how big a register is. */ >> #define ALPHA_REGISTER_SIZE 8 >> >> +/* Big enough to hold the size of the largest register in bytes. */ >> +#define ALPHA_MAX_REGISTER_SIZE 8 >> + > >> --- a/gdb/alpha-tdep.c >> +++ b/gdb/alpha-tdep.c >> @@ -244,7 +244,7 @@ alpha_register_to_value (struct frame_info *frame, int regnum, >> int *optimizedp, int *unavailablep) >> { >> struct gdbarch *gdbarch = get_frame_arch (frame); >> - gdb_byte in[MAX_REGISTER_SIZE]; >> + gdb_byte in[ALPHA_MAX_REGISTER_SIZE]; >> >> /* Convert to TYPE. */ >> if (!get_frame_register_bytes (frame, regnum, 0, > > We can use get_frame_register_value, so "in" can be removed. > >> @@ -266,7 +266,7 @@ static void >> alpha_value_to_register (struct frame_info *frame, int regnum, >> struct type *valtype, const gdb_byte *in) >> { >> - gdb_byte out[MAX_REGISTER_SIZE]; >> + gdb_byte out[ALPHA_MAX_REGISTER_SIZE]; > > Why don't you use ALPHA_REGISTER_SIZE? Hmmm... yes. Not sure why I ignored that! > > -- > Yao (齐尧) Updated changes below. I don't have a ALPHA machine to test on. Tested on a --enable-targets=all build using make check with board files unix and native-gdbserver. Ok to commit? Alan. 2017-04-12 Alan Hayward * alpha-tdep.c (alpha_register_to_value): Use get_frame_register_value. (alpha_value_to_register): Use ALPHA_REGISTER_SIZE. diff --git a/gdb/alpha-tdep.c b/gdb/alpha-tdep.c index 4dd65c58cc2896ea6038399128e3eb376d1ee672..2f9f81952fea0e7fa050866db3fe05776edcdc63 100644 --- a/gdb/alpha-tdep.c +++ b/gdb/alpha-tdep.c @@ -244,17 +244,23 @@ alpha_register_to_value (struct frame_info *frame, int regnum, int *optimizedp, int *unavailablep) { struct gdbarch *gdbarch = get_frame_arch (frame); - gdb_byte in[MAX_REGISTER_SIZE]; + struct value *value; /* Convert to TYPE. */ - if (!get_frame_register_bytes (frame, regnum, 0, - register_size (gdbarch, regnum), - in, optimizedp, unavailablep)) + + value = get_frame_register_value (frame, regnum); + + gdb_assert (value != NULL); + + *optimizedp = value_optimized_out (value); + *unavailablep = !value_entirely_available (value); + + if (*optimizedp || *unavailablep) return 0; if (TYPE_LENGTH (valtype) == 4) { - alpha_sts (gdbarch, out, in); + alpha_sts (gdbarch, out, value_contents (value)); *optimizedp = *unavailablep = 0; return 1; } @@ -266,7 +272,7 @@ static void alpha_value_to_register (struct frame_info *frame, int regnum, struct type *valtype, const gdb_byte *in) { - gdb_byte out[MAX_REGISTER_SIZE]; + gdb_byte out[ALPHA_REGISTER_SIZE]; switch (TYPE_LENGTH (valtype)) {