From patchwork Thu Feb 21 18:26:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Hayward X-Patchwork-Id: 31545 Received: (qmail 49594 invoked by alias); 21 Feb 2019 18:26:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 49561 invoked by uid 89); 21 Feb 2019 18:26:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR04-HE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr70042.outbound.protection.outlook.com (HELO EUR04-HE1-obe.outbound.protection.outlook.com) (40.107.7.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Feb 2019 18:26:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cplT79hjPiY3DXBO9jDgpNzE9kh0AUq/Y3yGljhzQJo=; b=BAEBli5HWbG9q6jGHfqFrQhuhGB340K7eZucwmbai5kzzlObIS2rH98/a1k2Me7LcYiW9+4jVXPCV2vSnHW7LgR7vVg30quWu7iHNwpUXR0TxMpgj8dQ68+BLQeP9ENOzsJMvPs7zzyEinF3rjdEUOXnUcWfBT9F3JRjjeP9C9M= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2502.eurprd08.prod.outlook.com (10.172.251.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.15; Thu, 21 Feb 2019 18:26:12 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::e974:35a7:c83c:e5b7]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::e974:35a7:c83c:e5b7%3]) with mapi id 15.20.1622.020; Thu, 21 Feb 2019 18:26:12 +0000 From: Alan Hayward To: Eli Zaretskii CC: GDB Patches , nd Subject: Re: [PATCH] Document style behavior in batch mode. Date: Thu, 21 Feb 2019 18:26:12 +0000 Message-ID: References: <20190221132331.19849-1-alan.hayward@arm.com> <83tvgxfa7q.fsf@gnu.org> In-Reply-To: <83tvgxfa7q.fsf@gnu.org> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 Content-ID: <81FD31A94253DA4F97FED2A39C644518@eurprd08.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-IsSubscribed: yes > On 21 Feb 2019, at 15:11, Eli Zaretskii wrote: > >> From: Alan Hayward >> CC: nd , Alan Hayward >> Date: Thu, 21 Feb 2019 13:23:44 +0000 >> >> Style is disabled when running in batch mode. >> >> gdb/ChangeLog: >> >> 2019-02-21 Alan Hayward >> >> * NEWS: Update style defaults. >> >> gdb/doc/ChangeLog: >> >> 2019-02-21 Alan Hayward >> >> * gdb.texinfo: Update style defaults. > > This is OK, but: > >> --- a/gdb/doc/gdb.texinfo >> +++ b/gdb/doc/gdb.texinfo >> @@ -24514,8 +24514,9 @@ Show the current pagination mode. >> @kindex set style >> @kindex show style >> @value{GDBN} can style its output on a capable terminal. This is >> -enabled by default on most systems. Various style settings are >> -available; and styles can also be disabled entirely. >> +enabled by default on most systems, but disabled by default when in >> +batch mode. Various style settings are available; and styles can >> +also be disabled entirely. > > Please insert "(@pxref{Mode Options})" (without the quotes) after > "batch mode", to provide the readers of the manual with a hyperlink to > where that mode is described. > > Thanks. Thanks! Patch pushed as: diff --git a/gdb/NEWS b/gdb/NEWS index eaef6aa384..8fe961b3f3 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -141,7 +141,7 @@ show tui tab-width NCHARS set style enabled [on|off] show style enabled Enable or disable terminal styling. Styling is enabled by default - on most hosts. + on most hosts, but disabled by default when in batch mode. set style filename foreground COLOR set style filename background COLOR diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 6b47026aa0..977cc7bbdb 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -24514,8 +24514,9 @@ Show the current pagination mode. @kindex set style @kindex show style @value{GDBN} can style its output on a capable terminal. This is -enabled by default on most systems. Various style settings are -available; and styles can also be disabled entirely. +enabled by default on most systems, but disabled by default when in +batch mode (@pxref{Mode Options}). Various style settings are available; +and styles can also be disabled entirely. @table @code @item set style enabled @samp{on|off}